Change in coreboot[master]: driver/intel/pmc_mux/conn: add conn_get_type_c_list() - coreboot-gerrit

3 Sep 2021


      Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57345 )
Change subject: driver/intel/pmc_mux/conn: add conn_get_type_c_list()
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/drivers/intel/pmc_mux/conn/conn.c:
https://review.coreboot.org/c/coreboot/+/57345/comment/4682313d_06ad7163 
PS3, Line 117: 	mux = pmc->link_list->children;
It could be any of the children, right? For the moment there is only
one, I suppose? Maybe at least leave a comment that one could check
for `drivers_intel_pmc_mux_ops` in case they are looking for it.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/57345
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic56a1ad1b617e3af000664147d21165e6ea3a742
Gerrit-Change-Number: 57345
Gerrit-PatchSet: 3
Gerrit-Owner: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Fri, 03 Sep 2021 15:26:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment