Attention is currently required from: Martin Roth, Jakub Czapiga, Paul Menzel, Julius Werner.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54072 )
Change subject: tests: code coverage improvements
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54072/comment/2a39ae64_fcf6c038
PS4, Line 7: tests: code coverage improvements
Please make it a statement by using a verb (in imperative mood) [1]. Maybe: […]
Done
File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/54072/comment/85378193_42938414
PS4, Line 204: COV=1 $(MAKE) coverage-report
nit: What about V=1? V=$(V) might be useful in some cases.
Done
https://review.coreboot.org/c/coreboot/+/54072/comment/9bc88436_e44d40d6
PS4, Line 207: COV=1 $(MAKE) clean-coverage-report
nit: Same as above
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54072
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bd2bfdedfab291aabeaa968c10b17e9b61c9c0a
Gerrit-Change-Number: 54072
Gerrit-PatchSet: 4
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 17 May 2021 17:18:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment