Attention is currently required from: Eric Lai, Karthik Ramasubramanian, Shelley Chen, Tanu Malhotra, Varshit Pandya, Yuval Peress.
Hello Eric Lai, Shelley Chen, Tanu Malhotra, Varshit Pandya, Yuval Peress, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81418?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed: Code-Review+1 by Varshit Pandya, Code-Review+2 by Eric Lai, Code-Review+2 by Shelley Chen, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: mb/google/brox: Configure ISH device based on FW_CONFIG ......................................................................
mb/google/brox: Configure ISH device based on FW_CONFIG
ISH Firmware name needs to be configured only when full sensing capabilities are enabled through ISH_ENABLE FW_CONFIG. Similarly DMA property needs to be added only when UFS is enabled through STORAGE_UFS FW_CONFIG. Hence configure the ISH device at run-time based on FW_CONFIG.
BUG=b:319164720 TEST=Build Brox BIOS image and boot to OS.
Change-Id: I678416acd48e03ab77ae299beae6e295a688b8df Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com --- M src/mainboard/google/brox/variants/brox/fw_config.c M src/mainboard/google/brox/variants/brox/overridetree.cb 2 files changed, 14 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/81418/3