Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46619 )
Change subject: mb/google/poppy: Add late_gpio support
......................................................................
Patch Set 3: Code-Review+1
seems slightly obnoxious to have to program GPIOs in bootblock, romstage, and twice in ramstage but hey, what can you do
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46619
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I847f90275740ca825e4c93e6b8d5650143228476
Gerrit-Change-Number: 46619
Gerrit-PatchSet: 3
Gerrit-Owner: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 17 Nov 2020 20:39:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment