Change in coreboot[master]: ec/starlabs/merlin: Disable ACPI support last when suspending - coreboot-gerrit

7 Mar 2022


      Attention is currently required from: Andy Pont.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62335 )
Change subject: ec/starlabs/merlin: Disable ACPI support last when suspending
......................................................................
Patch Set 5:
(1 comment)
File src/ec/starlabs/merlin/acpi/suspend.asl:
https://review.coreboot.org/c/coreboot/+/62335/comment/62dc1838_223524c5 
PS2, Line 18: 	_SB.PCI0.LPCB.EC.OSFG = 0x00
...
I would add a comment in here that says "Disable ACPI support.  This always has to be last because.. […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62335
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5705efab42d2fe0fd5abc6c17eeea46ead27db17
Gerrit-Change-Number: 62335
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Andy Pont andy.pont@sdcsystems.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Andy Pont andy.pont@sdcsystems.com
Gerrit-Comment-Date: Mon, 07 Mar 2022 09:04:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andy Pont andy.pont@sdcsystems.com
Gerrit-MessageType: comment