Attention is currently required from: Arthur Heymans, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81051?usp=email )
Change subject: soc/intel/cmn/cse: Simplify logic to get CSE RW version
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
I didn't realize Subrata was talking about you. Thanks for your the quick inputs. […]
I still think you should add at a minimum a comment showing the dependency. That's all Paul was asking for. It would be reasonable to explicitly add the dependency in the dockerfile as well.
As far as downstream is concerned, hexdump is already included in the chroot, but the version and feature set may not match what's included upstream(it may not be an issue in this case, just worth pointing out. Once the build switches to bazel you should be able to easily declare the version to be used).
```
$ which hexdump
/usr/bin/hexdump
$ hexdump --version
hexdump from util-linux 2.38.1
```
Have you tried building downstream with this and verified that it all works as intended?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81051?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I86f2848788d0576a8fe3557fa8048e4162e61e05
Gerrit-Change-Number: 81051
Gerrit-PatchSet: 3
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 30 Apr 2024 13:44:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment