Change in coreboot[master]: soc/amd/common/apob: Add support for asynchronously reading APOB_NV

[Raul Rangel (Code Review)]

Attention is currently required from: Jason Glenesk, Marshall Dawson, Julius Werner, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56232 )

Change subject: soc/amd/common/apob: Add support for asynchronously reading APOB_NV
......................................................................

Patch Set 7:

(3 comments)

File src/soc/amd/common/block/apob/apob_cache.c:

https://review.coreboot.org/c/coreboot/+/56232/comment/22162587_def00a80 
PS6, Line 71: 	if  (fmap_locate_area(DEFAULT_MRC_CACHE, r) < 0) {
> off-topic, but I'd really advise against juggling raw regions like this. […]

I think the reason we do this is because we start with the ro rdev, and if we need to update the SPI, then we switch to the rw rdev.

https://review.coreboot.org/c/coreboot/+/56232/comment/7ef8606d_c483593a 
PS6, Line 79: struct apob_thread_context {
> Should be static.

Done

https://review.coreboot.org/c/coreboot/+/56232/comment/1e743ffe_09a5e9b6 
PS6, Line 135: 	if (wait_for_thread(&global_apob_thread.handle) == CB_SUCCESS) {
> I think this should be guarded by COOP_MULTITASKING, it looks weird if you just rely on this returni […]

Done