Attention is currently required from: Eran Mitrani, Kapil Porwal.
Subrata Banik has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/82659?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: libpayload/libc: Include region device APIs
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82659/comment/0ab80d01_40f2f685?usp... :
PS1, Line 8:
can you please add one liner to explain which we need this inside lib payload.
also, may be worth checking if we are running into any issue due to 64-bit and 32-bit compilation
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82659?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I92a2504fcbf9035bdf3435c83eb6d5512c07a692
Gerrit-Change-Number: 82659
Gerrit-PatchSet: 1
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Mon, 27 May 2024 07:23:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No