build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30021 )
Change subject: mainboard/lenovo: Add ThinkPad T431s ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/#/c/30021/4/src/mainboard/lenovo/t431s/smihandle... File src/mainboard/lenovo/t431s/smihandler.c:
https://review.coreboot.org/#/c/30021/4/src/mainboard/lenovo/t431s/smihandle... PS4, Line 52: if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) < 0xf0) do not use assignment in if condition
https://review.coreboot.org/#/c/30021/4/src/mainboard/lenovo/t431s/smihandle... PS4, Line 60: if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) > 0x10) do not use assignment in if condition
https://review.coreboot.org/#/c/30021/4/src/mainboard/lenovo/t431s/smihandle... PS4, Line 76: switch (event) { switch and case should be at the same indent
https://review.coreboot.org/#/c/30021/4/src/mainboard/lenovo/t431s/smihandle... PS4, Line 98: switch (data) { switch and case should be at the same indent
https://review.coreboot.org/#/c/30021/4/src/mainboard/lenovo/t431s/smihandle... PS4, Line 108: /* we have to use port 0x62/0x66, as 0x1600/0x1604 doesn't line over 80 characters
-
build bot (Jenkins) (Code Review)