Attention is currently required from: Joel Linn, Michał Żygowski, MrChromebox, Nico Huber, Piotr Król.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81310?usp=email )
Change subject: superio/ite: Unify it8772f with common code
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/beltino/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/81310/comment/b3931820_c6a45e90 :
PS4, Line 86: register "FAN2.mode" = "FAN_SMART_SOFTWARE"
Matt, would you have a Beltino at hand to test if this feels like a regression? […]
in my tree, I have it set to 30% at startup, just so we don't have zero fan control until ACPI takes over. I'll push a follow-on patch for all the IT8772F ChromeOS devices setting it there
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81310?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic4d9d5460628e444dc20f620179b39c90dbc28c6
Gerrit-Change-Number: 81310
Gerrit-PatchSet: 5
Gerrit-Owner: Joel Linn
jl_coreboot@conductive.de
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: MrChromebox
mrchromebox@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Joel Linn
jl_coreboot@conductive.de
Gerrit-Attention: MrChromebox
mrchromebox@gmail.com
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Mon, 25 Mar 2024 13:46:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Joel Linn
jl_coreboot@conductive.de
Gerrit-MessageType: comment