Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49140 )
Change subject: soc/intel/skylake/acpi: Add PEP table
......................................................................
Patch Set 3:
Patch Set 3: -Code-Review
Patch Set 3: Code-Review-1
Patch Set 3: Code-Review+2
wait... did I really forget SKL? 😮
It was using PMC, not LPIT. Is that a problem?
No, vendor firmware for my Skylake board uses both devices as well. So this seems to be fine?
No, I reworked that. PMC/LPID/LPIT was actually confusing. PEP(D) is the "right" (or more correct) device name for this, so I cleaned this up but obviously forgot to add it to SKL as well 😄
LPIT is related but a (very) different table, though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49140
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08d8c1fde4f447e9292a0508649f802fdc2721e1
Gerrit-Change-Number: 49140
Gerrit-PatchSet: 3
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 06 Jan 2021 19:38:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment