Change in ...coreboot[master]: mainboard/asrock: remove stdlib.h when unused

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33889

Change subject: mainboard/asrock: remove stdlib.h when unused
......................................................................

mainboard/asrock: remove stdlib.h when unused

Change-Id: I14d3579f232b1dcc95b4e0653520686965dbe727
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/asrock/e350m1/BiosCallOuts.c
M src/mainboard/asrock/e350m1/buildOpts.c
M src/mainboard/asrock/imb-a180/BiosCallOuts.c
M src/mainboard/asrock/imb-a180/buildOpts.c
4 files changed, 0 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/33889/1

diff --git a/src/mainboard/asrock/e350m1/BiosCallOuts.c b/src/mainboard/asrock/e350m1/BiosCallOuts.c
index 491027a..5d7211c 100644
--- a/src/mainboard/asrock/e350m1/BiosCallOuts.c
+++ b/src/mainboard/asrock/e350m1/BiosCallOuts.c
@@ -17,7 +17,6 @@
 #include <amdlib.h>
 #include <northbridge/amd/agesa/BiosCallOuts.h>
 #include <SB800.h>
-#include <stdlib.h>

static AGESA_STATUS board_BeforeDramInit (UINT32 Func, UINTN Data, VOID *ConfigPtr);
diff --git a/src/mainboard/asrock/e350m1/buildOpts.c b/src/mainboard/asrock/e350m1/buildOpts.c
index 14621e0..9c6b3bd 100644
--- a/src/mainboard/asrock/e350m1/buildOpts.c
+++ b/src/mainboard/asrock/e350m1/buildOpts.c
@@ -25,10 +25,8 @@
  *
  */

-#include <stdlib.h>
 #include <AGESA.h>

-
 /*  Select the CPU family.  */
 #define INSTALL_FAMILY_10_SUPPORT FALSE
 #define INSTALL_FAMILY_12_SUPPORT FALSE
diff --git a/src/mainboard/asrock/imb-a180/BiosCallOuts.c b/src/mainboard/asrock/imb-a180/BiosCallOuts.c
index e05d5c0..983f9a8 100644
--- a/src/mainboard/asrock/imb-a180/BiosCallOuts.c
+++ b/src/mainboard/asrock/imb-a180/BiosCallOuts.c
@@ -18,7 +18,6 @@
 #include <northbridge/amd/agesa/BiosCallOuts.h>
 #include <northbridge/amd/agesa/state_machine.h>
 #include <FchPlatform.h>
-#include <stdlib.h>

const BIOS_CALLOUT_STRUCT BiosCallouts[] =
 {
diff --git a/src/mainboard/asrock/imb-a180/buildOpts.c b/src/mainboard/asrock/imb-a180/buildOpts.c
index d9d62e2..caa5e3b 100644
--- a/src/mainboard/asrock/imb-a180/buildOpts.c
+++ b/src/mainboard/asrock/imb-a180/buildOpts.c
@@ -25,7 +25,6 @@
  *
  */

-#include <stdlib.h>
 #include <AGESA.h>

#define INSTALL_FT3_SOCKET_SUPPORT           TRUE

Change in coreboot[master]: mainboard/asrock: Remove stdlib.h when unused

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33889

to look at the new patch set (#2).

Change subject: mainboard/asrock: Remove stdlib.h when unused
......................................................................

mainboard/asrock: Remove stdlib.h when unused

Change-Id: I14d3579f232b1dcc95b4e0653520686965dbe727
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/asrock/e350m1/BiosCallOuts.c
M src/mainboard/asrock/e350m1/buildOpts.c
M src/mainboard/asrock/imb-a180/BiosCallOuts.c
M src/mainboard/asrock/imb-a180/buildOpts.c
4 files changed, 0 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/33889/2

Change in coreboot[master]: mainboard/asrock: Remove stdlib.h when unused

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33889 )

Change subject: mainboard/asrock: Remove stdlib.h when unused
......................................................................

Abandoned

see 32023

Change in coreboot[master]: mainboard/asrock: Remove stdlib.h when unused

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/33889 )

Change subject: mainboard/asrock: Remove stdlib.h when unused
......................................................................

Restored

Change in coreboot[master]: mb/{asrock,asus}: Remove unused <stdlib.h>

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33889

to look at the new patch set (#3).

Change subject: mb/{asrock,asus}: Remove unused <stdlib.h>
......................................................................

mb/{asrock,asus}: Remove unused <stdlib.h>

Change-Id: I14d3579f232b1dcc95b4e0653520686965dbe727
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/asrock/e350m1/BiosCallOuts.c
M src/mainboard/asrock/e350m1/buildOpts.c
M src/mainboard/asrock/imb-a180/BiosCallOuts.c
M src/mainboard/asrock/imb-a180/buildOpts.c
M src/mainboard/asus/am1i-a/BiosCallOuts.c
M src/mainboard/asus/am1i-a/buildOpts.c
M src/mainboard/asus/f2a85-m/BiosCallOuts.c
M src/mainboard/asus/f2a85-m/buildOpts.c
8 files changed, 0 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/33889/3

Change in coreboot[master]: mb/{asrock,asus}: Remove unused <stdlib.h>

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33889

to look at the new patch set (#7).

Change subject: mb/{asrock,asus}: Remove unused <stdlib.h>
......................................................................

mb/{asrock,asus}: Remove unused <stdlib.h>

Change-Id: I14d3579f232b1dcc95b4e0653520686965dbe727
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/asrock/e350m1/BiosCallOuts.c
M src/mainboard/asrock/e350m1/buildOpts.c
M src/mainboard/asrock/imb-a180/BiosCallOuts.c
M src/mainboard/asrock/imb-a180/buildOpts.c
M src/mainboard/asus/f2a85-m/BiosCallOuts.c
M src/mainboard/asus/f2a85-m/buildOpts.c
6 files changed, 0 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/33889/7

Change in coreboot[master]: mb/{asrock,asus}: Remove unused <stdlib.h>

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33889 )

Change subject: mb/{asrock,asus}: Remove unused <stdlib.h>
......................................................................

Patch Set 7: Code-Review+2

Change in coreboot[master]: mb/{asrock,asus}: Remove unused <stdlib.h>

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/33889 )

Change subject: mb/{asrock,asus}: Remove unused <stdlib.h>
......................................................................

mb/{asrock,asus}: Remove unused <stdlib.h>

Change-Id: I14d3579f232b1dcc95b4e0653520686965dbe727
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33889
Tested-by: build bot (Jenkins) 
Reviewed-by: Kyösti Mälkki 
---
M src/mainboard/asrock/e350m1/BiosCallOuts.c
M src/mainboard/asrock/e350m1/buildOpts.c
M src/mainboard/asrock/imb-a180/BiosCallOuts.c
M src/mainboard/asrock/imb-a180/buildOpts.c
M src/mainboard/asus/f2a85-m/BiosCallOuts.c
M src/mainboard/asus/f2a85-m/buildOpts.c
6 files changed, 0 insertions(+), 6 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, approved

diff --git a/src/mainboard/asrock/e350m1/BiosCallOuts.c b/src/mainboard/asrock/e350m1/BiosCallOuts.c
index 491027a..5d7211c 100644
--- a/src/mainboard/asrock/e350m1/BiosCallOuts.c
+++ b/src/mainboard/asrock/e350m1/BiosCallOuts.c
@@ -17,7 +17,6 @@
 #include <amdlib.h>
 #include <northbridge/amd/agesa/BiosCallOuts.h>
 #include <SB800.h>
-#include <stdlib.h>

static AGESA_STATUS board_BeforeDramInit (UINT32 Func, UINTN Data, VOID *ConfigPtr);
diff --git a/src/mainboard/asrock/e350m1/buildOpts.c b/src/mainboard/asrock/e350m1/buildOpts.c
index 14621e0..0125b56 100644
--- a/src/mainboard/asrock/e350m1/buildOpts.c
+++ b/src/mainboard/asrock/e350m1/buildOpts.c
@@ -25,7 +25,6 @@
  *
  */

-#include <stdlib.h>
 #include <AGESA.h>

diff --git a/src/mainboard/asrock/imb-a180/BiosCallOuts.c b/src/mainboard/asrock/imb-a180/BiosCallOuts.c
index e05d5c0..983f9a8 100644
--- a/src/mainboard/asrock/imb-a180/BiosCallOuts.c
+++ b/src/mainboard/asrock/imb-a180/BiosCallOuts.c
@@ -18,7 +18,6 @@
 #include <northbridge/amd/agesa/BiosCallOuts.h>
 #include <northbridge/amd/agesa/state_machine.h>
 #include <FchPlatform.h>
-#include <stdlib.h>

const BIOS_CALLOUT_STRUCT BiosCallouts[] =
 {
diff --git a/src/mainboard/asrock/imb-a180/buildOpts.c b/src/mainboard/asrock/imb-a180/buildOpts.c
index d9d62e2..caa5e3b 100644
--- a/src/mainboard/asrock/imb-a180/buildOpts.c
+++ b/src/mainboard/asrock/imb-a180/buildOpts.c
@@ -25,7 +25,6 @@
  *
  */

-#include <stdlib.h>
 #include <AGESA.h>

#define INSTALL_FT3_SOCKET_SUPPORT           TRUE
diff --git a/src/mainboard/asus/f2a85-m/BiosCallOuts.c b/src/mainboard/asus/f2a85-m/BiosCallOuts.c
index 9e60ca7..15ce47e 100644
--- a/src/mainboard/asus/f2a85-m/BiosCallOuts.c
+++ b/src/mainboard/asus/f2a85-m/BiosCallOuts.c
@@ -18,7 +18,6 @@
 #include <northbridge/amd/agesa/state_machine.h>

#include <vendorcode/amd/agesa/f15tn/Proc/Fch/FchPlatform.h>
-#include <stdlib.h>

const BIOS_CALLOUT_STRUCT BiosCallouts[] =
 {
diff --git a/src/mainboard/asus/f2a85-m/buildOpts.c b/src/mainboard/asus/f2a85-m/buildOpts.c
index dc20dc7..8a1391d 100644
--- a/src/mainboard/asus/f2a85-m/buildOpts.c
+++ b/src/mainboard/asus/f2a85-m/buildOpts.c
@@ -25,7 +25,6 @@
  *
  */

-#include <stdlib.h>

#include <vendorcode/amd/agesa/f15tn/AGESA.h>