Change in coreboot[master]: soc/mediatek/mt8183: Set MMU default map length to 8GB befor mem init
Duan huayang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43795 )
Change subject: soc/mediatek/mt8183: Set MMU default map length to 8GB befor mem init ......................................................................
soc/mediatek/mt8183: Set MMU default map length to 8GB befor mem init
BUG=none BRANCH=kukui TEST=Boots correctly on Kukui
Change-Id: I072745933fe141cac26afd044836a564e345d036 Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/soc/mediatek/common/mmu_operations.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/43795/1
diff --git a/src/soc/mediatek/common/mmu_operations.c b/src/soc/mediatek/common/mmu_operations.c index 9550ba8..960d742 100644 --- a/src/soc/mediatek/common/mmu_operations.c +++ b/src/soc/mediatek/common/mmu_operations.c @@ -12,11 +12,11 @@ mmu_init();
/* - * Set 0x0 to 4GB address as device memory. We want to config IO_PHYS + * Set 0x0 to 8GB address as device memory. We want to config IO_PHYS * address to DEV_MEM, and map a proper range of dram for the memory * test during calibration. */ - mmu_config_range((void *)0, (uintptr_t)4U * GiB, DEV_MEM); + mmu_config_range((void *)0, (uintptr_t)8U * GiB, DEV_MEM);
/* SRAM is cached */ mmu_config_range(_sram, REGION_SIZE(sram), SECURE_CACHED_MEM);
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43795 )
Change subject: soc/mediatek/mt8183: Set MMU default map length to 8GB befor mem init ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43795/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43795/2//COMMIT_MSG@7 PS2, Line 7: befor befor*e*
Duan huayang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43795 )
Change subject: soc/mediatek/mt8183: Set MMU default map length to 8GB befor mem init ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43795/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43795/2//COMMIT_MSG@7 PS2, Line 7: befor
befor*e*
Done
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43795 )
Change subject: soc/mediatek/mt8183: Set MMU default map length to 8GB befor mem init ......................................................................
Patch Set 4: Code-Review+1
Hello build bot (Jenkins), Julius Werner, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43795
to look at the new patch set (#7).
Change subject: soc/mediatek/mt8183: Set MMU default map length to 8GB befor mem init ......................................................................
soc/mediatek/mt8183: Set MMU default map length to 8GB befor mem init
BUG=none BRANCH=kukui TEST=Boots correctly on Kukui
Change-Id: I072745933fe141cac26afd044836a564e345d036 Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/soc/mediatek/common/mmu_operations.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/43795/7
Hello build bot (Jenkins), Paul Menzel, Julius Werner, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43795
to look at the new patch set (#8).
Change subject: soc/mediatek/mt8183: Set MMU default map length to 8GB befor mem init ......................................................................
soc/mediatek/mt8183: Set MMU default map length to 8GB befor mem init
BUG=none BRANCH=kukui TEST=Boots correctly on Kukui
Change-Id: I072745933fe141cac26afd044836a564e345d036 Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/soc/mediatek/common/mmu_operations.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/43795/8
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43795 )
Change subject: soc/mediatek/mt8183: Set MMU default map length to 8GB befor mem init ......................................................................
Patch Set 8: Code-Review+2
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43795 )
Change subject: soc/mediatek/mt8183: Set MMU default map length to 8GB befor mem init ......................................................................
soc/mediatek/mt8183: Set MMU default map length to 8GB befor mem init
BUG=none BRANCH=kukui TEST=Boots correctly on Kukui
Change-Id: I072745933fe141cac26afd044836a564e345d036 Signed-off-by: Huayang Duan huayang.duan@mediatek.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43795 Reviewed-by: Hung-Te Lin hungte@chromium.org Reviewed-by: Yu-Ping Wu yupingso@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/mediatek/common/mmu_operations.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved Yu-Ping Wu: Looks good to me, but someone else must approve
diff --git a/src/soc/mediatek/common/mmu_operations.c b/src/soc/mediatek/common/mmu_operations.c index 9550ba8..960d742 100644 --- a/src/soc/mediatek/common/mmu_operations.c +++ b/src/soc/mediatek/common/mmu_operations.c @@ -12,11 +12,11 @@ mmu_init();
/* - * Set 0x0 to 4GB address as device memory. We want to config IO_PHYS + * Set 0x0 to 8GB address as device memory. We want to config IO_PHYS * address to DEV_MEM, and map a proper range of dram for the memory * test during calibration. */ - mmu_config_range((void *)0, (uintptr_t)4U * GiB, DEV_MEM); + mmu_config_range((void *)0, (uintptr_t)8U * GiB, DEV_MEM);
/* SRAM is cached */ mmu_config_range(_sram, REGION_SIZE(sram), SECURE_CACHED_MEM);
-
Angel Pons (Code Review) -
Duan huayang (Code Review)
-
Hung-Te Lin (Code Review)
-
Yu-Ping Wu (Code Review)