Change in coreboot[master]: mb/google/drallion: Update GPIO table

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

EricR Lai (Code Review)

1 Nov 2019 1 Nov '19

5:38 a.m.

EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36524 )

Change subject: mb/google/drallion: Update GPIO table ......................................................................

mb/google/drallion: Update GPIO table

Follow latest GPIO table to change gpio.

BUG=b:143728355 BRANCH=N/A TEST=build pass

Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Iee61c74a5cab5a62a90c0543f212650c4f2420de --- M src/mainboard/google/drallion/variants/drallion/gpio.c 1 file changed, 4 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/36524/1

diff --git a/src/mainboard/google/drallion/variants/drallion/gpio.c b/src/mainboard/google/drallion/variants/drallion/gpio.c index e699e4b..4ad5cfd 100644 --- a/src/mainboard/google/drallion/variants/drallion/gpio.c +++ b/src/mainboard/google/drallion/variants/drallion/gpio.c @@ -39,14 +39,12 @@ /* ESPI_RESET# */ /* SUSACK# */ PAD_CFG_GPO(GPP_A15, 0, DEEP), /* SD_1P8_SEL */ PAD_CFG_GPI(GPP_A16, NONE, PLTRST), /* 2.7MM_CAM_DET# */ -/* SD_PWR_EN# */ PAD_CFG_NF(GPP_A17, NONE, DEEP, NF2), - /* ISH_ACC1_INT# */ +/* SD_PWR_EN# */ PAD_NC(GPP_A17, NONE), /* ISH_ACC1_INT# */ /* ISH_GP0 */ PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), /* ISH_ACC2_INT# */ /* ISH_GP1 */ PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), /* ISH_GP2 */ PAD_CFG_NF(GPP_A20, NONE, DEEP, NF1), -/* ISH_GP3 */ PAD_CFG_NF(GPP_A21, NONE, DEEP, NF1), - /* ISH_NB_MODE */ +/* ISH_GP3 */ PAD_NC(GPP_A21, NONE), /* ISH_NB_MODE */ /* ISH_GP4 */ PAD_CFG_NF(GPP_A22, NONE, DEEP, NF1), /* ISH_LID_CL#_NB */ /* ISH_GP5 */ PAD_CFG_NF(GPP_A23, NONE, DEEP, NF1), @@ -64,10 +62,9 @@ /* WLAN_CLKREQ_CPU_N */ /* SRCCLKREQ2# */ PAD_CFG_NF(GPP_B7, NONE, DEEP, NF1), /* WWAN_CLKREQ_CPU_N */ -/* SRCCLKREQ3# */ PAD_CFG_NF(GPP_B8, NONE, DEEP, NF1), - /* SSD_CKLREQ_CPU_N */ +/* SRCCLKREQ3# */ PAD_NC(GPP_B8, NONE), /* SRCCLKREQ4# */ PAD_CFG_NF(GPP_B9, NONE, DEEP, NF1), -/* SRCCLKREQ5# */ PAD_CFG_NF(GPP_B10, NONE, DEEP, NF1), +/* SRCCLKREQ5# */ PAD_NC(GPP_B10, NONE), /* EXT_PWR_GATE# */ PAD_CFG_GPO(GPP_B11, 0, PLTRST), /* 3.3V_CAM_EN# */ /* SLP_S0# */ PAD_CFG_NF(GPP_B12, NONE, DEEP, NF1), /* PLTRST# */ PAD_CFG_NF(GPP_B13, NONE, DEEP, NF1),

Attachments:

attachment.htm (text/html — 4.3 KB)

Show replies by date

John Su (Code Review)

1 Nov 1 Nov

8:55 a.m.

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36524 )

Change subject: mb/google/drallion: Update GPIO table ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36524 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee61c74a5cab5a62a90c0543f212650c4f2420de Gerrit-Change-Number: 36524 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 01 Nov 2019 08:55:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Mathew King (Code Review)

4:18 p.m.

Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36524 )

Change subject: mb/google/drallion: Update GPIO table ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36524/1/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/gpio.c:

https://review.coreboot.org/c/coreboot/+/36524/1/src/mainboard/google/dralli... PS1, Line 47: /* ISH_GP3 */ PAD_NC(GPP_A21, NONE), /* ISH_NB_MODE */ Will this disable the gpio from the ish?

-- To view, visit https://review.coreboot.org/c/coreboot/+/36524 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee61c74a5cab5a62a90c0543f212650c4f2420de Gerrit-Change-Number: 36524 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 01 Nov 2019 16:18:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

EricR Lai (Code Review)

5:10 p.m.

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36524 )

Change subject: mb/google/drallion: Update GPIO table ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36524/1/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/gpio.c:

https://review.coreboot.org/c/coreboot/+/36524/1/src/mainboard/google/dralli... PS1, Line 47: /* ISH_GP3 */ PAD_NC(GPP_A21, NONE), /* ISH_NB_MODE */

...

Will this disable the gpio from the ish?

I think if we set NC, ISH can control this pin. So, yes. @Bora, could you help confirm this?

-- To view, visit https://review.coreboot.org/c/coreboot/+/36524 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee61c74a5cab5a62a90c0543f212650c4f2420de Gerrit-Change-Number: 36524 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 01 Nov 2019 17:10:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Mathew King mathewk@chromium.org Gerrit-MessageType: comment

Bora Guvendik (Code Review)

6:08 p.m.

Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36524 )

Change subject: mb/google/drallion: Update GPIO table ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36524/1/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/gpio.c:

https://review.coreboot.org/c/coreboot/+/36524/1/src/mainboard/google/dralli... PS1, Line 47: /* ISH_GP3 */ PAD_NC(GPP_A21, NONE), /* ISH_NB_MODE */

...

I think if we set NC, ISH can control this pin. So, yes. […]

Okay according to Tim.

-- To view, visit https://review.coreboot.org/c/coreboot/+/36524 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee61c74a5cab5a62a90c0543f212650c4f2420de Gerrit-Change-Number: 36524 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 01 Nov 2019 18:08:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: EricR Lai ericr_lai@compal.corp-partner.google.com Comment-In-Reply-To: Mathew King mathewk@chromium.org Gerrit-MessageType: comment

EricR Lai (Code Review)

6:24 p.m.

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36524 )

Change subject: mb/google/drallion: Update GPIO table ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36524/1/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/gpio.c:

https://review.coreboot.org/c/coreboot/+/36524/1/src/mainboard/google/dralli... PS1, Line 47: /* ISH_GP3 */ PAD_NC(GPP_A21, NONE), /* ISH_NB_MODE */

...

Okay according to Tim.

I check Arcada... I think I put the wrong comment NB_MODE is A22.. A17 and A21 is NC in Arcada. I fix this later.

-- To view, visit https://review.coreboot.org/c/coreboot/+/36524 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee61c74a5cab5a62a90c0543f212650c4f2420de Gerrit-Change-Number: 36524 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 01 Nov 2019 18:24:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: EricR Lai ericr_lai@compal.corp-partner.google.com Comment-In-Reply-To: Mathew King mathewk@chromium.org Comment-In-Reply-To: Bora Guvendik bora.guvendik@intel.com Gerrit-MessageType: comment

EricR Lai (Code Review)

6:29 p.m.

Hello Ivy Jian, Mathew King, Bora Guvendik, John Su, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36524

to look at the new patch set (#2).

Change subject: mb/google/drallion: Update GPIO table ......................................................................

mb/google/drallion: Update GPIO table

Follow latest GPIO table to change gpio.

BUG=b:143728355 BRANCH=N/A TEST=build pass

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/36524/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36524 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee61c74a5cab5a62a90c0543f212650c4f2420de Gerrit-Change-Number: 36524 Gerrit-PatchSet: 2 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

EricR Lai (Code Review)

6:31 p.m.

Hello Ivy Jian, Mathew King, Bora Guvendik, John Su, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36524

to look at the new patch set (#3).

Change subject: mb/google/drallion: Update GPIO table ......................................................................

mb/google/drallion: Update GPIO table

Follow latest GPIO table to change gpio.

BUG=b:143728355 BRANCH=N/A TEST=build pass

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/36524/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/36524 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee61c74a5cab5a62a90c0543f212650c4f2420de Gerrit-Change-Number: 36524 Gerrit-PatchSet: 3 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Mathew King (Code Review)

10:56 p.m.

Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36524 )

Change subject: mb/google/drallion: Update GPIO table ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36524 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee61c74a5cab5a62a90c0543f212650c4f2420de Gerrit-Change-Number: 36524 Gerrit-PatchSet: 3 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 01 Nov 2019 22:56:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

4 Nov 4 Nov

11:33 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36524 )

Change subject: mb/google/drallion: Update GPIO table ......................................................................

mb/google/drallion: Update GPIO table

Follow latest GPIO table to change gpio.

BUG=b:143728355 BRANCH=N/A TEST=build pass

Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Iee61c74a5cab5a62a90c0543f212650c4f2420de Reviewed-on: https://review.coreboot.org/c/coreboot/+/36524 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Mathew King mathewk@chromium.org --- M src/mainboard/google/drallion/variants/drallion/gpio.c 1 file changed, 4 insertions(+), 5 deletions(-)

Approvals: build bot (Jenkins): Verified Mathew King: Looks good to me, approved

diff --git a/src/mainboard/google/drallion/variants/drallion/gpio.c b/src/mainboard/google/drallion/variants/drallion/gpio.c index 697d305..5657eea 100644 --- a/src/mainboard/google/drallion/variants/drallion/gpio.c +++ b/src/mainboard/google/drallion/variants/drallion/gpio.c @@ -39,13 +39,13 @@ /* ESPI_RESET# */ /* SUSACK# */ PAD_CFG_GPO(GPP_A15, 0, DEEP), /* SD_1P8_SEL */ PAD_CFG_GPI(GPP_A16, NONE, PLTRST), /* 2.7MM_CAM_DET# */ -/* SD_PWR_EN# */ PAD_CFG_NF(GPP_A17, NONE, DEEP, NF2), +/* SD_PWR_EN# */ PAD_NC(GPP_A17, NONE), /* ISH_ACC1_INT# */ /* ISH_GP0 */ PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), /* ISH_ACC2_INT# */ /* ISH_GP1 */ PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), /* ISH_GP2 */ PAD_CFG_NF(GPP_A20, NONE, DEEP, NF1), -/* ISH_GP3 */ PAD_CFG_NF(GPP_A21, NONE, DEEP, NF1), +/* ISH_GP3 */ PAD_NC(GPP_A21, NONE), /* ISH_NB_MODE */ /* ISH_GP4 */ PAD_CFG_NF(GPP_A22, NONE, DEEP, NF1), /* ISH_LID_CL#_NB */ @@ -63,11 +63,10 @@ /* SRCCLKREQ1# */ PAD_CFG_NF(GPP_B6, NONE, DEEP, NF1), /* WLAN_CLKREQ_CPU_N */ /* SRCCLKREQ2# */ PAD_CFG_NF(GPP_B7, NONE, DEEP, NF1), - /* WWAN_CLKREQ_CPU_N */ -/* SRCCLKREQ3# */ PAD_CFG_NF(GPP_B8, NONE, DEEP, NF1), +/* SRCCLKREQ3# */ PAD_NC(GPP_B8, NONE), /* SSD_CKLREQ_CPU_N */ /* SRCCLKREQ4# */ PAD_CFG_NF(GPP_B9, NONE, DEEP, NF1), -/* SRCCLKREQ5# */ PAD_CFG_NF(GPP_B10, NONE, DEEP, NF1), +/* SRCCLKREQ5# */ PAD_NC(GPP_B10, NONE), /* EXT_PWR_GATE# */ PAD_CFG_GPO(GPP_B11, 0, PLTRST), /* 3.3V_CAM_EN# */ /* SLP_S0# */ PAD_CFG_NF(GPP_B12, NONE, DEEP, NF1), /* PLTRST# */ PAD_CFG_NF(GPP_B13, NONE, DEEP, NF1),

-- To view, visit https://review.coreboot.org/c/coreboot/+/36524 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee61c74a5cab5a62a90c0543f212650c4f2420de Gerrit-Change-Number: 36524 Gerrit-PatchSet: 4 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1792

days inactive

1795

days old

coreboot-gerrit@coreboot.org

9 comments

5 participants

tags (0)

participants (5)

Bora Guvendik (Code Review)
EricR Lai (Code Review)
John Su (Code Review)
Mathew King (Code Review)
Patrick Georgi (Code Review)