Attention is currently required from: Michael Niewöhner, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52103 )
Change subject: soc/intel/cannonlake: Drop unused `SataDevSlpRstConfig`
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/cannonlake/chip.h:
https://review.coreboot.org/c/coreboot/+/52103/comment/5c00a5dd_b0a22a2d
PS3, Line 128: /* SATA devslp pad reset configuration */
: enum {
: SataDevSlpResumeReset = 1,
: SataDevSlpHostDeepReset = 3,
: SataDevSlpPlatformReset = 5,
: SataDevSlpDswReset = 7
: };
OK, I have to move this out of the struct
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52103
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff3e896463575295c489032e04955bb5a7ba6355
Gerrit-Change-Number: 52103
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 23 Dec 2021 13:36:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment