David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37831 )
Change subject: mb/goog/hatch/var/kindred: Tune i2c frequency to 400 KHz ......................................................................
mb/goog/hatch/var/kindred: Tune i2c frequency to 400 KHz
Tuning i2c frequency for kindred: I2C0: 391.8 KHz I2C1: 396.4 KHz I2C4: 388.8 KHz
BUG=b:146535585 BRANCH=hatch TEST=emerge-hatch coreboot chromeos-bootimage
Change-Id: I55d095efb60eba4e860b54bb90e8e0df62d88419 Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/kindred/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/37831/1
diff --git a/src/mainboard/google/hatch/variants/kindred/overridetree.cb b/src/mainboard/google/hatch/variants/kindred/overridetree.cb index 1122609..3bc5669 100644 --- a/src/mainboard/google/hatch/variants/kindred/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kindred/overridetree.cb @@ -36,12 +36,18 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 50, + .fall_time_ns = 15, }, .i2c[1] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 60, + .fall_time_ns = 25, }, .i2c[4] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 60, + .fall_time_ns = 60, }, }"
David Wu has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/37831 )
Change subject: mb/google/hatch/var/kindred: Tune i2c frequency to 400 KHz ......................................................................
mb/google/hatch/var/kindred: Tune i2c frequency to 400 KHz
Tuning i2c frequency for kindred: I2C0: 391.8 KHz I2C1: 396.4 KHz I2C4: 388.8 KHz
BUG=b:146535585 BRANCH=hatch TEST=emerge-hatch coreboot chromeos-bootimage
Change-Id: I55d095efb60eba4e860b54bb90e8e0df62d88419 Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/kindred/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/37831/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37831 )
Change subject: mb/google/hatch/var/kindred: Tune i2c frequency to 400 KHz ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37831/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37831/2//COMMIT_MSG@8 PS2, Line 8: What is the frequency before the patch?
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37831 )
Change subject: mb/google/hatch/var/kindred: Tune i2c frequency to 400 KHz ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37831/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37831/2//COMMIT_MSG@8 PS2, Line 8:
What is the frequency before the patch?
SOC I2C0: 479.4 KHz SOC i2C1: 491.4 KHz SOC i2C4: 476.4 KHz
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37831 )
Change subject: mb/google/hatch/var/kindred: Tune i2c frequency to 400 KHz ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37831/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37831/2//COMMIT_MSG@7 PS2, Line 7: Tune Decrease
https://review.coreboot.org/c/coreboot/+/37831/2//COMMIT_MSG@7 PS2, Line 7: to below
https://review.coreboot.org/c/coreboot/+/37831/2//COMMIT_MSG@8 PS2, Line 8:
SOC I2C0: 479.4 KHz […]
Nice. Could you please update the commit message accordingly?
Hello Paul Fagerburg, Tim Wawrzynczak, Philip Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37831
to look at the new patch set (#3).
Change subject: mb/google/hatch/var/kindred: Decrease i2c frequency below 400 KHz ......................................................................
mb/google/hatch/var/kindred: Decrease i2c frequency below 400 KHz
Tuning i2c frequency for kindred: I2C0: 391.8 KHz I2C1: 396.4 KHz I2C4: 388.8 KHz
BUG=b:146535585 BRANCH=hatch TEST=emerge-hatch coreboot chromeos-bootimage
Change-Id: I55d095efb60eba4e860b54bb90e8e0df62d88419 Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/kindred/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/37831/3
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37831 )
Change subject: mb/google/hatch/var/kindred: Decrease i2c frequency below 400 KHz ......................................................................
Patch Set 3:
(3 comments)
Thanks.
https://review.coreboot.org/c/coreboot/+/37831/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37831/2//COMMIT_MSG@7 PS2, Line 7: Tune
Decrease
Done
https://review.coreboot.org/c/coreboot/+/37831/2//COMMIT_MSG@7 PS2, Line 7: to
below
Done
https://review.coreboot.org/c/coreboot/+/37831/2//COMMIT_MSG@8 PS2, Line 8:
Nice. […]
Done
Hello Paul Fagerburg, Tim Wawrzynczak, Philip Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37831
to look at the new patch set (#4).
Change subject: mb/google/hatch/var/kindred: Decrease i2c frequency below 400 KHz ......................................................................
mb/google/hatch/var/kindred: Decrease i2c frequency below 400 KHz
Tuning i2c frequency for kindred: I2C0: 391.8 KHz I2C1: 396.4 KHz I2C4: 388.8 KHz
BUG=b:146535585 BRANCH=hatch TEST=emerge-hatch coreboot chromeos-bootimage
Change-Id: I55d095efb60eba4e860b54bb90e8e0df62d88419 Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/kindred/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/37831/4
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37831 )
Change subject: mb/google/hatch/var/kindred: Decrease i2c frequency below 400 KHz ......................................................................
Patch Set 4: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37831 )
Change subject: mb/google/hatch/var/kindred: Decrease i2c frequency below 400 KHz ......................................................................
Patch Set 4: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37831 )
Change subject: mb/google/hatch/var/kindred: Decrease i2c frequency below 400 KHz ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37831/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37831/2//COMMIT_MSG@8 PS2, Line 8:
Done
Hmm, it’s not in the latest commit message.
Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37831 )
Change subject: mb/google/hatch/var/kindred: Decrease i2c frequency below 400 KHz ......................................................................
Patch Set 4: Code-Review+2
Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37831 )
Change subject: mb/google/hatch/var/kindred: Decrease i2c frequency below 400 KHz ......................................................................
Patch Set 4: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/37831/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37831/2//COMMIT_MSG@8 PS2, Line 8:
Hmm, it’s not in the latest commit message.
David, please add the frequencies before the patch into the commit message.
Hello Paul Fagerburg, Tim Wawrzynczak, Philip Chen, Paul Menzel, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37831
to look at the new patch set (#5).
Change subject: mb/google/hatch/var/kindred: Decrease i2c frequency below 400 KHz ......................................................................
mb/google/hatch/var/kindred: Decrease i2c frequency below 400 KHz
Before tuning i2c frequency, I2C0: 479.4 KHz I2C1: 491.4 KHz I2C4: 476.4 KHz
After tuning i2c frequency, I2C0: 391.8 KHz I2C1: 396.4 KHz I2C4: 388.8 KHz
BUG=b:146535585 BRANCH=hatch TEST=emerge-hatch coreboot chromeos-bootimage
Change-Id: I55d095efb60eba4e860b54bb90e8e0df62d88419 Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/kindred/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/37831/5
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37831 )
Change subject: mb/google/hatch/var/kindred: Decrease i2c frequency below 400 KHz ......................................................................
Patch Set 5:
(1 comment)
Thanks.
https://review.coreboot.org/c/coreboot/+/37831/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37831/2//COMMIT_MSG@8 PS2, Line 8:
David, please add the frequencies before the patch into the commit message.
Done
Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37831 )
Change subject: mb/google/hatch/var/kindred: Decrease i2c frequency below 400 KHz ......................................................................
Patch Set 5: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37831 )
Change subject: mb/google/hatch/var/kindred: Decrease i2c frequency below 400 KHz ......................................................................
mb/google/hatch/var/kindred: Decrease i2c frequency below 400 KHz
Before tuning i2c frequency, I2C0: 479.4 KHz I2C1: 491.4 KHz I2C4: 476.4 KHz
After tuning i2c frequency, I2C0: 391.8 KHz I2C1: 396.4 KHz I2C4: 388.8 KHz
BUG=b:146535585 BRANCH=hatch TEST=emerge-hatch coreboot chromeos-bootimage
Change-Id: I55d095efb60eba4e860b54bb90e8e0df62d88419 Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37831 Reviewed-by: Philip Chen philipchen@google.com Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/kindred/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Philip Chen: Looks good to me, approved Paul Fagerburg: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/kindred/overridetree.cb b/src/mainboard/google/hatch/variants/kindred/overridetree.cb index 1122609..a000add 100644 --- a/src/mainboard/google/hatch/variants/kindred/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kindred/overridetree.cb @@ -36,12 +36,18 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 50, + .fall_time_ns = 15, }, .i2c[1] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 60, + .fall_time_ns = 25, }, .i2c[4] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 60, + .fall_time_ns = 60, }, }"
-
David Wu (Code Review) -
Patrick Georgi (Code Review)
-
Paul Fagerburg (Code Review)
-
Paul Menzel (Code Review)
-
Philip Chen (Code Review)