Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Felix Held, Zhuohao Lee.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62627 )
Change subject: mb/google/brya/var/kinox: Modify 15W SOC PL2/PL4 default setting
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS2:
Thanks Felix, Dtrain you will need to rebase on master and update PCI_DEVICE_ID_ to PCI_DID_
Done
File src/mainboard/google/brya/variants/kinox/ramstage.c:
https://review.coreboot.org/c/coreboot/+/62627/comment/2c6e3fe2_c21578fb
PS2, Line 13: PCI_DEVICE_ID_INTEL_ADL_P_ID_10
this patch needs to be updated since CB:39331 landed in the meantime
Thanks Felix for review. Rebase and update naming.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62627
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2956705f7d26929c7cf2dd4e852fc61b619a83e5
Gerrit-Change-Number: 62627
Gerrit-PatchSet: 4
Gerrit-Owner: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Comment-Date: Thu, 10 Mar 2022 02:11:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment