HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35987 )
Change subject: superio/common: Remove unused include 'pnp_def.h' ......................................................................
superio/common: Remove unused include 'pnp_def.h'
Change-Id: I2d0b3d73d646fc43f2562aa5af2358398eaf28b0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/common/generic.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/35987/1
diff --git a/src/superio/common/generic.c b/src/superio/common/generic.c index 76122a1..429ee51 100644 --- a/src/superio/common/generic.c +++ b/src/superio/common/generic.c @@ -15,7 +15,6 @@ #include <device/device.h> #include <device/pnp.h> #include <arch/acpigen.h> -#include <device/pnp_def.h> #include <console/console.h>
static void generic_set_resources(struct device *dev)
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35987 )
Change subject: superio/common: Remove unused include 'pnp_def.h' ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35987 )
Change subject: superio/common: Remove unused include 'pnp_def.h' ......................................................................
superio/common: Remove unused include 'pnp_def.h'
Change-Id: I2d0b3d73d646fc43f2562aa5af2358398eaf28b0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/35987 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/superio/common/generic.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/superio/common/generic.c b/src/superio/common/generic.c index 76122a1..429ee51 100644 --- a/src/superio/common/generic.c +++ b/src/superio/common/generic.c @@ -15,7 +15,6 @@ #include <device/device.h> #include <device/pnp.h> #include <arch/acpigen.h> -#include <device/pnp_def.h> #include <console/console.h>
static void generic_set_resources(struct device *dev)
-
Felix Held (Code Review) -
HAOUAS Elyes (Code Review)