Change in coreboot[master]: fit_payload: Always set DT size

[Julius Werner (Code Review)]

Hello Patrick Rudolph,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/34224

to review the following change.

Change subject: fit_payload: Always set DT size
......................................................................

fit_payload: Always set DT size

CB:32870 changed FIT loading code to make an FDT mandatory (because the
platforms that can use FIT images always need an FDT). Remove one
left-over conditional that is now dead code.

Found by Coverity.

Change-Id: Ia7765d45f068ab4bdc720ea7ae87dcc62a4b7d3d
Signed-off-by: Julius Werner 
---
M src/lib/fit_payload.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/34224/1

diff --git a/src/lib/fit_payload.c b/src/lib/fit_payload.c
index 8e75915..a4d3705 100644
--- a/src/lib/fit_payload.c
+++ b/src/lib/fit_payload.c
@@ -228,7 +228,7 @@

/* Collect infos for fit_payload_arch */
    kernel.size = config->kernel->size;
-	fdt.size = dt ? dt_flat_size(dt) : 0;
+	fdt.size = dt_flat_size(dt);
    initrd.size = config->ramdisk ? config->ramdisk->size : 0;

/* Invoke arch specific payload placement and fixups */

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34224 )

Change subject: fit_payload: Always set DT size
......................................................................

Patch Set 1: Code-Review+2

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34224 )

Change subject: fit_payload: Always set DT size
......................................................................

fit_payload: Always set DT size

CB:32870 changed FIT loading code to make an FDT mandatory (because the
platforms that can use FIT images always need an FDT). Remove one
left-over conditional that is now dead code.

Found by Coverity.

Change-Id: Ia7765d45f068ab4bdc720ea7ae87dcc62a4b7d3d
Signed-off-by: Julius Werner 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34224
Tested-by: build bot (Jenkins) 
Reviewed-by: Patrick Rudolph 
---
M src/lib/fit_payload.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Rudolph: Looks good to me, approved

diff --git a/src/lib/fit_payload.c b/src/lib/fit_payload.c
index 8e75915..a4d3705 100644
--- a/src/lib/fit_payload.c
+++ b/src/lib/fit_payload.c
@@ -228,7 +228,7 @@

/* Collect infos for fit_payload_arch */
    kernel.size = config->kernel->size;
-	fdt.size = dt ? dt_flat_size(dt) : 0;
+	fdt.size = dt_flat_size(dt);
    initrd.size = config->ramdisk ? config->ramdisk->size : 0;

/* Invoke arch specific payload placement and fixups */