Matt Papageorge has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44002 )
Change subject: mb/google/kahlee: Set EFS SPI platform configuration ......................................................................
mb/google/kahlee: Set EFS SPI platform configuration
Set platform defaults for SPI settings in Kconfig for EFS for Kahlee based platforms.
BUG=b:158755102 TEST=Build test. I have no device for a boot test.
Change-Id: I9b979d79ad2dc920e8baf288ddfab04f04f42789 Signed-off-by: Matt Papageorge matthewpapa07@gmail.com --- M src/mainboard/google/kahlee/Kconfig M src/soc/amd/stoneyridge/Makefile.inc 2 files changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/44002/1
diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig index a9ba0f5..9ce3760 100644 --- a/src/mainboard/google/kahlee/Kconfig +++ b/src/mainboard/google/kahlee/Kconfig @@ -127,4 +127,14 @@ config USE_PSPSECUREOS def_bool n
+config EFS_SPI_READ_MODE + int + default 4 + default 0 if EM100 + +config EFS_SPI_SPEED + int + default 0 + default 3 if EM100 + endif # BOARD_GOOGLE_BASEBOARD_KAHLEE diff --git a/src/soc/amd/stoneyridge/Makefile.inc b/src/soc/amd/stoneyridge/Makefile.inc index 0d7b5d1..ecb1414 100644 --- a/src/soc/amd/stoneyridge/Makefile.inc +++ b/src/soc/amd/stoneyridge/Makefile.inc @@ -193,6 +193,8 @@ SUBPROG_FN_SMU_FW=1 OPT_SMUFWM_FN_FILE=$(call add_opt_prefix, $(SMUFWM_FN_FILE), --subprogram $(SUBPROG_FN_SMU_FW) --smufirmware) OPT_SMUFIRMWARE2_FN_FILE=$(call add_opt_prefix, $(SMUFIRMWARE2_FN_FILE), --subprogram $(SUBPROG_FN_SMU_FW) --smufirmware2) +OPT_EFS_SPI_READ_MODE=$(call add_opt_prefix, $(CONFIG_EFS_SPI_READ_MODE), --spi-read-mode) +OPT_EFS_SPI_SPEED=$(call add_opt_prefix, $(CONFIG_EFS_SPI_SPEED), --spi-speed)
ifeq ($(FIRMWARE_TYPE),ST) OPT_COMBOCAPABLE=--combo-capable @@ -247,6 +249,9 @@ $(OPT_SMUFIRMWARE2_FN_FILE) \ $(OPT_SMUSCS_FILE) \ $(OPT_COMBOCAPABLE)\ + $(OPT_EFS_SPI_READ_MODE) \ + $(OPT_EFS_SPI_SPEED) \ + --soc-name "Stoneyridge" \ --flashsize $(CONFIG_ROM_SIZE) \ --location $(shell printf "0x%x" $(STONEYRIDGE_FWM_POSITION)) \ --output $@
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44002 )
Change subject: mb/google/kahlee: Set EFS SPI platform configuration ......................................................................
Patch Set 1: Code-Review+2
Matt Papageorge has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44002 )
Change subject: mb/google/kahlee: Set EFS SPI platform configuration ......................................................................
Patch Set 2:
I have refactored the change as follows. 1. Kconfig changes 2. Build changes for picasso platforms 3. Build changes for stoney ridge platforms
An optional future 4th change would be to address the duplicate definition of this information in mainboard/google/kahlee/bootblock/bootblock.c mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44002 )
Change subject: mb/google/kahlee: Set EFS SPI platform configuration ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44002/2/src/mainboard/google/kahlee... File src/mainboard/google/kahlee/Kconfig:
https://review.coreboot.org/c/coreboot/+/44002/2/src/mainboard/google/kahlee... PS2, Line 132: default 4 : default 0 if EM100 the EM100 needs to go above the other default value.
Hello build bot (Jenkins), Raul Rangel, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44002
to look at the new patch set (#3).
Change subject: mb/google/kahlee: Set EFS SPI platform configuration ......................................................................
mb/google/kahlee: Set EFS SPI platform configuration
Set platform defaults for SPI settings in Kconfig for EFS for Kahlee based platforms.
BUG=b:158755102 TEST=Build test. I have no device for a boot test.
Change-Id: I9b979d79ad2dc920e8baf288ddfab04f04f42789 Signed-off-by: Matt Papageorge matthewpapa07@gmail.com --- M src/mainboard/google/kahlee/Kconfig M src/soc/amd/stoneyridge/Makefile.inc 2 files changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/44002/3
Matt Papageorge has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44002 )
Change subject: mb/google/kahlee: Set EFS SPI platform configuration ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44002/2/src/mainboard/google/kahlee... File src/mainboard/google/kahlee/Kconfig:
https://review.coreboot.org/c/coreboot/+/44002/2/src/mainboard/google/kahlee... PS2, Line 132: default 4 : default 0 if EM100
the EM100 needs to go above the other default value.
Done
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44002 )
Change subject: mb/google/kahlee: Set EFS SPI platform configuration ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44002/6/src/mainboard/google/kahlee... File src/mainboard/google/kahlee/Kconfig:
https://review.coreboot.org/c/coreboot/+/44002/6/src/mainboard/google/kahlee... PS6, Line 133: 4 Can you add comments like zork/Kconfig so it's easy to understand what the integers mean?
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44002?usp=email )
Change subject: mb/google/kahlee: Set EFS SPI platform configuration ......................................................................
Abandoned
This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
-
Martin L Roth (Code Review) -
Martin Roth (Code Review)
-
Matt Papageorge (Code Review)
-
Raul Rangel (Code Review)