Attention is currently required from: Furquan Shaikh, Sumeet R Pawnikar. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52859 )
Change subject: mb/google/brya: enable DPTF functionality for brya ......................................................................
Patch Set 2: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52859/comment/5a9772fd_567c586f PS2, Line 13: tested What all did you test?
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/52859/comment/27e8360d_a0a401d8 PS2, Line 11: # Default DPTF Policy for all Brya boards if not overridden This comment is not true anymore (this isn't the baseboard)
https://review.coreboot.org/c/coreboot/+/52859/comment/62b62871_68396120 PS2, Line 23: nit: remove a few of these tabs?
https://review.coreboot.org/c/coreboot/+/52859/comment/09520a48_2ce1c39b PS2, Line 12: ## sensor information : register "options.tsr[0].desc" = ""DRAM"" : register "options.tsr[1].desc" = ""Charger"" : register "options.tsr[2].desc" = ""Ambient"" : : # TODO: below values are initial reference values only : ## Active Policy : register "policies.active" = "{ : [0] = { : .target = DPTF_CPU, : .thresholds = { : TEMP_PCT(85, 90), : TEMP_PCT(80, 80), : TEMP_PCT(75, 70), : } : }, : [1] = { : .target = DPTF_TEMP_SENSOR_2, : .thresholds = { : TEMP_PCT(70, 90), : TEMP_PCT(60, 80), : TEMP_PCT(50, 70), : } : } : }" : : ## Passive Policy : register "policies.passive" = "{ : [0] = DPTF_PASSIVE(CPU, CPU, 95, 5000), : [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_0, 75, 5000), : [2] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_1, 75, 5000), : [3] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 75, 5000) : }" : : ## Critical Policy : register "policies.critical" = "{ : [0] = DPTF_CRITICAL(CPU, 105, SHUTDOWN), : [1] = DPTF_CRITICAL(TEMP_SENSOR_0, 85, SHUTDOWN), : [2] = DPTF_CRITICAL(TEMP_SENSOR_1, 85, SHUTDOWN), : [3] = DPTF_CRITICAL(TEMP_SENSOR_2, 85, SHUTDOWN) : }" : : register "controls.power_limits" = "{ : .pl1 = { : .min_power = 3000, : .max_power = 15000, : .time_window_min = 28 * MSECS_PER_SEC, : .time_window_max = 32 * MSECS_PER_SEC, : .granularity = 200, : }, : .pl2 = { : .min_power = 55000, : .max_power = 55000, : .time_window_min = 28 * MSECS_PER_SEC, : .time_window_max = 32 * MSECS_PER_SEC, : .granularity = 1000, : } : }" : : ## Charger Performance Control (Control, mA) : register "controls.charger_perf" = "{ : [0] = { 255, 1700 }, : [1] = { 24, 1500 }, : [2] = { 16, 1000 }, : [3] = { 8, 500 } : }" : : ## Fan Performance Control (Percent, Speed, Noise, Power) : register "controls.fan_perf" = "{ : [0] = { 90, 6700, 220, 2200, }, : [1] = { 80, 5800, 180, 1800, }, : [2] = { 70, 5000, 145, 1450, }, : [3] = { 60, 4900, 115, 1150, }, : [4] = { 50, 3838, 90, 900, }, : [5] = { 40, 2904, 55, 550, }, : [6] = { 30, 2337, 30, 300, }, : [7] = { 20, 1608, 15, 150, }, : [8] = { 10, 800, 10, 100, }, : [9] = { 0, 0, 0, 50, } : }" : : ## Fan options : register "options.fan.fine_grained_control" = "1" : register "options.fan.step_size" = "2" : : device generic 0 on end indent this one more level
-
Tim Wawrzynczak (Code Review)