Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/58008 )
Change subject: src/soc/intel/alderlake: Add PsysPmax setting ......................................................................
src/soc/intel/alderlake: Add PsysPmax setting
This patch feeds PsysPmax setting to FSP through UPD and adds a PsysPmax member in chip information so that we can set PsysPmax through devicetree. The PsysPmax needs to be set correctly mapping to maximum system power. Otherwise, system performance would be limited due to the default PsysPmax setting in FSP is only 21W.
BUG=b:193864533, b:195615830 TEST=Set PsysPmax to an example value eg 145 in devicetree && put debug code in FSP to print the PsysPmax value before sending to Pcode, ensure the setting is correctly programmed.
Change-Id: Ia07aa815f90739240f110cab984068237c02d896 Signed-off-by: Ryan Lin ryan.lin@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/58008 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/soc/intel/alderlake/chip.h M src/soc/intel/alderlake/fsp_params.c 2 files changed, 10 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/soc/intel/alderlake/chip.h b/src/soc/intel/alderlake/chip.h index 3192478..270400b 100644 --- a/src/soc/intel/alderlake/chip.h +++ b/src/soc/intel/alderlake/chip.h @@ -492,6 +492,9 @@ POWER_CYCLE_DURATION_3S, POWER_CYCLE_DURATION_4S, } pch_reset_power_cycle_duration; + + /* Platform Power Pmax */ + uint16_t PsysPmax; };
typedef struct soc_intel_alderlake_config config_t; diff --git a/src/soc/intel/alderlake/fsp_params.c b/src/soc/intel/alderlake/fsp_params.c index 8003471..4ae2537 100644 --- a/src/soc/intel/alderlake/fsp_params.c +++ b/src/soc/intel/alderlake/fsp_params.c @@ -652,6 +652,13 @@ s_cfg->PchPmSlpS3MinAssert, s_cfg->PchPmSlpAMinAssert, power_cycle_duration); + + /* Set PsysPmax if it is available from DT */ + if (config->PsysPmax) { + printk(BIOS_DEBUG, "PsysPmax = %dW\n", config->PsysPmax); + /* PsysPmax is in unit of 1/8 Watt */ + s_cfg->PsysPmax = config->PsysPmax * 8; + } }
static void fill_fsps_irq_params(FSP_S_CONFIG *s_cfg,