Attention is currently required from: Appukuttan V K, Dinesh Gehlot, Felix Held, Julius Werner, Lean Sheng Tan, Patrick Rudolph, Paul Menzel.
Hello Appukuttan V K, Dinesh Gehlot, Felix Held, Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82102?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: cbfstool: Read XIP stage alignment requirements from ELF
......................................................................
cbfstool: Read XIP stage alignment requirements from ELF
On x86_64 romstage can contain page tables and a page table pointer
which have an larger alignment requirement of 4096. Instead of
hardcoding it, read if from the ELF phdrs.
Change-Id: I94e4a4209b7441ecb2966a1342c3d46625771bb8
Signed-off-by: Arthur Heymans arthur@aheymans.xyz
---
M Makefile.mk
M util/cbfstool/cbfstool.c
M util/cbfstool/elfheaders.c
M util/cbfstool/elfparsing.h
4 files changed, 41 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/82102/4
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82102?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I94e4a4209b7441ecb2966a1342c3d46625771bb8
Gerrit-Change-Number: 82102
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jincheng Li
jincheng.li@intel.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Shuo Liu
shuo.liu@intel.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: newpatchset