Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Patrick Rudolph. Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/55052 )
Change subject: acpi: drop unused parameter from acpi_soc_fill_bert ......................................................................
acpi: drop unused parameter from acpi_soc_fill_bert
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ic354824468f016a7857c6990024ae87db6fd00bf --- M src/acpi/acpi.c M src/include/acpi/acpi.h M src/soc/intel/common/block/acpi/acpi_bert.c 3 files changed, 4 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/55052/1
diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index 0874e6e..185825b 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -1565,7 +1565,7 @@ return false; }
-__weak void acpi_soc_fill_bert(acpi_bert_t *bert, void **region, size_t *length) {} +__weak void acpi_soc_fill_bert(void **region, size_t *length) {}
unsigned long __weak fw_cfg_acpi_tables(unsigned long start) { @@ -1815,7 +1815,7 @@ size_t size; printk(BIOS_DEBUG, "ACPI: * BERT\n"); bert = (acpi_bert_t *) current; - acpi_soc_fill_bert(bert, ®ion, &size); + acpi_soc_fill_bert(®ion, &size); acpi_write_bert(bert, (uintptr_t)region, size); if (bert->header.length >= sizeof(acpi_bert_t)) { current += bert->header.length; diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index d5e933b..dd00c40 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -1342,7 +1342,7 @@
/* For crashlog. */ bool acpi_is_boot_error_src_present(void); -void acpi_soc_fill_bert(acpi_bert_t *bert, void **region, size_t *length); +void acpi_soc_fill_bert(void **region, size_t *length);
/* For ACPI S3 support. */ void __noreturn acpi_resume(void *wake_vec); diff --git a/src/soc/intel/common/block/acpi/acpi_bert.c b/src/soc/intel/common/block/acpi/acpi_bert.c index d090dfd..f94026d 100644 --- a/src/soc/intel/common/block/acpi/acpi_bert.c +++ b/src/soc/intel/common/block/acpi/acpi_bert.c @@ -8,9 +8,7 @@ #include <intelblocks/crashlog.h>
-void acpi_soc_fill_bert(acpi_bert_t *bert, - void **region, - size_t *length) +void acpi_soc_fill_bert(void **region, size_t *length) { acpi_generic_error_status_t *status = NULL; size_t cpu_record_size, pmc_record_size;