Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41739 )
Change subject: util/apcb: apcb_edit.py requires python3 ......................................................................
util/apcb: apcb_edit.py requires python3
BUG=b:157140753 TEST=Built trembyle and was able to boot to the OS
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I181d87aad1ffb10e12f8ffd7513318f6d6bcbc3f --- M util/apcb/apcb_edit.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/41739/1
diff --git a/util/apcb/apcb_edit.py b/util/apcb/apcb_edit.py index 4a7e683..e5dd0cd 100755 --- a/util/apcb/apcb_edit.py +++ b/util/apcb/apcb_edit.py @@ -1,4 +1,4 @@ -#! /usr/bin/env python +#!/usr/bin/env python3
# Script for editing APCB binaries, such as injecting SPDs and GPIO # configurations.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41739 )
Change subject: util/apcb: apcb_edit.py requires python3 ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41739 )
Change subject: util/apcb: apcb_edit.py requires python3 ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41739 )
Change subject: util/apcb: apcb_edit.py requires python3 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41739/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41739/1//COMMIT_MSG@7 PS1, Line 7: util/apcb: apcb_edit.py requires python3 Please make the statement about the change and not the problem.
util/apcbapcb_edit.py: Require python3
util/apcb: Require python3 for apcb_edit.py
util/apcb: Let apcb_edit.py require python3
Hello build bot (Jenkins), Furquan Shaikh, Rob Barnes, Aaron Durbin, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41739
to look at the new patch set (#2).
Change subject: util/apcb: Use python3 for apcb_edit.py ......................................................................
util/apcb: Use python3 for apcb_edit.py
The code was written on a workstation that has python pointing to python3.
BUG=b:157140753 TEST=Built trembyle and was able to boot to the OS
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I181d87aad1ffb10e12f8ffd7513318f6d6bcbc3f --- M util/apcb/apcb_edit.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/41739/2
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41739 )
Change subject: util/apcb: Use python3 for apcb_edit.py ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41739/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41739/1//COMMIT_MSG@7 PS1, Line 7: util/apcb: apcb_edit.py requires python3
Please make the statement about the change and not the problem. […]
Done
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41739 )
Change subject: util/apcb: Use python3 for apcb_edit.py ......................................................................
Patch Set 2: Code-Review+1
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41739 )
Change subject: util/apcb: Use python3 for apcb_edit.py ......................................................................
Uploaded patch set 3: Patch Set 2 was rebased.
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41739 )
Change subject: util/apcb: Use python3 for apcb_edit.py ......................................................................
util/apcb: Use python3 for apcb_edit.py
The code was written on a workstation that has python pointing to python3.
BUG=b:157140753 TEST=Built trembyle and was able to boot to the OS
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I181d87aad1ffb10e12f8ffd7513318f6d6bcbc3f Reviewed-on: https://review.coreboot.org/c/coreboot/+/41739 Reviewed-by: Rob Barnes robbarnes@google.com Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/apcb/apcb_edit.py 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Furquan Shaikh: Looks good to me, approved Rob Barnes: Looks good to me, but someone else must approve
diff --git a/util/apcb/apcb_edit.py b/util/apcb/apcb_edit.py index 4a7e683..e5dd0cd 100755 --- a/util/apcb/apcb_edit.py +++ b/util/apcb/apcb_edit.py @@ -1,4 +1,4 @@ -#! /usr/bin/env python +#!/usr/bin/env python3
# Script for editing APCB binaries, such as injecting SPDs and GPIO # configurations.
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41739 )
Change subject: util/apcb: Use python3 for apcb_edit.py ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4222 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4221 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4220 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4219
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Felix Held (Code Review)
-
Furquan Shaikh (Code Review)
-
Paul Menzel (Code Review)
-
Raul Rangel (Code Review)
-
Rob Barnes (Code Review)