[S] Change in coreboot[master]: mb/asrock/b75m-itx: Make NIC a child device below the right PCIe port

[Kevin Keijzer (Code Review)]

Attention is currently required from: Kevin Keijzer.

Hello Kevin Keijzer,

I'd like you to do a code review.
Please visit

https://review.coreboot.org/c/coreboot/+/73516

to review the following change.

Change subject: mb/asrock/b75m-itx: Make NIC a child device below the right PCIe port
......................................................................

mb/asrock/b75m-itx: Make NIC a child device below the right PCIe port

The Realtek RTL8111E NIC is currently not defined as a child device,
resulting in the on_board flag not being set to 1. This means that
Linux / udev will call the device enp3s0 rather than eno0, as is
appropriate for on-board ethernet devices.

Additionally, the comment in devicetree.cb stating that PCIe port 6
is the ethernet controller is incorrect. It's actually port 4.

This patch moves the comment to the right port, and defines the NIC
as a child device of said port, so that it's properly defined as an
on-board device.

Change-Id: Ie1e3a757a6bd6c7dd1702ced177d13711978dcc4
Signed-off-by: Kevin Keijzer 
---
M src/mainboard/asrock/b75m-itx/devicetree.cb
1 file changed, 27 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/73516/1

diff --git a/src/mainboard/asrock/b75m-itx/devicetree.cb b/src/mainboard/asrock/b75m-itx/devicetree.cb
index 9fdad95..5b3387a 100644
--- a/src/mainboard/asrock/b75m-itx/devicetree.cb
+++ b/src/mainboard/asrock/b75m-itx/devicetree.cb
@@ -50,11 +50,13 @@
    		end
    		device pci 1c.1 off end # PCIe Port #2
    		device pci 1c.2 off end # PCIe Port #3
-			device pci 1c.3 on  # PCIe Port #4
-				subsystemid 0x1849 0x1e16
+			device pci 1c.3 on  # PCIe Port #4, Realtek PCIe GbE Controller
+				device pci 00.0 on  # PCI 10ec:8168
+					subsystemid 0x1849 0x1e16
+				end
    		end
    		device pci 1c.4 off end # PCIe Port #5
-			device pci 1c.5 on  # PCIe Port #6, Realtek PCIe GbE Controller
+			device pci 1c.5 on  # PCIe Port #6
    			subsystemid 0x1849 0x1e1a
    		end
    		device pci 1c.6 off end # PCIe Port #7