Change in coreboot[master]: mb/google/zork: Unmap FCH IO-APIC PCI interrupts

[Raul Rangel (Code Review)]

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48669 )

Change subject: mb/google/zork: Unmap FCH IO-APIC PCI interrupts
......................................................................

mb/google/zork: Unmap FCH IO-APIC PCI interrupts

Now that the _PRT generates a GNB IO-APIC routing table we no longer
need to route the PCI interrupts through the FCH IO-APIC. This change
unmaps the IRQs since they are no longer used.

BUG=b:170595019
TEST=Boot with `pci=nomsi amd_iommu=off` and verify /proc/interrupts

Signed-off-by: Raul E Rangel 
Change-Id: I3467934bfcac14311505bec49a12652490554e6a
---
M src/mainboard/google/zork/mainboard.c
1 file changed, 8 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/48669/1

diff --git a/src/mainboard/google/zork/mainboard.c b/src/mainboard/google/zork/mainboard.c
index 94a64bd..3a3b1bd 100644
--- a/src/mainboard/google/zork/mainboard.c
+++ b/src/mainboard/google/zork/mainboard.c
@@ -66,14 +66,14 @@
    uint8_t pic_irq_num;
    uint8_t apic_irq_num;
 } fch_pirq[] = {
-	{ PIRQ_A,	6,		16 },
-	{ PIRQ_B,	13,		17 },
-	{ PIRQ_C,	14,		18 },
-	{ PIRQ_D,	15,		19 },
-	{ PIRQ_E,	15,		20 },
-	{ PIRQ_F,	14,		21 },
-	{ PIRQ_G,	13,		22 },
-	{ PIRQ_H,	6,		23 },
+	{ PIRQ_A,	6,		PIRQ_NC },
+	{ PIRQ_B,	13,		PIRQ_NC },
+	{ PIRQ_C,	14,		PIRQ_NC },
+	{ PIRQ_D,	15,		PIRQ_NC },
+	{ PIRQ_E,	15,		PIRQ_NC },
+	{ PIRQ_F,	14,		PIRQ_NC },
+	{ PIRQ_G,	13,		PIRQ_NC },
+	{ PIRQ_H,	6,		PIRQ_NC },

{ PIRQ_SCI,	9,		9 },
    { PIRQ_EMMC,	5,		5 },

[Nikolai Vyssotski (Code Review)]

Nikolai Vyssotski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48669 )

Change subject: mb/google/zork: Unmap FCH IO-APIC PCI interrupts
......................................................................

Patch Set 1: Code-Review+1

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48669 )

Change subject: mb/google/zork: Unmap FCH IO-APIC PCI interrupts
......................................................................

Patch Set 1:

this one probably also needs a corresponding patch for mandolin

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48669 )

Change subject: mb/google/zork: Unmap FCH IO-APIC PCI interrupts
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48669 )

Change subject: mb/google/zork: Unmap FCH IO-APIC PCI interrupts
......................................................................

mb/google/zork: Unmap FCH IO-APIC PCI interrupts

Now that the _PRT generates a GNB IO-APIC routing table we no longer
need to route the PCI interrupts through the FCH IO-APIC. This change
unmaps the IRQs since they are no longer used.

BUG=b:170595019
TEST=Boot with `pci=nomsi amd_iommu=off` and verify /proc/interrupts

Signed-off-by: Raul E Rangel 
Change-Id: I3467934bfcac14311505bec49a12652490554e6a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48669
Tested-by: build bot (Jenkins) 
Reviewed-by: Nikolai Vyssotski 
Reviewed-by: Felix Held 
---
M src/mainboard/google/zork/mainboard.c
1 file changed, 8 insertions(+), 8 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Felix Held: Looks good to me, approved
  Nikolai Vyssotski: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/zork/mainboard.c b/src/mainboard/google/zork/mainboard.c
index 94a64bd..3a3b1bd 100644
--- a/src/mainboard/google/zork/mainboard.c
+++ b/src/mainboard/google/zork/mainboard.c
@@ -66,14 +66,14 @@
    uint8_t pic_irq_num;
    uint8_t apic_irq_num;
 } fch_pirq[] = {
-	{ PIRQ_A,	6,		16 },
-	{ PIRQ_B,	13,		17 },
-	{ PIRQ_C,	14,		18 },
-	{ PIRQ_D,	15,		19 },
-	{ PIRQ_E,	15,		20 },
-	{ PIRQ_F,	14,		21 },
-	{ PIRQ_G,	13,		22 },
-	{ PIRQ_H,	6,		23 },
+	{ PIRQ_A,	6,		PIRQ_NC },
+	{ PIRQ_B,	13,		PIRQ_NC },
+	{ PIRQ_C,	14,		PIRQ_NC },
+	{ PIRQ_D,	15,		PIRQ_NC },
+	{ PIRQ_E,	15,		PIRQ_NC },
+	{ PIRQ_F,	14,		PIRQ_NC },
+	{ PIRQ_G,	13,		PIRQ_NC },
+	{ PIRQ_H,	6,		PIRQ_NC },

{ PIRQ_SCI,	9,		9 },
    { PIRQ_EMMC,	5,		5 },