Attention is currently required from: Julius Werner, Kapil Porwal.
Subrata Banik has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/87285?usp=email )
Change subject: drivers/option: Create API to check valid option ......................................................................
Patch Set 4:
(2 comments)
File src/drivers/option/cbfs_file_option.c:
https://review.coreboot.org/c/coreboot/+/87285/comment/a91087e1_1cb74ca5?usp... : PS4, Line 7: is_valid_option can you please add a help text to understand the expectation from this weak implementation ?
File src/include/option.h:
https://review.coreboot.org/c/coreboot/+/87285/comment/21d92669_f1ee0ac8?usp... : PS4, Line 10: bool is_valid_option(const char *name); same comment as .C file