[S] Change in coreboot[main]: soc/intel/common/block/acpi/northbridge.asl: Reserve SBREG BAR

[Michał Żygowski (Code Review)]

Attention is currently required from: Arthur Heymans, Christian Walter, CoolStar, Eran Mitrani, Jakub Czapiga, Jeremy Soller, Johnny Lin, Kapil Porwal, Krystian Hebel, Lean Sheng Tan, Martin L Roth, Matt DeVillier, Nick Vaccaro, Paul Menzel, Subrata Banik, Tarun, Tim Chu.

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77445?usp=email )

Change subject: soc/intel/common/block/acpi/northbridge.asl: Reserve SBREG BAR
......................................................................

Patch Set 19:

(6 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/77445/comment/59e3f8c0_75cdf00f :
PS15, Line 7: intelblocks/acpi/notrhbridge.asl
> intelblocks is strange to me, but the author’s, that means your, call.

Okay, so intelblocks are the problem. When I search for intelblocks phrase on gerrit, it is not commonly used indeed. I am fine with changing it to soc/intel/common/block/acpi/northbridge.asl

https://review.coreboot.org/c/coreboot/+/77445/comment/ed58520f_b1bf49d7 :
PS15, Line 11: ,
> Yes, that is my suggestion in the ().

Done

https://review.coreboot.org/c/coreboot/+/77445/comment/b4cf45fc_986a32cd :
PS15, Line 13:
> Understood. […]

Done

Patchset:

PS15:
> Reverted the changes in iomap.h files.

Done

File src/soc/intel/alderlake/include/soc/iomap.h:

https://review.coreboot.org/c/coreboot/+/77445/comment/ac7e53b8_8301fe08 :
PS15, Line 127: (256 * MiB)
> You can check the “Resolved box” in the comment, if you fixed it.

Done

File src/soc/intel/apollolake/include/soc/iomap.h:

https://review.coreboot.org/c/coreboot/+/77445/comment/b51d755b_5c69f20c :
PS15, Line 9: (16 * MiB)
> Fixed, by including the appropriate helpers.h file in ASL.

Done