Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80464?usp=email )
Change subject: soc/amd: move common pci_domain_fill_ssdt implementation to acpi/
......................................................................
Patch Set 4:
(2 comments)
File src/acpi/acpigen_pci_root_resource_producer.c:
https://review.coreboot.org/c/coreboot/+/80464/comment/81a1f1c3_50672b0d :
PS3, Line 14: IO
pad by two spaces to align with MMIO
since the values after that have a substantially different length, i'm not sure if that's worth it
https://review.coreboot.org/c/coreboot/+/80464/comment/17444622_64dfd8c2 :
PS3, Line 57: -%
i'll push a follow-up to address those
CB:80804
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80464?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7bd8568cf0b7051c74adbedfe0e416a0938ccb99
Gerrit-Change-Number: 80464
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Thu, 29 Feb 2024 16:02:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment