Change in coreboot[master]: util/chromeos: Indent code blocks instead of using ```

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Paul Menzel (Code Review)

30 Sep 2019 30 Sep '19

11:59 a.m.

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35729 )

Change subject: util/chromeos: Indent code blocks instead of using ``` ......................................................................

util/chromeos: Indent code blocks instead of using ```

This uses less lines, is the original Markdown syntax, and for short blocks bette readable.

Change-Id: Id96ad0f65980dfb943eef3cde5626d56f97622f9 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M util/chromeos/README.md 1 file changed, 10 insertions(+), 13 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/35729/1

diff --git a/util/chromeos/README.md b/util/chromeos/README.md index 0b9a7d7..964c6c5 100644 --- a/util/chromeos/README.md +++ b/util/chromeos/README.md @@ -11,14 +11,13 @@ extracts the firmware images from the shell archive.

To download all Chrome OS firmware images, run -``` -$ ./crosfirmware.sh -``` + + $ ./crosfirmware.sh +

To download, e.g. the Panther firmware image, run -``` -$ ./crosfirmware.sh panther -``` + + $ ./crosfirmware.sh panther

## extract_blobs.sh

@@ -33,12 +32,10 @@ compatible format.

Usage: -``` -$ ./gen_test_hwid.sh BOARD_NAME -``` + + $ ./gen_test_hwid.sh BOARD_NAME

Example: -``` -$ ./gen_test_hwid.sh Kukui -KUKUI TEST 9847 -``` + + $ ./gen_test_hwid.sh Kukui + KUKUI TEST 9847

Attachments:

attachment.htm (text/html — 3.9 KB)

Show replies by date

Angel Pons (Code Review)

10 Oct 10 Oct

3:14 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35729 )

Change subject: util/chromeos: Indent code blocks instead of using ``` ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35729/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/35729/1//COMMIT_MSG@10 PS1, Line 10: bette Typo! :D

-- To view, visit https://review.coreboot.org/c/coreboot/+/35729 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id96ad0f65980dfb943eef3cde5626d56f97622f9 Gerrit-Change-Number: 35729 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Thu, 10 Oct 2019 15:14:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

11 Oct 11 Oct

11:57 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35729

to look at the new patch set (#2).

Change subject: util/chromeos: Indent code blocks instead of using ``` ......................................................................

util/chromeos: Indent code blocks instead of using ```

This uses less lines, is the original Markdown syntax, and for short blocks better readable.

Change-Id: Id96ad0f65980dfb943eef3cde5626d56f97622f9 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M util/chromeos/README.md 1 file changed, 10 insertions(+), 13 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/35729/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35729 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id96ad0f65980dfb943eef3cde5626d56f97622f9 Gerrit-Change-Number: 35729 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: newpatchset

Paul Menzel (Code Review)

12:11 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35729 )

Change subject: util/chromeos: Indent code blocks instead of using ``` ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35729/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/35729/1//COMMIT_MSG@10 PS1, Line 10: bette

...

Typo! :D

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/35729 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id96ad0f65980dfb943eef3cde5626d56f97622f9 Gerrit-Change-Number: 35729 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Fri, 11 Oct 2019 12:11:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Paul Menzel (Code Review)

18 Nov 18 Nov

11:33 p.m.

Paul Menzel has removed build bot (Jenkins) from this change. ( https://review.coreboot.org/c/coreboot/+/35729 )

Change subject: util/chromeos: Indent code blocks instead of using ``` ......................................................................

Removed reviewer build bot (Jenkins) with the following votes:

* Verified+1 by build bot (Jenkins) no-reply@coreboot.org

-- To view, visit https://review.coreboot.org/c/coreboot/+/35729 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id96ad0f65980dfb943eef3cde5626d56f97622f9 Gerrit-Change-Number: 35729 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: deleteReviewer

Paul Menzel (Code Review)

11:33 p.m.

Paul Menzel has removed Angel Pons from this change. ( https://review.coreboot.org/c/coreboot/+/35729 )

Change subject: util/chromeos: Indent code blocks instead of using ``` ......................................................................

Removed reviewer Angel Pons.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35729 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id96ad0f65980dfb943eef3cde5626d56f97622f9 Gerrit-Change-Number: 35729 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: deleteReviewer

Patrick Georgi (Code Review)

19 Nov 19 Nov

12:54 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35729 )

Change subject: util/chromeos: Indent code blocks instead of using ``` ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35729 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id96ad0f65980dfb943eef3cde5626d56f97622f9 Gerrit-Change-Number: 35729 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 19 Nov 2019 12:54:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

1:28 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35729 )

Change subject: util/chromeos: Indent code blocks instead of using ``` ......................................................................

util/chromeos: Indent code blocks instead of using ```

This uses less lines, is the original Markdown syntax, and for short blocks better readable.

Change-Id: Id96ad0f65980dfb943eef3cde5626d56f97622f9 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/35729 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/chromeos/README.md 1 file changed, 10 insertions(+), 13 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved

To download all Chrome OS firmware images, run -``` -$ ./crosfirmware.sh -``` + + $ ./crosfirmware.sh +

To download, e.g. the Panther firmware image, run -``` -$ ./crosfirmware.sh panther -``` + + $ ./crosfirmware.sh panther

## extract_blobs.sh

@@ -33,12 +32,10 @@ compatible format.

Usage: -``` -$ ./gen_test_hwid.sh BOARD_NAME -``` + + $ ./gen_test_hwid.sh BOARD_NAME

Example: -``` -$ ./gen_test_hwid.sh Kukui -KUKUI TEST 9847 -``` + + $ ./gen_test_hwid.sh Kukui + KUKUI TEST 9847

-- To view, visit https://review.coreboot.org/c/coreboot/+/35729 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id96ad0f65980dfb943eef3cde5626d56f97622f9 Gerrit-Change-Number: 35729 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1772

days inactive

1822

days old

coreboot-gerrit@coreboot.org

7 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)