Attention is currently required from: Paul Menzel, Jon Murphy, Karthik Ramasubramanian.
Chris Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63295 )
Change subject: mb/google/skyrim/var/baseboard: Set Clk request for WLAN/SD/SSD device
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63295/comment/08de9e9e_b41f3b18
PS1, Line 9: Setting the clock source depends on clock request pin for WLAN/SD/SSD device.
: Also turn off the unused (CLKREQ#3) clock sources.
: In skyrim, clock source 0/1/2 are routed for WLAN/SD/SSD device.
Please wrap lines after 72 characters, do *not* break lines after each sentence, and if you use para […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63295
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21fb912b69f59717eb4e84c379f706a0257a9ed1
Gerrit-Change-Number: 63295
Gerrit-PatchSet: 2
Gerrit-Owner: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 05 Apr 2022 03:35:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment