Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31250 )
Change subject: soc/intel/cannonlake: Configure GPIOs again after FSP-S is done
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Padcfg gets locked down by FSP anyways before any payload / OS starts.
I think it is configurable using `PchUnlockGpioPads`
Well, as already mentioned, see CB:45211. All these UPDs will change pad config.
Oh okay. Since there was no follow-up change in that series, it was not clear how the missing special function pads were utilized at mainboard level.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31250
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7787aa8f185f633627bcedc7f23504bf4a5250b4
Gerrit-Change-Number: 31250
Gerrit-PatchSet: 5
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Tue, 02 Feb 2021 19:54:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment