Change in ...coreboot[master]: mb/google/hatch: Remove pulls on NC pads

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33570

Change subject: mb/google/hatch: Remove pulls on NC pads
......................................................................

mb/google/hatch: Remove pulls on NC pads

There is no need to add internal termination (PU/PD) on the
not-connected pads. This change gets rid of the terminations on the NC
pads.

Change-Id: I3df538d7127e5ef75e6e6ff9db3524e26f0450ed
Signed-off-by: Furquan Shaikh 
---
M src/mainboard/google/hatch/variants/baseboard/gpio.c
1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/33570/1

diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c
index 0b66075..c2c2cc9 100644
--- a/src/mainboard/google/hatch/variants/baseboard/gpio.c
+++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c
@@ -138,9 +138,9 @@
    /* C9  : UART_PCH_TX_DEBUG_RX */
    PAD_CFG_NF(GPP_C9, NONE, DEEP, NF1),
    /* C10 : GPP_10 ==> GPP_C10_TP */
-	PAD_NC(GPP_C10, DN_20K),
+	PAD_NC(GPP_C10, NONE),
    /* C11 : GPP_11 ==> GPP_C11_TP */
-	PAD_NC(GPP_C11, DN_20K),
+	PAD_NC(GPP_C11, NONE),
    /* C12 : GPP_C12 ==> NC */
    PAD_NC(GPP_C12, NONE),
    /* C13 : EC_PCH_INT_L
@@ -343,7 +343,7 @@
    /* G6  : SD_CLK */
    PAD_CFG_NF(GPP_G6, NONE, DEEP, NF1),
    /* G7  : SD_WP => NC */
-	PAD_NC(GPP_G7, DN_20K),
+	PAD_NC(GPP_G7, NONE),
    /*
     * H0  : HP_INT_L
     */

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33570 )

Change subject: mb/google/hatch: Remove pulls on NC pads
......................................................................

Patch Set 1: Code-Review+1

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33570 )

Change subject: mb/google/hatch: Remove pulls on NC pads
......................................................................

Patch Set 1: Code-Review+2

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33570 )

Change subject: mb/google/hatch: Remove pulls on NC pads
......................................................................

Patch Set 1: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33570 )

Change subject: mb/google/hatch: Remove pulls on NC pads
......................................................................

mb/google/hatch: Remove pulls on NC pads

There is no need to add internal termination (PU/PD) on the
not-connected pads. This change gets rid of the terminations on the NC
pads.

Change-Id: I3df538d7127e5ef75e6e6ff9db3524e26f0450ed
Signed-off-by: Furquan Shaikh 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33570
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Fagerburg 
Reviewed-by: Aamir Bohra 
Reviewed-by: Tim Wawrzynczak 
---
M src/mainboard/google/hatch/variants/baseboard/gpio.c
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Aamir Bohra: Looks good to me, approved
  Tim Wawrzynczak: Looks good to me, approved
  Paul Fagerburg: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c
index e309175..5d0b861 100644
--- a/src/mainboard/google/hatch/variants/baseboard/gpio.c
+++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c
@@ -138,9 +138,9 @@
    /* C9  : UART_PCH_TX_DEBUG_RX */
    PAD_CFG_NF(GPP_C9, NONE, DEEP, NF1),
    /* C10 : GPP_10 ==> GPP_C10_TP */
-	PAD_NC(GPP_C10, DN_20K),
+	PAD_NC(GPP_C10, NONE),
    /* C11 : GPP_11 ==> GPP_C11_TP */
-	PAD_NC(GPP_C11, DN_20K),
+	PAD_NC(GPP_C11, NONE),
    /* C12 : GPP_C12 ==> NC */
    PAD_NC(GPP_C12, NONE),
    /* C13 : EC_PCH_INT_L
@@ -343,7 +343,7 @@
    /* G6  : SD_CLK */
    PAD_CFG_NF(GPP_G6, NONE, DEEP, NF1),
    /* G7  : SD_WP => NC */
-	PAD_NC(GPP_G7, DN_20K),
+	PAD_NC(GPP_G7, NONE),
    /*
     * H0  : HP_INT_L
     */