Change in coreboot[master]: cpu/x86/64bit: Generate static page tables from an assembly file

[Arthur Heymans (Code Review)]

Attention is currently required from: Raul Rangel, Patrick Rudolph, Julius Werner.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63725 )

Change subject: cpu/x86/64bit: Generate static page tables from an assembly file
......................................................................

Patch Set 3:

(3 comments)

File src/cpu/x86/64bit/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/63725/comment/440cd39d_a3c9e390 
PS3, Line 4: -ffreestanding -nostdlib -nostdinc
> Any reason you can't just reuse `$(CPPFLAGS_ramstage) $(CFLAGS_ramstage)` here? (Also, shouldn't it  […]

Done

File src/cpu/x86/64bit/pt.S:

https://review.coreboot.org/c/coreboot/+/63725/comment/eea374fa_6869562a 
PS3, Line 27: .quad _GEN_PAGE(0x200000 * 0)
> Maybe something like this could work:
>
> .rept 2048
>  .quad _GEN_PAGE(0x200000 * (. - PDE_tables) / 8)
>  .endr

Division won't compile but shifting right does. Thanks.

File src/cpu/x86/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/63725/comment/059f1ef1_b04d1b70 
PS3, Line 7: CONFIG_ARCH_BOOTBLOCK_X86_64
> I guess I'm concerned about the PSP Verstage case.
>
> Not sure if the
> all-y += mode_switch.S
>
> will work for us. Maybe that's the part that needs the individual rules?

This is confusing me. It should be invalid code for the PSP? Why does the build not fail?