Change in coreboot[master]: soc/intel/denverton_ns: Refactor `detect_num_cpus_via_mch()` - coreboot-gerrit

4 Nov 2021


      Attention is currently required from: Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Patrick Rudolph, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58912 )
Change subject: soc/intel/denverton_ns: Refactor `detect_num_cpus_via_mch()`
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
...
Well, if it does, then CONFIG_MAX_CPUS is wrong. There's a check in `src/cpu/x86/mp_init. […]
That being said, I agree that this change in behavior should be accounted for in the commit message. `Refactor` sounds like behavior doesn't change, but this is not the case. Any alternatives? `Simplify` maybe?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58912
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iae6b16991fcf07c9ad67d2b737e490212b8deedd
Gerrit-Change-Number: 58912
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Mariusz Szafrański mariuszx.szafranski@intel.com
Gerrit-Reviewer: Michal Motyl michalx.motyl@intel.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Suresh Bellampalli suresh.bellampalli@intel.com
Gerrit-Reviewer: Vanessa Eusebio vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Mariusz Szafrański mariuszx.szafranski@intel.com
Gerrit-Attention: Suresh Bellampalli suresh.bellampalli@intel.com
Gerrit-Attention: Vanessa Eusebio vanessa.f.eusebio@intel.com
Gerrit-Attention: Michal Motyl michalx.motyl@intel.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 04 Nov 2021 10:59:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment