Change in ...coreboot[master]: mb/google/sarien: ALC3204 HDA verb table pin config change
Joyce Toh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31624
Change subject: mb/google/sarien: ALC3204 HDA verb table pin config change ......................................................................
mb/google/sarien: ALC3204 HDA verb table pin config change
On Sarien, change pin config of 0x19 (headset mic) and 0x21(headset headphone) to change jack location so that naming does not use "Front" in the name."Front Headphone" --> "Headphone" so it matches naming on Arcada.
BUG=b:126334749 TEST= build coreboot with change and verify with 'evtest' command that jack name is "HDA Intel PCH Headphone" not "HDA Intel PCH Front Headphone".
Change-Id: I36ccf0c0a3952ab363fe6ee313fac8f0cce4dd61 Signed-off-by: Joyce Toh joyce.toh@intel.com --- M src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/31624/1
diff --git a/src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h b/src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h index 52ebb48..6eb6d14 100644 --- a/src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h +++ b/src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h @@ -34,12 +34,12 @@ AZALIA_PIN_CFG(0x0, 0x13, 0x40000000), AZALIA_PIN_CFG(0x0, 0x14, 0x90170110), AZALIA_PIN_CFG(0x0, 0x18, 0x411111f0), - AZALIA_PIN_CFG(0x0, 0x19, 0x02a11030), + AZALIA_PIN_CFG(0x0, 0x19, 0x04a11030), AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0), AZALIA_PIN_CFG(0x0, 0x1b, 0x411111f0), AZALIA_PIN_CFG(0x0, 0x1d, 0x40700001), AZALIA_PIN_CFG(0x0, 0x1e, 0x421212f2), - AZALIA_PIN_CFG(0x0, 0x21, 0x02211020), + AZALIA_PIN_CFG(0x0, 0x21, 0x04211020),
/* ALC3204 default-1 */ 0x02050040,
Hello Jairaj Arava, Aaron Durbin, Duncan Laurie, Sathyanarayana Nujella, build bot (Jenkins), HARSHAPRIYA N, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31624
to look at the new patch set (#2).
Change subject: mb/google/sarien: ALC3204 HDA verb table pin config change ......................................................................
mb/google/sarien: ALC3204 HDA verb table pin config change
On Sarien, change pin config of 0x19 (headset mic) and 0x21(headset headphone) to change jack location so that naming does not use "Front" in the name."Front Headphone" --> "Headphone" so it matches naming on Arcada.
BUG=b:126334749 TEST= build coreboot with change and verify with 'evtest' command that jack name is "HDA Intel PCH Headphone" not "HDA Intel PCH Front Headphone". TEST= headphone and mic jack detection is also working
Change-Id: I36ccf0c0a3952ab363fe6ee313fac8f0cce4dd61 Signed-off-by: Joyce Toh joyce.toh@intel.com --- M src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/31624/2
Sathyanarayana Nujella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31624 )
Change subject: mb/google/sarien: ALC3204 HDA verb table pin config change ......................................................................
Patch Set 2: Code-Review+1
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31624 )
Change subject: mb/google/sarien: ALC3204 HDA verb table pin config change ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/31624/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31624/2//COMMIT_MSG@15 PS2, Line 15: jack over 80
https://review.coreboot.org/#/c/31624/2//COMMIT_MSG@17 PS2, Line 17: TEST= headphone and mic jack detection is also working Just one TEST= is enough
Hello Jairaj Arava, Aaron Durbin, Duncan Laurie, Sathyanarayana Nujella, build bot (Jenkins), HARSHAPRIYA N, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31624
to look at the new patch set (#3).
Change subject: mb/google/sarien: ALC3204 HDA verb table pin config change ......................................................................
mb/google/sarien: ALC3204 HDA verb table pin config change
On Sarien, change pin config of 0x19 (headset mic) and 0x21(headset headphone) to change jack location so that naming does not use "Front" in the name."Front Headphone" --> "Headphone" so it matches naming on Arcada.
BUG=b:126334749 TEST= verify with 'evtest' command that jack name is "HDA Intel PCH Headphone" not "HDA Intel PCH Front Headphone"
Change-Id: I36ccf0c0a3952ab363fe6ee313fac8f0cce4dd61 Signed-off-by: Joyce Toh joyce.toh@intel.com --- M src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/31624/3
Joyce Toh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31624 )
Change subject: mb/google/sarien: ALC3204 HDA verb table pin config change ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/31624/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31624/2//COMMIT_MSG@15 PS2, Line 15: jack
over 80
Done
https://review.coreboot.org/#/c/31624/2//COMMIT_MSG@17 PS2, Line 17: TEST= headphone and mic jack detection is also working
Just one TEST= is enough
Done
Joyce Toh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31624 )
Change subject: mb/google/sarien: ALC3204 HDA verb table pin config change ......................................................................
Patch Set 3:
Please review and let us know if there are other comments. Thank you!
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31624 )
Change subject: mb/google/sarien: ALC3204 HDA verb table pin config change ......................................................................
Patch Set 3: Code-Review+2
Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31624 )
Change subject: mb/google/sarien: ALC3204 HDA verb table pin config change ......................................................................
mb/google/sarien: ALC3204 HDA verb table pin config change
On Sarien, change pin config of 0x19 (headset mic) and 0x21(headset headphone) to change jack location so that naming does not use "Front" in the name."Front Headphone" --> "Headphone" so it matches naming on Arcada.
BUG=b:126334749 TEST= verify with 'evtest' command that jack name is "HDA Intel PCH Headphone" not "HDA Intel PCH Front Headphone"
Change-Id: I36ccf0c0a3952ab363fe6ee313fac8f0cce4dd61 Signed-off-by: Joyce Toh joyce.toh@intel.com Reviewed-on: https://review.coreboot.org/c/31624 Reviewed-by: Lijian Zhao lijian.zhao@intel.com Reviewed-by: Sathyanarayana Nujella sathyanarayana.nujella@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Lijian Zhao: Looks good to me, approved Sathyanarayana Nujella: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h b/src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h index 52ebb48..6eb6d14 100644 --- a/src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h +++ b/src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h @@ -34,12 +34,12 @@ AZALIA_PIN_CFG(0x0, 0x13, 0x40000000), AZALIA_PIN_CFG(0x0, 0x14, 0x90170110), AZALIA_PIN_CFG(0x0, 0x18, 0x411111f0), - AZALIA_PIN_CFG(0x0, 0x19, 0x02a11030), + AZALIA_PIN_CFG(0x0, 0x19, 0x04a11030), AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0), AZALIA_PIN_CFG(0x0, 0x1b, 0x411111f0), AZALIA_PIN_CFG(0x0, 0x1d, 0x40700001), AZALIA_PIN_CFG(0x0, 0x1e, 0x421212f2), - AZALIA_PIN_CFG(0x0, 0x21, 0x02211020), + AZALIA_PIN_CFG(0x0, 0x21, 0x04211020),
/* ALC3204 default-1 */ 0x02050040,
-
Duncan Laurie (Code Review) -
Joyce Toh (Code Review)
-
Lijian Zhao (Code Review)
-
Sathyanarayana Nujella (Code Review)