Hello build bot (Jenkins), Patrick Georgi, Tim Chen, Paul Menzel, Aaron Durbin,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/43082
to review the following change.
Change subject: Revert "mainboard/google/coral: Add USB2 phy setting override for Astronaut" ......................................................................
Revert "mainboard/google/coral: Add USB2 phy setting override for Astronaut"
This reverts commit 2f1b7aaa3ef69ff6c79bedc9025dcb437535cd16.
Reason for revert: replace it with another cl
Change-Id: I3a30971e3f456ca8d5c274ab9c326b7781c06125 --- M src/mainboard/google/reef/variants/coral/mainboard.c 1 file changed, 0 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/43082/1
diff --git a/src/mainboard/google/reef/variants/coral/mainboard.c b/src/mainboard/google/reef/variants/coral/mainboard.c index 853276e..805c153 100644 --- a/src/mainboard/google/reef/variants/coral/mainboard.c +++ b/src/mainboard/google/reef/variants/coral/mainboard.c @@ -21,12 +21,8 @@ #include <soc/intel/common/vbt.h>
enum { - SKU_0_ASTRONAUT = 0, - SKU_1_ASTRONAUT = 1, SKU_2_SANTA = 2, SKU_3_SANTA = 3, - SKU_61_ASTRONAUT = 61, - SKU_62_ASTRONAUT = 62, SKU_160_NASHER = 160, SKU_161_NASHER = 161, SKU_162_NASHER = 162, @@ -64,21 +60,11 @@ sku_id = variant_board_sku();
switch (sku_id) { - case SKU_0_ASTRONAUT: - case SKU_1_ASTRONAUT: - cfg->usb2eye[1].Usb20PerPortPeTxiSet = 7; - cfg->usb2eye[1].Usb20PerPortTxiSet = 2; - break; case SKU_2_SANTA: case SKU_3_SANTA: cfg->usb2eye[1].Usb20PerPortPeTxiSet = 7; cfg->usb2eye[1].Usb20PerPortTxiSet = 2; break; - case SKU_61_ASTRONAUT: - case SKU_62_ASTRONAUT: - cfg->usb2eye[1].Usb20PerPortPeTxiSet = 7; - cfg->usb2eye[1].Usb20PerPortTxiSet = 5; - break; default: break; }
Ren Kuo has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43082 )
Change subject: Revert "mainboard/google/coral: Add USB2 phy setting override for Astronaut" ......................................................................
Abandoned
Ren Kuo has restored this change. ( https://review.coreboot.org/c/coreboot/+/43082 )
Change subject: Revert "mainboard/google/coral: Add USB2 phy setting override for Astronaut" ......................................................................
Restored
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43082 )
Change subject: Revert "mainboard/google/coral: Add USB2 phy setting override for Astronaut" ......................................................................
Patch Set 1: Code-Review-1
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43082 )
Change subject: Revert "mainboard/google/coral: Add USB2 phy setting override for Astronaut" ......................................................................
Patch Set 1:
sorry for the mistake to revert the cl !!! Please ignore it !!