Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45535 )
Change subject: soc/intel/common/block: add code for ACPI CPPC entries generation ......................................................................
Patch Set 37:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45535/37/src/soc/intel/common/block... File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/45535/37/src/soc/intel/common/block... PS37, Line 442: if (CONFIG(SOC_INTEL_COMMON_BLOCK_ACPI_CPPC) && isst_supported)
Nit, it would probably look better to move the checks inside […]
Well, I did it this way because of https://review.coreboot.org/c/coreboot/+/45535/30/src/soc/intel/common/block...