Attention is currently required from: Furquan Shaikh, Aseda Aboagye, Karthik Ramasubramanian.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52147 )
Change subject: soc/intel/jasperlake: Move HECI_DISABLE_USING_SMM to mainboards
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/52147/comment/69cbae83_763c9a91
PS1, Line 38: HECI_DISABLE_USING_SMM
I am fine with leaving HECI interface enabled. That will be one less diff between Cr50 and TPM2.0. […]
Why would we need to keep this in Kconfig based on your suggestion?
-------if (!config->HeciEnabled && CONFIG(HECI_DISABLE_USING_SMM))
------->-------heci_disable();
Wouldn't removing the Kcofnig make it entirely driven by devicetree?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52147
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iced84faaab8a0cca8400ccd3ec6e4cd525c30e92
Gerrit-Change-Number: 52147
Gerrit-PatchSet: 1
Gerrit-Owner: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Aseda Aboagye
aaboagye@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 07 Apr 2021 18:07:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment