[S] Change in coreboot[master]: soc/intel/cmn/pcie: Allow SoC to overwrite snoop/no-snoop latency
Attention is currently required from: Hannah Williams, Jérémy Compostella, Paul Menzel.
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74141 )
Change subject: soc/intel/cmn/pcie: Allow SoC to overwrite snoop/no-snoop latency ......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74141/comment/d4232a49_3f28bc13 PS4, Line 7: Add ability for
Allow
Done
https://review.coreboot.org/c/coreboot/+/74141/comment/3794c950_797c1666 PS4, Line 9: require
requires
Done
https://review.coreboot.org/c/coreboot/+/74141/comment/fa9062c9_0697a068 PS4, Line 10: tolerance, let it overwrite the common code settings.
… in devicetree? Kconfig?
by implementing weak the function
File src/soc/intel/common/block/pcie/pcie.c:
https://review.coreboot.org/c/coreboot/+/74141/comment/ba4e7057_97e3ae91 PS4, Line 14: __weak
I think, coreboot tries to avoid weak functions.
What is coreboot recommendation or guideline in this case?
Can you please point me to the doc which mentions this?
-
Bora Guvendik (Code Review)