Change in coreboot[master]: mb/google/poppy/variant/nocturne: update PL2 based on CPU sku - coreboot-gerrit

10 Aug 2018


      Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/27997 )
Change subject: mb/google/poppy/variant/nocturne: update PL2 based on CPU sku
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/27997/1/src/mainboard/google/poppy/variants/...
File src/mainboard/google/poppy/variants/nocturne/mainboard.c:
https://review.coreboot.org/#/c/27997/1/src/mainboard/google/poppy/variants/...
PS1, Line 23: * PL2 limit in watts for AML and KBL */
            : #define PL2_AML	18
...
Better to add comment about 18 Watt and 15 Watt, or just change get_pl2 to get_pl2_in_watts for easi […]
Done
-- 
To view, visit https://review.coreboot.org/27997
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfdc0c2434fdef56a7c25df05e640837a5096973
Gerrit-Change-Number: 27997
Gerrit-PatchSet: 3
Gerrit-Owner: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali caveh@google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Gaggery Tsai gaggery.tsai@intel.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Lijian Zhao lijian.zhao@intel.com
Gerrit-Comment-Date: Fri, 10 Aug 2018 02:08:17 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No