Change in coreboot[master]: i2c: Configurable I2C transfer timeout - coreboot-gerrit

2 Mar 2022


      Attention is currently required from: Jes Klinke, Patrick Rudolph.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62278 )
Change subject: i2c: Configurable I2C transfer timeout
......................................................................
Patch Set 7:
(1 comment)
File src/soc/mediatek/common/i2c.c:
https://review.coreboot.org/c/coreboot/+/62278/comment/d1f1adb5_b91e21b6 
PS7, Line 242: CONFIG_I2C_TRANSFER_TIMEOUT_US
...
nit: so we are changing the timeout from 100ms to 500m? can you also update the config value in each […]
Just saw Julius' comment about (transfer timeout) "but that's the one really generic kind of timeout we have in I2C". I'm not an I2C expert but if 500ms is a generic value then I'm ok with this change. Please state that in the commit description so we know the changes to timeout values are expected.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62278
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6423122f32aad1dbcee0bfe240cdaa8cb512791f
Gerrit-Change-Number: 62278
Gerrit-PatchSet: 7
Gerrit-Owner: Jes Klinke jbk@chromium.org
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Qii Wang qii.wang@mediatek.corp-partner.google.com
Gerrit-CC: Rex-BC Chen rex-bc.chen@mediatek.com
Gerrit-Attention: Jes Klinke jbk@chromium.org
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Wed, 02 Mar 2022 14:03:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org
Gerrit-MessageType: comment