Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34580 )
Change subject: mb/google/hatch: Add option to enable WiFi SAR configs ......................................................................
mb/google/hatch: Add option to enable WiFi SAR configs
This change adds a user selectable option to enable all WiFi SAR configs that apply to hatch.
BUG=b:138177048
Change-Id: I4b72f90896841e7c556d4a1b8cdad8ca89d01021 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/Kconfig 1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/34580/1
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 30e0e3d..5991b93 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -36,6 +36,15 @@ select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN select VBOOT_LID_SWITCH
+config CHROMEOS_WIFI_SAR + bool "Enable SAR options for Chrome OS build" + depends on CHROMEOS + select DSAR_ENABLE + select GEO_SAR_ENABLE + select SAR_ENABLE + select USE_SAR + select WIFI_SAR_CBFS + config DEVICETREE string default "variants/baseboard/devicetree.cb"
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34580 )
Change subject: mb/google/hatch: Add option to enable WiFi SAR configs ......................................................................
Patch Set 1: Code-Review+2
LGTM, but I think w/o the data in CBFS an error message will just get printed?
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34580 )
Change subject: mb/google/hatch: Add option to enable WiFi SAR configs ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34580 )
Change subject: mb/google/hatch: Add option to enable WiFi SAR configs ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+2
LGTM, but I think w/o the data in CBFS an error message will just get printed?
That's right.
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34580 )
Change subject: mb/google/hatch: Add option to enable WiFi SAR configs ......................................................................
mb/google/hatch: Add option to enable WiFi SAR configs
This change adds a user selectable option to enable all WiFi SAR configs that apply to hatch.
BUG=b:138177048
Change-Id: I4b72f90896841e7c556d4a1b8cdad8ca89d01021 Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34580 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Paul Fagerburg pfagerburg@chromium.org --- M src/mainboard/google/hatch/Kconfig 1 file changed, 9 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved Paul Fagerburg: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 30e0e3d..5991b93 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -36,6 +36,15 @@ select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN select VBOOT_LID_SWITCH
+config CHROMEOS_WIFI_SAR + bool "Enable SAR options for Chrome OS build" + depends on CHROMEOS + select DSAR_ENABLE + select GEO_SAR_ENABLE + select SAR_ENABLE + select USE_SAR + select WIFI_SAR_CBFS + config DEVICETREE string default "variants/baseboard/devicetree.cb"