Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: [WIP] mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
[WIP] mb/**/hda_verb.{c,h}: Clean up remaining files
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@ @ @ @ DO NOT MERGE AS-IS! @ @ @ @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
This is unreviewably large. Also, there are functional changes on a few files, which would need to be factored out.
Change-Id: I9a3bffcb0fa0de35480a767a1e3aa323e0591198 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/amd/padmelon/hda_verb.c M src/mainboard/apple/macbook21/hda_verb.c M src/mainboard/asrock/g41c-gs/hda_verb.c M src/mainboard/asus/p5gc-mx/hda_verb.c M src/mainboard/asus/p5qc/hda_verb.c M src/mainboard/asus/p5ql-em/hda_verb.c M src/mainboard/asus/p5qpl-am/hda_verb.c M src/mainboard/facebook/fbg1701/hda_verb.c M src/mainboard/foxconn/d41s/hda_verb.c M src/mainboard/foxconn/g41s-k/hda_verb.c M src/mainboard/getac/p470/hda_verb.c M src/mainboard/gigabyte/ga-945gcm-s2l/hda_verb.c M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75-d3v/include/variant/hda_verb.h M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3v/include/variant/hda_verb.h M src/mainboard/gigabyte/ga-g41m-es2l/hda_verb.c M src/mainboard/google/auron/variants/auron_paine/include/variant/hda_verb.h M src/mainboard/google/auron/variants/auron_yuna/include/variant/hda_verb.h M src/mainboard/google/auron/variants/buddy/include/variant/hda_verb.h M src/mainboard/google/auron/variants/gandof/include/variant/hda_verb.h M src/mainboard/google/auron/variants/lulu/include/variant/hda_verb.h M src/mainboard/google/beltino/variants/mccloud/hda_verb.c M src/mainboard/google/beltino/variants/monroe/hda_verb.c M src/mainboard/google/beltino/variants/panther/hda_verb.c M src/mainboard/google/beltino/variants/tricky/hda_verb.c M src/mainboard/google/beltino/variants/zako/hda_verb.c M src/mainboard/google/butterfly/hda_verb.c M src/mainboard/google/drallion/variants/drallion/include/variant/hda_verb.h M src/mainboard/google/jecht/hda_verb.c M src/mainboard/google/link/hda_verb.c M src/mainboard/google/parrot/hda_verb.c M src/mainboard/google/sarien/variants/arcada/include/variant/hda_verb.h M src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h M src/mainboard/google/slippy/variants/falco/hda_verb.c M src/mainboard/google/slippy/variants/leon/hda_verb.c M src/mainboard/google/slippy/variants/peppy/hda_verb.c M src/mainboard/google/slippy/variants/wolf/hda_verb.c M src/mainboard/google/stout/hda_verb.c M src/mainboard/hp/8470p/hda_verb.c M src/mainboard/intel/baskingridge/hda_verb.c M src/mainboard/intel/coffeelake_rvp/variants/cfl_h/include/variant/hda_verb.h M src/mainboard/intel/coffeelake_rvp/variants/cfl_s/include/variant/hda_verb.h M src/mainboard/intel/coffeelake_rvp/variants/cml_u/include/variant/hda_verb.h M src/mainboard/intel/coffeelake_rvp/variants/whl_u/include/variant/hda_verb.h M src/mainboard/intel/d510mo/hda_verb.c M src/mainboard/intel/dg41wv/hda_verb.c M src/mainboard/intel/dg43gt/hda_verb.c M src/mainboard/intel/emeraldlake2/hda_verb.c M src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/hda_verb.h M src/mainboard/intel/kblrvp/variants/rvp11/include/variant/hda_verb.h M src/mainboard/intel/kblrvp/variants/rvp3/include/variant/hda_verb.h M src/mainboard/intel/kblrvp/variants/rvp7/include/variant/hda_verb.h M src/mainboard/intel/wtm2/hda_verb.c M src/mainboard/kontron/ktqm77/hda_verb.c M src/mainboard/lenovo/t400/hda_verb.c M src/mainboard/lenovo/t420/hda_verb.c M src/mainboard/lenovo/t420s/hda_verb.c M src/mainboard/lenovo/t520/hda_verb.c M src/mainboard/lenovo/thinkcentre_a58/hda_verb.c M src/mainboard/lenovo/x131e/hda_verb.c M src/mainboard/lenovo/x200/hda_verb.c M src/mainboard/lenovo/x60/hda_verb.c M src/mainboard/purism/librem_bdw/hda_verb.c M src/mainboard/purism/librem_skl/hda_verb.c M src/mainboard/razer/blade_stealth_kbl/hda_verb.c M src/mainboard/roda/rk9/hda_verb.c M src/mainboard/roda/rv11/variants/rv11/include/variant/hda_verb.h M src/mainboard/roda/rv11/variants/rw11/include/variant/hda_verb.h M src/mainboard/samsung/lumpy/hda_verb.c M src/mainboard/samsung/stumpy/hda_verb.c 69 files changed, 2,300 insertions(+), 2,270 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/37840/1
diff --git a/src/mainboard/amd/padmelon/hda_verb.c b/src/mainboard/amd/padmelon/hda_verb.c index 23d566d..4db64c5 100644 --- a/src/mainboard/amd/padmelon/hda_verb.c +++ b/src/mainboard/amd/padmelon/hda_verb.c @@ -17,14 +17,11 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - /* Realtek ALC662 rev1 */ - 0x10ec0662, /* Vendor ID */ - 0x80865756, /* Subsystem ID */ - 10, /* Number of entries */ + 0x10ec0662, /* Vendor ID: Realtek ALC662 rev1 */ + 0x80865756, /* Subsystem ID */ + 10, /* Number of entries */
/* Pin Widget Verb Table */ - AZALIA_PIN_CFG(0, 0x14, 0x01014010), AZALIA_PIN_CFG(0, 0x15, 0x411111f0), AZALIA_PIN_CFG(0, 0x16, 0x411111f0), diff --git a/src/mainboard/apple/macbook21/hda_verb.c b/src/mainboard/apple/macbook21/hda_verb.c index 0d4149c..5d78ff1 100644 --- a/src/mainboard/apple/macbook21/hda_verb.c +++ b/src/mainboard/apple/macbook21/hda_verb.c @@ -16,9 +16,9 @@
#include <device/azalia_device.h>
+#if CONFIG(BOARD_APPLE_MACBOOK11) || CONFIG(BOARD_APPLE_MACBOOK21) const u32 cim_verb_data[] = { 0x83847680, /* Codec Vendor / Device ID: SigmaTel STAC9221 A1 */ -#if CONFIG(BOARD_APPLE_MACBOOK11) || CONFIG(BOARD_APPLE_MACBOOK21) 0x106b2200, /* Subsystem ID */ 11, /* Number of 4 dword sets */ AZALIA_SUBVENDOR(0x0, 0x106b2200), @@ -32,7 +32,11 @@ AZALIA_PIN_CFG(0x0, 0x11, 0x13c5e240), AZALIA_PIN_CFG(0x0, 0x15, 0x400000fc), AZALIA_PIN_CFG(0x0, 0x1b, 0x400000fb), +}; + #else /* CONFIG_BOARD_APPLE_IMAC52 */ +const u32 cim_verb_data[] = { + 0x83847680, /* Codec Vendor / Device ID: SigmaTel STAC9221 A1 */ 0x106b0f00, /* Subsystem ID */ 11, /* Number of 4 dword sets */ AZALIA_SUBVENDOR(0x0, 0x106b0f00), @@ -46,9 +50,8 @@ AZALIA_PIN_CFG(0x0, 0x11, 0x11cbc022), AZALIA_PIN_CFG(0x0, 0x15, 0x4080e10f), AZALIA_PIN_CFG(0x0, 0x1b, 0x4080e10f), -#endif - }; +#endif
const u32 pc_beep_verbs[0] = {};
diff --git a/src/mainboard/asrock/g41c-gs/hda_verb.c b/src/mainboard/asrock/g41c-gs/hda_verb.c index 1c0474b..5e71013 100644 --- a/src/mainboard/asrock/g41c-gs/hda_verb.c +++ b/src/mainboard/asrock/g41c-gs/hda_verb.c @@ -17,14 +17,10 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - /* Realtek ALC662 rev1 */ - 0x10ec0662, /* Vendor ID */ - 0x18493662, /* Subsystem ID */ - 10, /* Number of entries */ - - /* Pin Widget Verb Table */ - + /* --- Codec #0 --- */ + 0x10ec0662, /* Vendor ID: Realtek ALC662 rev1 */ + 0x18493662, /* Subsystem ID */ + 10, /* Number of entries */ AZALIA_PIN_CFG(0, 0x14, 0x01014010), AZALIA_PIN_CFG(0, 0x15, 0x411111f0), AZALIA_PIN_CFG(0, 0x16, 0x411111f0), @@ -36,24 +32,16 @@ AZALIA_PIN_CFG(0, 0x1d, 0x4004c601), AZALIA_PIN_CFG(0, 0x1e, 0x411111f0),
- /* coreboot specific header */ - /* Intel Eaglelake HDMI */ - 0x80862803, /* Vendor ID */ - 0x80860101, /* Subsystem ID */ - 0x00000001, /* Number of entries */ - - /* Pin Widget Verb Table */ - + /* --- Codec #1 --- */ + 0x80862803, /* Vendor ID: Intel Eaglelake HDMI */ + 0x80860101, /* Subsystem ID */ + 1, /* Number of entries */ AZALIA_PIN_CFG(1, 0x03, 0x18560010),
- - /* coreboot specific header */ - /* Realtek ALC662 rev1 */ - 0x10ec0662, /* Vendor ID */ - 0x1565821e, /* Subsystem ID */ - 10, /* Number of entries */ - - /* Pin Widget Verb Table */ + /* --- Codec #2 --- */ + 0x10ec0662, /* Vendor ID: Realtek ALC662 rev1 */ + 0x1565821e, /* Subsystem ID */ + 10, /* Number of entries */ AZALIA_PIN_CFG(2, 0x14, 0x01014410), AZALIA_PIN_CFG(2, 0x15, 0x411111f0), AZALIA_PIN_CFG(2, 0x16, 0x411111f0), diff --git a/src/mainboard/asus/p5gc-mx/hda_verb.c b/src/mainboard/asus/p5gc-mx/hda_verb.c index a9c25f3..a7a387c 100644 --- a/src/mainboard/asus/p5gc-mx/hda_verb.c +++ b/src/mainboard/asus/p5gc-mx/hda_verb.c @@ -16,10 +16,9 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0883, /* Vendor ID */ - 0x104382c7, /* Subsystem ID */ - 0x0000000c, /* Number of entries */ + 0x10ec0883, /* Vendor ID */ + 0x104382c7, /* Subsystem ID */ + 12, /* Number of entries */
/* Pin Widget Verb Table */ AZALIA_PIN_CFG(0, 0x14, 0x01014010), @@ -37,4 +36,5 @@ };
const u32 pc_beep_verbs[0] = {}; + AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/asus/p5qc/hda_verb.c b/src/mainboard/asus/p5qc/hda_verb.c index 22832bb..c30a6e3 100644 --- a/src/mainboard/asus/p5qc/hda_verb.c +++ b/src/mainboard/asus/p5qc/hda_verb.c @@ -17,13 +17,11 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ 0x10ec0888, - 0x104382fe, // Subsystem ID - 13, // Number of entries + 0x104382fe, /* Subsystem ID */ + 13, /* Number of entries */
/* Pin Widget Verb Table */ - AZALIA_PIN_CFG(0, 0x11, 0x99430140), AZALIA_PIN_CFG(0, 0x14, 0x01014010), AZALIA_PIN_CFG(0, 0x15, 0x01011012), diff --git a/src/mainboard/asus/p5ql-em/hda_verb.c b/src/mainboard/asus/p5ql-em/hda_verb.c index 3be50bb..af758fa 100644 --- a/src/mainboard/asus/p5ql-em/hda_verb.c +++ b/src/mainboard/asus/p5ql-em/hda_verb.c @@ -15,10 +15,9 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ 0x10ec0888, - 0x104382fe, // Subsystem ID - 13, // Number of entries + 0x104382fe, /* Subsystem ID */ + 13, /* Number of entries */
/* Pin Widget Verb Table */ AZALIA_PIN_CFG(0, 0x11, 0x99430130), diff --git a/src/mainboard/asus/p5qpl-am/hda_verb.c b/src/mainboard/asus/p5qpl-am/hda_verb.c index f941a75..37073af 100644 --- a/src/mainboard/asus/p5qpl-am/hda_verb.c +++ b/src/mainboard/asus/p5qpl-am/hda_verb.c @@ -17,14 +17,11 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - /* Realtek ALC662 rev1 */ - 0x10ec0887, /* Vendor ID */ - 0x1043840b, /* Subsystem ID */ - 14, /* Number of entries */ + 0x10ec0887, /* Vendor ID: Realtek ALC662 rev. 1 */ + 0x1043840b, /* Subsystem ID */ + 14, /* Number of entries */
/* Pin Widget Verb Table */ - AZALIA_PIN_CFG(0, 0x11, 0x411111f0), AZALIA_PIN_CFG(0, 0x12, 0x411111f0), AZALIA_PIN_CFG(0, 0x14, 0x01014010), diff --git a/src/mainboard/facebook/fbg1701/hda_verb.c b/src/mainboard/facebook/fbg1701/hda_verb.c index 344443f..9c49d6f 100644 --- a/src/mainboard/facebook/fbg1701/hda_verb.c +++ b/src/mainboard/facebook/fbg1701/hda_verb.c @@ -17,26 +17,26 @@
const u32 cim_verb_data[] = { /* coreboot specific header */ - 0x10EC0298, /* Codec Vendor - Device ID: Realtek ALC298 */ - 0x152D1165, /* Subsystem ID Quanta */ - 0x0000000C, /* Number of jacks */ + 0x10ec0298, /* Codec Vendor - Device ID: Realtek ALC298 */ + 0x152d1165, /* Subsystem ID Quanta */ + 12, /* Number of jacks */
/* HDA Codec Subsystem ID Verb Table */ - AZALIA_SUBVENDOR(0x0, 0x152D1165), + AZALIA_SUBVENDOR(0x0, 0x152d1165),
/* Pin Widget Verb Table */
/* Widget node 1 (NID 0x01) */ - 0x0017FF00, - 0x0017FF00, - 0x0017FF00, - 0x0017FF00, + 0x0017ff00, + 0x0017ff00, + 0x0017ff00, + 0x0017ff00,
/* Pin Complex (NID 0x12) DMIC */ - AZALIA_PIN_CFG(0x0, 0x12, 0x90A60130), + AZALIA_PIN_CFG(0x0, 0x12, 0x90a60130),
/* Pin Complex (NID 0x13) DMIC */ - AZALIA_PIN_CFG(0x0, 0x13, 0x411111F0), + AZALIA_PIN_CFG(0x0, 0x13, 0x411111f0),
/* Pin Complex (NID 0x14) SPEAKER-OUT (Port-D) */ AZALIA_PIN_CFG(0x0, 0x14, 0x90180110), @@ -45,32 +45,31 @@ AZALIA_PIN_CFG(0x0, 0x17, 0x01011120),
/* Pin Complex (NID 0x18) MIC1 (Port-B) */ - AZALIA_PIN_CFG(0x0, 0x18, 0x41111F0), + AZALIA_PIN_CFG(0x0, 0x18, 0x411111f0),
/* Pin Complex (NID 0x19) I2S-IN */ AZALIA_PIN_CFG(0x0, 0x19, 0x90870140),
- /* Pin Complex (NID 0x1A) LINE1 (Port-C) */ - AZALIA_PIN_CFG(0x0, 0x1A, 0x411111F0), + /* Pin Complex (NID 0x1a) LINE1 (Port-C) */ + AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
- /* Pin Complex (NID 0x1D) PC-BEEP */ - AZALIA_PIN_CFG(0x0, 0x1D, 0x40400001), + /* Pin Complex (NID 0x1d) PC-BEEP */ + AZALIA_PIN_CFG(0x0, 0x1d, 0x40400001),
- /* Pin Complex (NID 0x1E) SPDIF-OUT */ - AZALIA_PIN_CFG(0x0, 0x1E, 0x411111F0), + /* Pin Complex (NID 0x1e) SPDIF-OUT */ + AZALIA_PIN_CFG(0x0, 0x1e, 0x411111f0),
- /* Pin Complex (NID 0x1F) SPDIF-IN */ - AZALIA_PIN_CFG(0x0, 0x1F, 0x411111F0), + /* Pin Complex (NID 0x1f) SPDIF-IN */ + AZALIA_PIN_CFG(0x0, 0x1f, 0x411111f0),
/* Pin Complex (NID 0x21) HP-OUT (Port-A) */ - AZALIA_PIN_CFG(0x0, 0x21, 0x411111F0), + AZALIA_PIN_CFG(0x0, 0x21, 0x411111f0),
/* POST I2S bypass output SRC */ - 0x0205002D, - 0x0204C020, - 0x0205002D, - 0x0204C020, - + 0x0205002d, + 0x0204c020, + 0x0205002d, + 0x0204c020, };
const u32 pc_beep_verbs[0] = {}; diff --git a/src/mainboard/foxconn/d41s/hda_verb.c b/src/mainboard/foxconn/d41s/hda_verb.c index dbe383e..f237ded 100644 --- a/src/mainboard/foxconn/d41s/hda_verb.c +++ b/src/mainboard/foxconn/d41s/hda_verb.c @@ -16,10 +16,9 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ 0x10ec0662, - 0x105b0d55, // Subsystem ID - 0x0000000a, // Number of entries + 0x105b0d55, /* Subsystem ID */ + 10, /* Number of entries */
/* Pin Widget Verb Table */ AZALIA_PIN_CFG(0, 0x14, 0x01014c10), @@ -34,6 +33,6 @@ AZALIA_PIN_CFG(0, 0x1e, 0x99430120), };
-const u32 pc_beep_verbs[] = { -}; +const u32 pc_beep_verbs[] = {}; + AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/foxconn/g41s-k/hda_verb.c b/src/mainboard/foxconn/g41s-k/hda_verb.c index bb787b2..b1c495e 100644 --- a/src/mainboard/foxconn/g41s-k/hda_verb.c +++ b/src/mainboard/foxconn/g41s-k/hda_verb.c @@ -19,10 +19,9 @@
#if CONFIG(BOARD_FOXCONN_G41S_K) const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0888, /* Vendor ID */ - 0x105b0dda, /* Subsystem ID */ - 0x0000000e, /* Number of entries */ + 0x10ec0888, /* Vendor ID */ + 0x105b0dda, /* Subsystem ID */ + 14, /* Number of entries */
/* Pin Widget Verb Table */
@@ -41,12 +40,12 @@ AZALIA_PIN_CFG(0, 0x1e, 0x01441130), AZALIA_PIN_CFG(0, 0x1f, 0x411111f0), }; + #else /* CONFIG_BOARD_FOXCONN_G41M */ const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0888, /* Vendor ID */ - 0x105b0dc0, /* Subsystem ID */ - 0x0000000e, /* Number of entries */ + 0x10ec0888, /* Vendor ID */ + 0x105b0dc0, /* Subsystem ID */ + 14, /* Number of entries */
/* Pin Widget Verb Table */
diff --git a/src/mainboard/getac/p470/hda_verb.c b/src/mainboard/getac/p470/hda_verb.c index e858a35..3635966 100644 --- a/src/mainboard/getac/p470/hda_verb.c +++ b/src/mainboard/getac/p470/hda_verb.c @@ -16,51 +16,49 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0262, // Codec Vendor / Device ID: Realtek ALC262 - 0x10714700, // Subsystem ID - 0x0000000d, // Number of jacks + 0x10ec0262, /* Codec Vendor / Device ID: Realtek ALC262 */ + 0x10714700, /* Subsystem ID */ + 13, /* Number of jacks */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x10ec0000 */ - AZALIA_SUBVENDOR(0x0, 0x10EC0000), + /* HDA Codec Subsystem ID Verb Table */ + AZALIA_SUBVENDOR(0x0, 0x10ec0000),
/* Pin Widget Verb Table */ + /* DMIC */ + AZALIA_PIN_CFG(0x0, 0x12, 0x411111f0),
- /* Pin Complex (NID 0x12), DMIC */ - AZALIA_PIN_CFG(0x0, 0x12, 0x411111F0), - - /* Pin Complex (NID 0x14), LINE_OUT (port D) */ + /* LINE_OUT (port D) */ AZALIA_PIN_CFG(0x0, 0x14, 0x99130110),
- /* Pin Complex (NID 0x15), HP_OUT (port A) */ + /* HP_OUT (port A) */ AZALIA_PIN_CFG(0x0, 0x15, 0x01214020),
- /* Pin Complex (NID 0x16), MONO-OUT */ - AZALIA_PIN_CFG(0x0, 0x16, 0x411111F0), + /* MONO-OUT */ + AZALIA_PIN_CFG(0x0, 0x16, 0x411111f0),
- /* Pin Complex (NID 0x18), MIC1 (port B) */ - AZALIA_PIN_CFG(0x0, 0x18, 0x01A19830), + /* MIC1 (port B) */ + AZALIA_PIN_CFG(0x0, 0x18, 0x01a19830),
- /* Pin Complex (NID 0x19), MIC2 (port F) */ - AZALIA_PIN_CFG(0x0, 0x19, 0x99A30931), + /* MIC2 (port F) */ + AZALIA_PIN_CFG(0x0, 0x19, 0x99a30931),
- /* Pin Complex (NID 0x1A), LINE1 (port C) */ - AZALIA_PIN_CFG(0x0, 0x1A, 0x02A1983F), + /* LINE1 (port C) */ + AZALIA_PIN_CFG(0x0, 0x1a, 0x02a1983f),
- /* Pin Complex (NID 0x1B), LINE2 (port E) */ - AZALIA_PIN_CFG(0x0, 0x1B, 0x0221401F), + /* LINE2 (port E) */ + AZALIA_PIN_CFG(0x0, 0x1b, 0x0221401f),
- /* Pin Complex (NID 0x1C), CD_IN */ - AZALIA_PIN_CFG(0x0, 0x1C, 0x411111F0), + /* CD_IN */ + AZALIA_PIN_CFG(0x0, 0x1c, 0x411111f0),
- /* Pin Complex (NID 0x1D), PCBEEP */ - AZALIA_PIN_CFG(0x0, 0x1D, 0x411111F0), + /* PCBEEP */ + AZALIA_PIN_CFG(0x0, 0x1d, 0x411111f0),
- /* Pin Complex (NID 0x1E), S/PDIF-OUT */ - AZALIA_PIN_CFG(0x0, 0x1E, 0x411111F0), + /* S/PDIF-OUT */ + AZALIA_PIN_CFG(0x0, 0x1e, 0x411111f0),
- /* Pin Complex (NID 0x1F), S/PDIF-IN */ - AZALIA_PIN_CFG(0x0, 0x1F, 0x411111F0), + /* S/PDIF-IN */ + AZALIA_PIN_CFG(0x0, 0x1f, 0x411111f0), };
const u32 pc_beep_verbs[0] = {}; diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/hda_verb.c b/src/mainboard/gigabyte/ga-945gcm-s2l/hda_verb.c index 1b57dfa..8bdde50 100644 --- a/src/mainboard/gigabyte/ga-945gcm-s2l/hda_verb.c +++ b/src/mainboard/gigabyte/ga-945gcm-s2l/hda_verb.c @@ -2,6 +2,7 @@ * This file is part of the coreboot project. * * Copyright (C) 2016 Arthur Heymans arthur@aheymans.xyz + * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. @@ -15,10 +16,9 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0662, /* Vendor ID */ - 0x1458a002, /* Subsystem ID */ - 0x00000009, /* Number of entries */ + 0x10ec0662, /* Vendor ID */ + 0x1458a002, /* Subsystem ID */ + 9, /* Number of entries */
/* Pin Widget Verb Table */ AZALIA_PIN_CFG(0, 0x14, 0x01014010), @@ -34,4 +34,5 @@ };
const u32 pc_beep_verbs[0] = {}; + AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75-d3v/include/variant/hda_verb.h b/src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75-d3v/include/variant/hda_verb.h index 76c4ed3..cb86aaf 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75-d3v/include/variant/hda_verb.h +++ b/src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75-d3v/include/variant/hda_verb.h @@ -15,12 +15,10 @@ #define GA_B75_D3V_HDA_VERB_H
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0887, // Realtek 887 - 0x1458a002, // Subsystem ID - 0x0000000e, // Number of entries + 0x10ec0887, /* Realtek ALC887 */ + 0x1458a002, /* Subsystem ID */ + 14, /* Number of entries */
- /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x2, 0x1458a002),
/* Pin Widget Verb Table */ diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3v/include/variant/hda_verb.h b/src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3v/include/variant/hda_verb.h index c84c80d..0e35aca 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3v/include/variant/hda_verb.h +++ b/src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3v/include/variant/hda_verb.h @@ -15,10 +15,9 @@ #define GA_B75M_D3V_HDA_VERB_H
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0887, // Realtek 887 - 0x1458a002, // Subsystem ID - 0x0000000e, // Number of entries + 0x10ec0887, /* Realtek ALC887 */ + 0x1458a002, /* Subsystem ID */ + 14, /* Number of entries */
/* Pin Widget Verb Table */ AZALIA_PIN_CFG(0, 0x11, 0x411111f0), diff --git a/src/mainboard/gigabyte/ga-g41m-es2l/hda_verb.c b/src/mainboard/gigabyte/ga-g41m-es2l/hda_verb.c index d606582..4b01181 100644 --- a/src/mainboard/gigabyte/ga-g41m-es2l/hda_verb.c +++ b/src/mainboard/gigabyte/ga-g41m-es2l/hda_verb.c @@ -17,13 +17,9 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ 0x10ec0887, - 0x1458a002, // Subsystem ID - 0x0000000e, // Number of entries - - /* Pin Widget Verb Table */ - + 0x1458a002, /* Subsystem ID */ + 14, /* Number of entries */ AZALIA_PIN_CFG(0, 0x11, 0x411110f0), AZALIA_PIN_CFG(0, 0x12, 0x411111f0), AZALIA_PIN_CFG(0, 0x14, 0x01014410), diff --git a/src/mainboard/google/auron/variants/auron_paine/include/variant/hda_verb.h b/src/mainboard/google/auron/variants/auron_paine/include/variant/hda_verb.h index f7cb248..c30b800 100644 --- a/src/mainboard/google/auron/variants/auron_paine/include/variant/hda_verb.h +++ b/src/mainboard/google/auron/variants/auron_paine/include/variant/hda_verb.h @@ -16,22 +16,21 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0283, // Codec Vendor / Device ID: Realtek ALC283 - 0x10ec0283, // Subsystem ID - 0x0000000e, // Number of jacks (NID entries) + 0x10ec0283, /* Codec Vendor / Device ID: Realtek ALC283 */ + 0x10ec0283, /* Subsystem ID */ + 14, /* Number of jacks (NID entries) */
- 0x0017ff00, // Function Reset - 0x0017ff00, // Double Function Reset - 0x000F0000, // Pad - get vendor id - 0x000F0002, // Pad - get revision id + 0x0017ff00, /* Function Reset */ + 0x0017ff00, /* Double Function Reset */ + 0x000f0000, /* Pad - get vendor id */ + 0x000f0002, /* Pad - get revision id */
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ /* Bits 19:8 - Verb ID */ /* Bits 7:0 - Payload */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table */ + /* HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x11790670),
/* Pin Widget Verb Table */ @@ -39,11 +38,13 @@ /* Pin Complex (NID 0x12) DMIC - Disabled */ AZALIA_PIN_CFG(0x0, 0x12, 0x411111f0),
- /* Pin Complex (NID 0x14) SPKR-OUT - Internal Speakers */ - // group 1, cap 0 - // no connector, no jack detect - // speaker out, analog - // fixed function, internal, Location N/A + /* + * Pin Complex (NID 0x14) SPKR-OUT - Internal Speakers + * group 1, cap 0 + * no connector, no jack detect + * speaker out, analog + * fixed function, internal, Location N/A + */ AZALIA_PIN_CFG(0x0, 0x14, 0x90170110),
/* Pin Complex (NID 0x17) MONO Out - Disabled */ @@ -52,38 +53,46 @@ /* Pin Complex (NID 0x18) MIC1 PORTB - Disabled */ AZALIA_PIN_CFG(0x0, 0x18, 0x411111f0),
- /* Pin Complex (NID 0x19) MIC2 - 3.5mm Jack */ - // group2, cap 0 - // black, jack detect - // Mic in, 3.5mm Jack - // connector, External left panel + /* + * Pin Complex (NID 0x19) MIC2 - 3.5mm Jack + * group2, cap 0 + * black, jack detect + * Mic in, 3.5mm Jack + * connector, External left panel + */ AZALIA_PIN_CFG(0x0, 0x19, 0x03a11020),
- /* Pin Complex (NID 0x1A) LINE1 - Internal Mic */ - // group 1, cap 1 - // no connector, no jack detect - // mic in, analog connection - // Fixed function, internal, Location N/A - AZALIA_PIN_CFG(0x0, 0x1A, 0x90a70111), + /* + * Pin Complex (NID 0x1a) LINE1 - Internal Mic + * group 1, cap 1 + * no connector, no jack detect + * mic in, analog connection + * Fixed function, internal, Location N/A + */ + AZALIA_PIN_CFG(0x0, 0x1a, 0x90a70111),
- /* Pin Complex (NID 0x1B) LINE2 - Disabled */ - AZALIA_PIN_CFG(0x0, 0x1B, 0x411111f0), + /* Pin Complex (NID 0x1b) LINE2 - Disabled */ + AZALIA_PIN_CFG(0x0, 0x1b, 0x411111f0),
- /* Pin Complex (NID 0x1D) PCBeep */ - // eapd low on ex-amp, laptop, custom enable - // mute spkr on hpout - // pcbeep en able, checksum - // no physical, Internal, Location N/A - AZALIA_PIN_CFG(0x0, 0x1D, 0x4015812d), + /* + * Pin Complex (NID 0x1d) PCBeep + * eapd low on ex-amp, laptop, custom enable + * mute spkr on hpout + * pcbeep en able, checksum + * no physical, Internal, Location N/A + */ + AZALIA_PIN_CFG(0x0, 0x1d, 0x4015812d),
- /* Pin Complex (NID 0x1E) SPDIF-OUT - Disabled*/ - AZALIA_PIN_CFG(0x0, 0x1E, 0x411111f0), + /* Pin Complex (NID 0x1e) SPDIF-OUT - Disabled */ + AZALIA_PIN_CFG(0x0, 0x1e, 0x411111f0),
- /* Pin Complex (NID 0x21) HP-OUT - 3.5mm Jack*/ - // group2, cap 1 - // black, jack detect - // HPOut, 3.5mm Jack - // connector, left panel + /* + * Pin Complex (NID 0x21) HP-OUT - 3.5mm Jack + * group2, cap 1 + * black, jack detect + * HPOut, 3.5mm Jack + * connector, left panel + */ AZALIA_PIN_CFG(0x0, 0x21, 0x03211021),
/* Undocumented settings from Realtek (needed for beep_gen) */ @@ -95,13 +104,13 @@
/* Tuned jack detection */ 0x02050043, - 0x0204A614, + 0x0204a614, 0x02050047, 0x02049470, };
const u32 pc_beep_verbs[] = { - 0x00170500, /* power up everything (codec, dac, adc, mixers) */ + 0x00170500, /* power up everything (codec, dac, adc, mixers) */ 0x01470740, /* enable speaker out */ 0x01470c02, /* set speaker EAPD pin */ 0x0143b01f, /* unmute speaker */ diff --git a/src/mainboard/google/auron/variants/auron_yuna/include/variant/hda_verb.h b/src/mainboard/google/auron/variants/auron_yuna/include/variant/hda_verb.h index e283e95..34bec66 100644 --- a/src/mainboard/google/auron/variants/auron_yuna/include/variant/hda_verb.h +++ b/src/mainboard/google/auron/variants/auron_yuna/include/variant/hda_verb.h @@ -16,22 +16,21 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0283, // Codec Vendor / Device ID: Realtek ALC283 - 0x10ec0283, // Subsystem ID - 0x00000013, // Number of jacks (NID entries) + 0x10ec0283, /* Codec Vendor / Device ID: Realtek ALC283 */ + 0x10ec0283, /* Subsystem ID */ + 19, /* Number of jacks (NID entries) */
- 0x0017ff00, // Function Reset - 0x0017ff00, // Double Function Reset - 0x000F0000, // Pad - get vendor id - 0x000F0002, // Pad - get revision id + 0x0017ff00, /* Function Reset */ + 0x0017ff00, /* Double Function Reset */ + 0x000f0000, /* Pad - get vendor id */ + 0x000f0002, /* Pad - get revision id */
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ /* Bits 19:8 - Verb ID */ /* Bits 7:0 - Payload */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table */ + /* HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x11790670),
/* Pin Widget Verb Table */ @@ -39,11 +38,13 @@ /* Pin Complex (NID 0x12) DMIC - Enabled */ AZALIA_PIN_CFG(0x0, 0x12, 0x90a60130),
- /* Pin Complex (NID 0x14) SPKR-OUT - Internal Speakers */ - // group 1, cap 0 - // no connector, no jack detect - // speaker out, analog - // fixed function, internal, Location N/A + /* + * Pin Complex (NID 0x14) SPKR-OUT - Internal Speakers + * group 1, cap 0 + * no connector, no jack detect + * speaker out, analog + * fixed function, internal, Location N/A + */ AZALIA_PIN_CFG(0x0, 0x14, 0x90170110),
/* Pin Complex (NID 0x17) MONO Out - Enabled */ @@ -52,34 +53,40 @@ /* Pin Complex (NID 0x18) Disabled */ AZALIA_PIN_CFG(0x0, 0x18, 0x411111f0),
- /* Pin Complex (NID 0x19) MIC2 - 3.5mm Jack */ - // group2, cap 0 - // black, jack detect - // Mic in, 3.5mm Jack - // connector, External left panel + /* + * Pin Complex (NID 0x19) MIC2 - 3.5mm Jack + * group2, cap 0 + * black, jack detect + * Mic in, 3.5mm Jack + * connector, External left panel + */ AZALIA_PIN_CFG(0x0, 0x19, 0x03a11020),
- /* Pin Complex (NID 0x1A) LINE1 - Disabled */ - AZALIA_PIN_CFG(0x0, 0x1A, 0x411111f0), + /* Pin Complex (NID 0x1a) LINE1 - Disabled */ + AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
- /* Pin Complex (NID 0x1B) LINE2 - Disabled */ - AZALIA_PIN_CFG(0x0, 0x1B, 0x411111f0), + /* Pin Complex (NID 0x1b) LINE2 - Disabled */ + AZALIA_PIN_CFG(0x0, 0x1b, 0x411111f0),
- /* Pin Complex (NID 0x1D) PCBeep */ - // eapd low on ex-amp, laptop, custom enable - // mute spkr on hpout - // pcbeep en able, checksum - // no physical, Internal, Location N/A - AZALIA_PIN_CFG(0x0, 0x1D, 0x4015812d), + /* + * Pin Complex (NID 0x1d) PCBeep + * eapd low on ex-amp, laptop, custom enable + * mute spkr on hpout + * pcbeep en able, checksum + * no physical, Internal, Location N/A + */ + AZALIA_PIN_CFG(0x0, 0x1d, 0x4015812d),
- /* Pin Complex (NID 0x1E) SPDIF-OUT - Disabled*/ - AZALIA_PIN_CFG(0x0, 0x1E, 0x411111f0), + /* Pin Complex (NID 0x1e) SPDIF-OUT - Disabled */ + AZALIA_PIN_CFG(0x0, 0x1e, 0x411111f0),
- /* Pin Complex (NID 0x21) HP-OUT - 3.5mm Jack*/ - // group1 - // black, jack detect - // HPOut, 3.5mm Jack - // connector, left panel + /* + * Pin Complex (NID 0x21) HP-OUT - 3.5mm Jack + * group1 + * black, jack detect + * HPOut, 3.5mm Jack + * connector, left panel + */ AZALIA_PIN_CFG(0x0, 0x21, 0x0321101f),
/* Undocumented settings from Realtek (needed for beep_gen) */ @@ -87,28 +94,33 @@ 0x02050038, 0x02046900, 0x02050010, - 0x02040C20, + 0x02040c20, + /* Widget node 0x20 - 1 */ 0x02050019, 0x02041857, - 0x0205001A, + 0x0205001a, 0x02044001, + /* Widget node 0x20 - 2 */ - 0x0205001B, - 0x0204140B, + 0x0205001b, + 0x0204140b, 0x02050025, - 0x0204802A, + 0x0204802a, + /* Widget node 0x20 - 3 */ 0x02050045, 0x02045029, 0x02050046, 0x02040004, + /* Widget node 0x20 - 4 */ 0x02050043, - 0x0204A614, + 0x0204a614, 0x02050043, - 0x0204A614, - /* pc beep */ + 0x0204a614, + + /* PC Beep */ 0x02050010, 0x02040c20, 0x0205001b, @@ -116,13 +128,13 @@
/* Tuned jack detection */ 0x02050043, - 0x0204A614, + 0x0204a614, 0x02050047, 0x02049470, };
const u32 pc_beep_verbs[] = { - 0x00170500, /* power up everything (codec, dac, adc, mixers) */ + 0x00170500, /* power up everything (codec, dac, adc, mixers) */ 0x01470740, /* enable speaker out */ 0x01470c02, /* set speaker EAPD pin */ 0x0143b01f, /* unmute speaker */ diff --git a/src/mainboard/google/auron/variants/buddy/include/variant/hda_verb.h b/src/mainboard/google/auron/variants/buddy/include/variant/hda_verb.h index 7fd9853..d7afc1c 100644 --- a/src/mainboard/google/auron/variants/buddy/include/variant/hda_verb.h +++ b/src/mainboard/google/auron/variants/buddy/include/variant/hda_verb.h @@ -17,22 +17,21 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0283, // Codec Vendor / Device ID: Realtek ALC283 - 0x10ec0283, // Subsystem ID - 0x0000000d, // Number of jacks (NID entries) + 0x10ec0283, /* Codec Vendor / Device ID: Realtek ALC283 */ + 0x10ec0283, /* Subsystem ID */ + 14, /* Number of jacks (NID entries) */
- 0x0017ff00, // Function Reset - 0x0017ff00, // Double Function Reset - 0x000F0000, // Pad - get vendor id - 0x000F0002, // Pad - get revision id + 0x0017ff00, /* Function Reset */ + 0x0017ff00, /* Double Function Reset */ + 0x000f0000, /* Pad - get vendor id */ + 0x000f0002, /* Pad - get revision id */
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ /* Bits 19:8 - Verb ID */ /* Bits 7:0 - Payload */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x10ec0283 */ + /* HDA Codec Subsystem ID Verb Table */ 0x00172083, 0x00172102, 0x001722ec, @@ -41,64 +40,64 @@ /* Pin Widget Verb Table */
/* Pin Complex (NID 0x12) DMIC - Disabled */ - 0x01271cf0, // - 0x01271d11, // - 0x01271e11, // - 0x01271f41, // + 0x01271cf0, + 0x01271d11, + 0x01271e11, + 0x01271f41,
/* Pin Complex (NID 0x14) SPKR-OUT - Internal Speakers */ - 0x01471c10, // group 1, cap 0 - 0x01471d01, // no connector, no jack detect - 0x01471e17, // speaker out, analog - 0x01471f90, // fixed function, internal, Location N/A + 0x01471c10, /* group 1, cap 0 */ + 0x01471d01, /* no connector, no jack detect */ + 0x01471e17, /* speaker out, analog */ + 0x01471f90, /* fixed function, internal, Location N/A */
/* Pin Complex (NID 0x17) MONO Out - Disabled */ - 0x01771cf0, // - 0x01771d11, // - 0x01771e11, // - 0x01771f41, // + 0x01771cf0, + 0x01771d11, + 0x01771e11, + 0x01771f41,
/* Pin Complex (NID 0x18) Disabled */ - 0x01871cf0, // - 0x01871d11, // - 0x01871e11, // - 0x01871f41, // + 0x01871cf0, + 0x01871d11, + 0x01871e11, + 0x01871f41,
/* Pin Complex (NID 0x19) MIC2 - 3.5mm Jack */ - 0x01971c20, // group2, cap 0 - 0x01971d10, // black, jack detect - 0x01971ea1, // Mic in, 3.5mm Jack - 0x01971f03, // connector, External left panel + 0x01971c20, /* group2, cap 0 */ + 0x01971d10, /* black, jack detect */ + 0x01971ea1, /* Mic in, 3.5mm Jack */ + 0x01971f03, /* connector, External left panel */
- /* Pin Complex (NID 0x1A) LINE1 - Internal Mic */ - 0x01a71c11, // group 1, cap 1 - 0x01a71d01, // no connector, no jack detect - 0x01a71ea7, // mic in, analog connection - 0x01a71f90, // Fixed function, internal, Location N/A + /* Pin Complex (NID 0x1a) LINE1 - Internal Mic */ + 0x01a71c11, /* group 1, cap 1 */ + 0x01a71d01, /* no connector, no jack detect */ + 0x01a71ea7, /* mic in, analog connection */ + 0x01a71f90, /* Fixed function, internal, Location N/A */
- /* Pin Complex (NID 0x1B) LINE2 - Disabled */ - 0x01b71cf0, // - 0x01b71d11, // - 0x01b71e11, // - 0x01b71f41, // + /* Pin Complex (NID 0x1b) LINE2 - Disabled */ + 0x01b71cf0, + 0x01b71d11, + 0x01b71e11, + 0x01b71f41,
- /* Pin Complex (NID 0x1D) PCBeep */ - 0x01d71c2d, // eapd low on ex-amp, laptop, custom enable - 0x01d71d81, // mute spkr on hpout - 0x01d71e15, // pcbeep en able, checksum - 0x01d71f40, // no physical, Internal, Location N/A + /* Pin Complex (NID 0x1d) PCBeep */ + 0x01d71c2d, /* eapd low on ex-amp, laptop, custom enable */ + 0x01d71d81, /* mute spkr on hpout */ + 0x01d71e15, /* pcbeep en able, checksum */ + 0x01d71f40, /* no physical, Internal, Location N/A */
- /* Pin Complex (NID 0x1E) SPDIF-OUT - Disabled*/ - 0x01e71cf0, // - 0x01e71d11, // - 0x01e71e11, // - 0x01e71f41, // + /* Pin Complex (NID 0x1e) SPDIF-OUT - Disabled*/ + 0x01e71cf0, + 0x01e71d11, + 0x01e71e11, + 0x01e71f41,
- /* Pin Complex (NID 0x21) HP-OUT - 3.5mm Jack*/ - 0x02171c21, // group2, cap 1 - 0x02171d10, // black, jack detect - 0x02171e21, // HPOut, 3.5mm Jack - 0x02171f03, // connector, left panel + /* Pin Complex (NID 0x21) HP-OUT - 3.5mm Jack */ + 0x02171c21, /* group2, cap 1 */ + 0x02171d10, /* black, jack detect */ + 0x02171e21, /* HPOut, 3.5mm Jack */ + 0x02171f03, /* connector, left panel */
/* Undocumented settings from Realtek (needed for beep_gen) */ /* Widget node 0x20 */ @@ -109,7 +108,7 @@ };
const u32 pc_beep_verbs[] = { - 0x00170500, /* power up everything (codec, dac, adc, mixers) */ + 0x00170500, /* power up everything (codec, dac, adc, mixers) */ 0x01470c00, /* set speaker EAPD pin to low */ 0x01470740, /* enable speaker out */ 0x0143b01f, /* unmute speaker */ diff --git a/src/mainboard/google/auron/variants/gandof/include/variant/hda_verb.h b/src/mainboard/google/auron/variants/gandof/include/variant/hda_verb.h index dc2d534..fc29a14 100644 --- a/src/mainboard/google/auron/variants/gandof/include/variant/hda_verb.h +++ b/src/mainboard/google/auron/variants/gandof/include/variant/hda_verb.h @@ -16,38 +16,41 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0283, // Codec Vendor / Device ID: Realtek ALC283 - 0x10ec0283, // Subsystem ID - 0x0000000e, // Number of jacks (NID entries) + 0x10ec0283, /* Codec Vendor / Device ID: Realtek ALC283 */ + 0x10ec0283, /* Subsystem ID */ + 14, /* Number of jacks (NID entries) */
- 0x0017ff00, // Function Reset - 0x0017ff00, // Double Function Reset - 0x000F0000, // Pad - get vendor id - 0x000F0002, // Pad - get revision id + 0x0017ff00, /* Function Reset */ + 0x0017ff00, /* Double Function Reset */ + 0x000f0000, /* Pad - get vendor id */ + 0x000f0002, /* Pad - get revision id */
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ /* Bits 19:8 - Verb ID */ /* Bits 7:0 - Payload */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table */ + /* HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x11790670),
/* Pin Widget Verb Table */
- /* Pin Complex (NID 0x12) DMIC - Internal MIC */ - // group 3, cap 0 - // no connector, no jack detect - // mic in, digital - // fixed function, internal + /* + * Pin Complex (NID 0x12) DMIC - Internal MIC + * group 3, cap 0 + * no connector, no jack detect + * mic in, digital + * fixed function, internal + */ AZALIA_PIN_CFG(0x0, 0x12, 0x90a60130),
- /* Pin Complex (NID 0x14) SPKR-OUT - Internal Speakers */ - // group 1, cap 0 - // no connector, no jack detect - // speaker out, analog - // fixed function, internal, Location N/A + /* + * Pin Complex (NID 0x14) SPKR-OUT - Internal Speakers + * group 1, cap 0 + * no connector, no jack detect + * speaker out, analog + * fixed function, internal, Location N/A + */ AZALIA_PIN_CFG(0x0, 0x14, 0x90170110),
/* Pin Complex (NID 0x17) MONO Out - Disabled */ @@ -56,34 +59,40 @@ /* Pin Complex (NID 0x18) MIC1 PORTB - Disabled */ AZALIA_PIN_CFG(0x0, 0x18, 0x411111f0),
- /* Pin Complex (NID 0x19) MIC2 - 3.5mm Jack */ - // group2, cap 0 - // black, jack detect - // Mic in, 3.5mm Jack - // connector, External left panel + /* + * Pin Complex (NID 0x19) MIC2 - 3.5mm Jack + * group2, cap 0 + * black, jack detect + * Mic in, 3.5mm Jack + * connector, External left panel + */ AZALIA_PIN_CFG(0x0, 0x19, 0x03a11020),
- /* Pin Complex (NID 0x1A) LINE1 - Disabled */ - AZALIA_PIN_CFG(0x0, 0x1A, 0x411111f0), + /* Pin Complex (NID 0x1a) LINE1 - Disabled */ + AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
- /* Pin Complex (NID 0x1B) LINE2 - Disabled */ - AZALIA_PIN_CFG(0x0, 0x1B, 0x411111f0), + /* Pin Complex (NID 0x1b) LINE2 - Disabled */ + AZALIA_PIN_CFG(0x0, 0x1b, 0x411111f0),
- /* Pin Complex (NID 0x1D) PCBeep */ - // eapd low on ex-amp, laptop, custom enable - // mute spkr on hpout - // pcbeep en able, checksum - // no physical, Internal, Location N/A - AZALIA_PIN_CFG(0x0, 0x1D, 0x4015812d), + /* + * Pin Complex (NID 0x1d) PCBeep + * eapd low on ex-amp, laptop, custom enable + * mute spkr on hpout + * pcbeep en able, checksum + * no physical, Internal, Location N/A + */ + AZALIA_PIN_CFG(0x0, 0x1d, 0x4015812d),
- /* Pin Complex (NID 0x1E) SPDIF-OUT - Disabled */ - AZALIA_PIN_CFG(0x0, 0x1E, 0x411111f0), + /* Pin Complex (NID 0x1e) SPDIF-OUT - Disabled */ + AZALIA_PIN_CFG(0x0, 0x1e, 0x411111f0),
- /* Pin Complex (NID 0x21) HP-OUT - 3.5mm Jack */ - // group2, cap 1 - // black, jack detect - // HPOut, 3.5mm Jack - // connector, left panel + /* + * Pin Complex (NID 0x21) HP-OUT - 3.5mm Jack + * group2, cap 1 + * black, jack detect + * HPOut, 3.5mm Jack + * connector, left panel + */ AZALIA_PIN_CFG(0x0, 0x21, 0x03211021),
/* Undocumented settings from Realtek (needed for beep_gen) */ @@ -95,13 +104,13 @@
/* Tuned jack detection */ 0x02050043, - 0x0204A614, + 0x0204a614, 0x02050047, 0x02049470, };
const u32 pc_beep_verbs[] = { - 0x00170500, /* power up everything (codec, dac, adc, mixers) */ + 0x00170500, /* power up everything (codec, dac, adc, mixers) */ 0x01470740, /* enable speaker out */ 0x01470c02, /* set speaker EAPD pin */ 0x0143b01f, /* unmute speaker */ diff --git a/src/mainboard/google/auron/variants/lulu/include/variant/hda_verb.h b/src/mainboard/google/auron/variants/lulu/include/variant/hda_verb.h index a214a50..fc29a14 100644 --- a/src/mainboard/google/auron/variants/lulu/include/variant/hda_verb.h +++ b/src/mainboard/google/auron/variants/lulu/include/variant/hda_verb.h @@ -16,38 +16,41 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0283, // Codec Vendor / Device ID: Realtek ALC283 - 0x10ec0283, // Subsystem ID - 0x0000000e, // Number of jacks (NID entries) + 0x10ec0283, /* Codec Vendor / Device ID: Realtek ALC283 */ + 0x10ec0283, /* Subsystem ID */ + 14, /* Number of jacks (NID entries) */
- 0x0017ff00, // Function Reset - 0x0017ff00, // Double Function Reset - 0x000F0000, // Pad - get vendor id - 0x000F0002, // Pad - get revision id + 0x0017ff00, /* Function Reset */ + 0x0017ff00, /* Double Function Reset */ + 0x000f0000, /* Pad - get vendor id */ + 0x000f0002, /* Pad - get revision id */
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ /* Bits 19:8 - Verb ID */ /* Bits 7:0 - Payload */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table */ + /* HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x11790670),
/* Pin Widget Verb Table */
- /* Pin Complex (NID 0x12) DMIC - Internal MIC */ - // group 3, cap 0 - // no connector, no jack detect - // mic in, digital - // fixed function, internal + /* + * Pin Complex (NID 0x12) DMIC - Internal MIC + * group 3, cap 0 + * no connector, no jack detect + * mic in, digital + * fixed function, internal + */ AZALIA_PIN_CFG(0x0, 0x12, 0x90a60130),
- /* Pin Complex (NID 0x14) SPKR-OUT - Internal Speakers */ - // group 1, cap 0 - // no connector, no jack detect - // speaker out, analog - // fixed function, internal, Location N/A + /* + * Pin Complex (NID 0x14) SPKR-OUT - Internal Speakers + * group 1, cap 0 + * no connector, no jack detect + * speaker out, analog + * fixed function, internal, Location N/A + */ AZALIA_PIN_CFG(0x0, 0x14, 0x90170110),
/* Pin Complex (NID 0x17) MONO Out - Disabled */ @@ -56,34 +59,40 @@ /* Pin Complex (NID 0x18) MIC1 PORTB - Disabled */ AZALIA_PIN_CFG(0x0, 0x18, 0x411111f0),
- /* Pin Complex (NID 0x19) MIC2 - 3.5mm Jack */ - // group2, cap 0 - // black, jack detect - // Mic in, 3.5mm Jack - // connector, External left panel + /* + * Pin Complex (NID 0x19) MIC2 - 3.5mm Jack + * group2, cap 0 + * black, jack detect + * Mic in, 3.5mm Jack + * connector, External left panel + */ AZALIA_PIN_CFG(0x0, 0x19, 0x03a11020),
- /* Pin Complex (NID 0x1A) LINE1 - Disabled */ - AZALIA_PIN_CFG(0x0, 0x1A, 0x411111f0), + /* Pin Complex (NID 0x1a) LINE1 - Disabled */ + AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
- /* Pin Complex (NID 0x1B) LINE2 - Disabled */ - AZALIA_PIN_CFG(0x0, 0x1B, 0x411111f0), + /* Pin Complex (NID 0x1b) LINE2 - Disabled */ + AZALIA_PIN_CFG(0x0, 0x1b, 0x411111f0),
- /* Pin Complex (NID 0x1D) PCBeep */ - // eapd low on ex-amp, laptop, custom enable - // mute spkr on hpout - // pcbeep en able, checksum - // no physical, Internal, Location N/A + /* + * Pin Complex (NID 0x1d) PCBeep + * eapd low on ex-amp, laptop, custom enable + * mute spkr on hpout + * pcbeep en able, checksum + * no physical, Internal, Location N/A + */ AZALIA_PIN_CFG(0x0, 0x1d, 0x4015812d),
- /* Pin Complex (NID 0x1E) SPDIF-OUT - Disabled*/ - AZALIA_PIN_CFG(0x0, 0x1E, 0x411111f0), + /* Pin Complex (NID 0x1e) SPDIF-OUT - Disabled */ + AZALIA_PIN_CFG(0x0, 0x1e, 0x411111f0),
- /* Pin Complex (NID 0x21) HP-OUT - 3.5mm Jack*/ - // group2, cap 1 - // black, jack detect - // HPOut, 3.5mm Jack - // connector, left panel + /* + * Pin Complex (NID 0x21) HP-OUT - 3.5mm Jack + * group2, cap 1 + * black, jack detect + * HPOut, 3.5mm Jack + * connector, left panel + */ AZALIA_PIN_CFG(0x0, 0x21, 0x03211021),
/* Undocumented settings from Realtek (needed for beep_gen) */ @@ -95,13 +104,13 @@
/* Tuned jack detection */ 0x02050043, - 0x0204A614, + 0x0204a614, 0x02050047, 0x02049470, };
const u32 pc_beep_verbs[] = { - 0x00170500, /* power up everything (codec, dac, adc, mixers) */ + 0x00170500, /* power up everything (codec, dac, adc, mixers) */ 0x01470740, /* enable speaker out */ 0x01470c02, /* set speaker EAPD pin */ 0x0143b01f, /* unmute speaker */ diff --git a/src/mainboard/google/beltino/variants/mccloud/hda_verb.c b/src/mainboard/google/beltino/variants/mccloud/hda_verb.c index 233a8ee..7162b73 100644 --- a/src/mainboard/google/beltino/variants/mccloud/hda_verb.c +++ b/src/mainboard/google/beltino/variants/mccloud/hda_verb.c @@ -13,21 +13,17 @@ * GNU General Public License for more details. */
-#ifndef HDA_VERB_H -#define HDA_VERB_H - #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0283, // Codec Vendor / Device ID: Realtek ALC283 - 0x10ec0283, // Subsystem ID - 0x0000000e, // Number of jacks (NID entries) + 0x10ec0283, /* Codec Vendor / Device ID: Realtek ALC283 */ + 0x10ec0283, /* Subsystem ID */ + 14, /* Number of jacks (NID entries) */
- 0x0017ff00, // Function Reset - 0x0017ff00, // Double Function Reset - 0x000F0000, // Pad - get vendor id - 0x000F0002, // Pad - get revision id + 0x0017ff00, /* Function Reset */ + 0x0017ff00, /* Double Function Reset */ + 0x000f0000, /* Pad - get vendor id */ + 0x000f0002, /* Pad - get revision id */
/* NID 0x01, HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x11790670), @@ -43,37 +39,44 @@ /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0x0, 0x17, 0x411111f0),
- /* Pin Complex (NID 0x18) MIC1 PORTB */ - // group 1, cap 1 - // black, jack detect - // mic in, analog - // connector, left panel - AZALIA_PIN_CFG(0x0, 0x19, 0x03a71011),
- /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ + /* Pin Complex (NID 0x18) MIC1 PORTB - Disabled */ AZALIA_PIN_CFG(0x0, 0x18, 0x411111f0),
- /* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ + /* + * Pin Complex (NID 0x19) MIC2 PORTF + * group 1, cap 1 + * black, jack detect + * mic in, analog + * connector, left panel + */ + AZALIA_PIN_CFG(0x0, 0x19, 0x03a71011), + + /* Pin Complex (NID 0x1a) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
- /* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */ + /* Pin Complex (NID 0x1b) LINE2 PORTE - Disabled */ AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
- /* Pin Complex (NID 0x1d) PCBeep */ - // eapd low on ex-amp, laptop, custom enable - // mute spkr on hpout - // pcbeep en able, checksum - // no physical, internal + /* + * Pin Complex (NID 0x1d) PCBeep + * eapd low on ex-amp, laptop, custom enable + * mute spkr on hpout + * pcbeep en able, checksum + * no physical, internal + */ AZALIA_PIN_CFG(0x0, 0x1d, 0x4015812d),
- /* Pin Complex (NID 0x1E) SPDIF-OUT - Disabled */ + /* Pin Complex (NID 0x1e) SPDIF-OUT - Disabled */ AZALIA_PIN_CFG(0x0, 0x1e, 0x411111f0),
- /* Pin Complex (NID 0x21) HPOUT PORT-I */ - // group1, - // black, jack detect - // HPOut, 1/8 stereo - // connector, left panel + /* + * Pin Complex (NID 0x21) HPOUT PORT-I + * group1, + * black, jack detect + * HPOut, 1/8 stereo + * connector, left panel + */ AZALIA_PIN_CFG(0x0, 0x21, 0x0321101f),
/* Undocumented settings from Realtek (needed for beep_gen) */ @@ -85,7 +88,7 @@
/* Tuned jack detection */ 0x02050043, - 0x0204A614, + 0x0204a614, 0x02050047, 0x02049470, }; @@ -99,6 +102,4 @@ 0x00b37410, /* unmute mixer nid 0xb beep input and set volume */ };
- -#endif /* HDA_VERB_H */ AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/google/beltino/variants/monroe/hda_verb.c b/src/mainboard/google/beltino/variants/monroe/hda_verb.c index 8281fb8..c0f029c 100644 --- a/src/mainboard/google/beltino/variants/monroe/hda_verb.c +++ b/src/mainboard/google/beltino/variants/monroe/hda_verb.c @@ -13,21 +13,17 @@ * GNU General Public License for more details. */
-#ifndef HDA_VERB_H -#define HDA_VERB_H - #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0283, // Codec Vendor / Device ID: Realtek ALC283 - 0x10ec0283, // Subsystem ID - 0x0000000e, // Number of jacks (NID entries) + 0x10ec0283, /* Codec Vendor / Device ID: Realtek ALC283 */ + 0x10ec0283, /* Subsystem ID */ + 14, /* Number of jacks (NID entries) */
- 0x0017ff00, // Function Reset - 0x0017ff00, // Double Function Reset - 0x000F0000, // Pad - get vendor id - 0x000F0002, // Pad - get revision id + 0x0017ff00, /* Function Reset */ + 0x0017ff00, /* Double Function Reset */ + 0x000f0000, /* Pad - get vendor id */ + 0x000f0002, /* Pad - get revision id */
/* NID 0x01, HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x11790670), @@ -43,26 +39,28 @@ /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0x0, 0x17, 0x411111f0),
- /* Pin Complex (NID 0x18) MIC1 PORTB - Disabled*/ - AZALIA_PIN_CFG(0x0, 0x19, 0x411111f0), - - /* Pin Complex (NID 0x19) MIC2 PORTF - 3.5mm Jack*/ + /* Pin Complex (NID 0x18) MIC1 PORTB - 3.5mm Jack*/ AZALIA_PIN_CFG(0x0, 0x18, 0x03a11020),
- /* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ + /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled*/ + AZALIA_PIN_CFG(0x0, 0x19, 0x411111f0), + + /* Pin Complex (NID 0x1a) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
- /* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */ - AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0), + /* Pin Complex (NID 0x1b) LINE2 PORTE - Disabled */ + AZALIA_PIN_CFG(0x0, 0x1b, 0x411111f0),
- /* Pin Complex (NID 0x1d) PCBeep */ - // eapd low on ex-amp, laptop, custom enable - // mute spkr on hpout - // pcbeep en able, checksum - // no physical, internal + /* + * Pin Complex (NID 0x1d) PCBeep + * eapd low on ex-amp, laptop, custom enable + * mute spkr on hpout + * pcbeep en able, checksum + * no physical, internal + */ AZALIA_PIN_CFG(0x0, 0x1d, 0x4015812d),
- /* Pin Complex (NID 0x1E) SPDIF-OUT - Disabled */ + /* Pin Complex (NID 0x1e) SPDIF-OUT - Disabled */ AZALIA_PIN_CFG(0x0, 0x1e, 0x411111f0),
/* Pin Complex (NID 0x21) HPOUT PORT-I - Disabled */ @@ -74,6 +72,7 @@ 0x02040c20, 0x0205001b, 0x0204081b, + /* Undocumented settings for SENSE_B pin jack detection */ 0x02050006, 0x02042100, @@ -86,7 +85,7 @@
/* Tuned jack detection */ 0x02050043, - 0x0204A614, + 0x0204a614, 0x02050047, 0x02049470, }; @@ -100,6 +99,4 @@ 0x00b37410, /* unmute mixer nid 0xb beep input and set volume */ };
- -#endif /* HDA_VERB_H */ AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/google/beltino/variants/panther/hda_verb.c b/src/mainboard/google/beltino/variants/panther/hda_verb.c index 233a8ee..fbc256b 100644 --- a/src/mainboard/google/beltino/variants/panther/hda_verb.c +++ b/src/mainboard/google/beltino/variants/panther/hda_verb.c @@ -13,21 +13,17 @@ * GNU General Public License for more details. */
-#ifndef HDA_VERB_H -#define HDA_VERB_H - #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0283, // Codec Vendor / Device ID: Realtek ALC283 - 0x10ec0283, // Subsystem ID - 0x0000000e, // Number of jacks (NID entries) + 0x10ec0283, /* Codec Vendor / Device ID: Realtek ALC283 */ + 0x10ec0283, /* Subsystem ID */ + 14, /* Number of jacks (NID entries) */
- 0x0017ff00, // Function Reset - 0x0017ff00, // Double Function Reset - 0x000F0000, // Pad - get vendor id - 0x000F0002, // Pad - get revision id + 0x0017ff00, /* Function Reset */ + 0x0017ff00, /* Double Function Reset */ + 0x000f0000, /* Pad - get vendor id */ + 0x000f0002, /* Pad - get revision id */
/* NID 0x01, HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x11790670), @@ -43,37 +39,42 @@ /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0x0, 0x17, 0x411111f0),
- /* Pin Complex (NID 0x18) MIC1 PORTB */ - // group 1, cap 1 - // black, jack detect - // mic in, analog - // connector, left panel + /* Pin Complex (NID 0x18) MIC1 PORTB + * group 1, cap 1 + * black, jack detect + * mic in, analog + * connector, left panel + */ AZALIA_PIN_CFG(0x0, 0x19, 0x03a71011),
/* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ AZALIA_PIN_CFG(0x0, 0x18, 0x411111f0),
- /* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ + /* Pin Complex (NID 0x1a) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
- /* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */ + /* Pin Complex (NID 0x1b) LINE2 PORTE - Disabled */ AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
- /* Pin Complex (NID 0x1d) PCBeep */ - // eapd low on ex-amp, laptop, custom enable - // mute spkr on hpout - // pcbeep en able, checksum - // no physical, internal + /* + * Pin Complex (NID 0x1d) PCBeep + * eapd low on ex-amp, laptop, custom enable + * mute spkr on hpout + * pcbeep en able, checksum + * no physical, internal + */ AZALIA_PIN_CFG(0x0, 0x1d, 0x4015812d),
- /* Pin Complex (NID 0x1E) SPDIF-OUT - Disabled */ + /* Pin Complex (NID 0x1e) SPDIF-OUT - Disabled */ AZALIA_PIN_CFG(0x0, 0x1e, 0x411111f0),
- /* Pin Complex (NID 0x21) HPOUT PORT-I */ - // group1, - // black, jack detect - // HPOut, 1/8 stereo - // connector, left panel + /* + * Pin Complex (NID 0x21) HPOUT PORT-I + * group1, + * black, jack detect + * HPOut, 1/8 stereo + * connector, left panel + */ AZALIA_PIN_CFG(0x0, 0x21, 0x0321101f),
/* Undocumented settings from Realtek (needed for beep_gen) */ @@ -85,7 +86,7 @@
/* Tuned jack detection */ 0x02050043, - 0x0204A614, + 0x0204a614, 0x02050047, 0x02049470, }; @@ -99,6 +100,4 @@ 0x00b37410, /* unmute mixer nid 0xb beep input and set volume */ };
- -#endif /* HDA_VERB_H */ AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/google/beltino/variants/tricky/hda_verb.c b/src/mainboard/google/beltino/variants/tricky/hda_verb.c index 233a8ee..348dfc4 100644 --- a/src/mainboard/google/beltino/variants/tricky/hda_verb.c +++ b/src/mainboard/google/beltino/variants/tricky/hda_verb.c @@ -13,21 +13,17 @@ * GNU General Public License for more details. */
-#ifndef HDA_VERB_H -#define HDA_VERB_H - #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0283, // Codec Vendor / Device ID: Realtek ALC283 - 0x10ec0283, // Subsystem ID - 0x0000000e, // Number of jacks (NID entries) + 0x10ec0283, /* Codec Vendor / Device ID: Realtek ALC283 */ + 0x10ec0283, /* Subsystem ID */ + 14, /* Number of jacks (NID entries) */
- 0x0017ff00, // Function Reset - 0x0017ff00, // Double Function Reset - 0x000F0000, // Pad - get vendor id - 0x000F0002, // Pad - get revision id + 0x0017ff00, /* Function Reset */ + 0x0017ff00, /* Double Function Reset */ + 0x000f0000, /* Pad - get vendor id */ + 0x000f0002, /* Pad - get revision id */
/* NID 0x01, HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x11790670), @@ -43,37 +39,43 @@ /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0x0, 0x17, 0x411111f0),
- /* Pin Complex (NID 0x18) MIC1 PORTB */ - // group 1, cap 1 - // black, jack detect - // mic in, analog - // connector, left panel - AZALIA_PIN_CFG(0x0, 0x19, 0x03a71011), - - /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ + /* Pin Complex (NID 0x18) MIC1 PORTB - Disabled */ AZALIA_PIN_CFG(0x0, 0x18, 0x411111f0),
+ /* + * Pin Complex (NID 0x19) MIC2 PORTF + * group 1, cap 1 + * black, jack detect + * mic in, analog + * connector, left panel + */ + AZALIA_PIN_CFG(0x0, 0x19, 0x03a71011), + /* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
/* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */ AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
- /* Pin Complex (NID 0x1d) PCBeep */ - // eapd low on ex-amp, laptop, custom enable - // mute spkr on hpout - // pcbeep en able, checksum - // no physical, internal + /* + * Pin Complex (NID 0x1d) PCBeep + * eapd low on ex-amp, laptop, custom enable + * mute spkr on hpout + * pcbeep en able, checksum + * no physical, internal + */ AZALIA_PIN_CFG(0x0, 0x1d, 0x4015812d),
/* Pin Complex (NID 0x1E) SPDIF-OUT - Disabled */ AZALIA_PIN_CFG(0x0, 0x1e, 0x411111f0),
- /* Pin Complex (NID 0x21) HPOUT PORT-I */ - // group1, - // black, jack detect - // HPOut, 1/8 stereo - // connector, left panel + /* + * Pin Complex (NID 0x21) HPOUT PORT-I + * group1, + * black, jack detect + * HPOut, 1/8 stereo + * connector, left panel + */ AZALIA_PIN_CFG(0x0, 0x21, 0x0321101f),
/* Undocumented settings from Realtek (needed for beep_gen) */ @@ -85,7 +87,7 @@
/* Tuned jack detection */ 0x02050043, - 0x0204A614, + 0x0204a614, 0x02050047, 0x02049470, }; @@ -100,5 +102,4 @@ };
-#endif /* HDA_VERB_H */ AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/google/beltino/variants/zako/hda_verb.c b/src/mainboard/google/beltino/variants/zako/hda_verb.c index 233a8ee..af6bbf9 100644 --- a/src/mainboard/google/beltino/variants/zako/hda_verb.c +++ b/src/mainboard/google/beltino/variants/zako/hda_verb.c @@ -13,21 +13,17 @@ * GNU General Public License for more details. */
-#ifndef HDA_VERB_H -#define HDA_VERB_H - #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0283, // Codec Vendor / Device ID: Realtek ALC283 - 0x10ec0283, // Subsystem ID - 0x0000000e, // Number of jacks (NID entries) + 0x10ec0283, /* Codec Vendor / Device ID: Realtek ALC283 */ + 0x10ec0283, /* Subsystem ID */ + 14, /* Number of jacks (NID entries) */
- 0x0017ff00, // Function Reset - 0x0017ff00, // Double Function Reset - 0x000F0000, // Pad - get vendor id - 0x000F0002, // Pad - get revision id + 0x0017ff00, /* Function Reset */ + 0x0017ff00, /* Double Function Reset */ + 0x000f0000, /* Pad - get vendor id */ + 0x000f0002, /* Pad - get revision id */
/* NID 0x01, HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x11790670), @@ -43,37 +39,43 @@ /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0x0, 0x17, 0x411111f0),
- /* Pin Complex (NID 0x18) MIC1 PORTB */ - // group 1, cap 1 - // black, jack detect - // mic in, analog - // connector, left panel - AZALIA_PIN_CFG(0x0, 0x19, 0x03a71011), - - /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ + /* Pin Complex (NID 0x18) MIC1 PORTB - Disabled */ AZALIA_PIN_CFG(0x0, 0x18, 0x411111f0),
+ /* + * Pin Complex (NID 0x19) MIC2 PORTF + * group 1, cap 1 + * black, jack detect + * mic in, analog + * connector, left panel + */ + AZALIA_PIN_CFG(0x0, 0x19, 0x03a71011), + /* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
/* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */ AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
- /* Pin Complex (NID 0x1d) PCBeep */ - // eapd low on ex-amp, laptop, custom enable - // mute spkr on hpout - // pcbeep en able, checksum - // no physical, internal + /* + * Pin Complex (NID 0x1d) PCBeep + * eapd low on ex-amp, laptop, custom enable + * mute spkr on hpout + * pcbeep en able, checksum + * no physical, internal + */ AZALIA_PIN_CFG(0x0, 0x1d, 0x4015812d),
/* Pin Complex (NID 0x1E) SPDIF-OUT - Disabled */ AZALIA_PIN_CFG(0x0, 0x1e, 0x411111f0),
- /* Pin Complex (NID 0x21) HPOUT PORT-I */ - // group1, - // black, jack detect - // HPOut, 1/8 stereo - // connector, left panel + /* + * Pin Complex (NID 0x21) HPOUT PORT-I + * group1, + * black, jack detect + * HPOut, 1/8 stereo + * connector, left panel + */ AZALIA_PIN_CFG(0x0, 0x21, 0x0321101f),
/* Undocumented settings from Realtek (needed for beep_gen) */ @@ -85,7 +87,7 @@
/* Tuned jack detection */ 0x02050043, - 0x0204A614, + 0x0204a614, 0x02050047, 0x02049470, }; @@ -99,6 +101,4 @@ 0x00b37410, /* unmute mixer nid 0xb beep input and set volume */ };
- -#endif /* HDA_VERB_H */ AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/google/butterfly/hda_verb.c b/src/mainboard/google/butterfly/hda_verb.c index 231c188..85f2859 100644 --- a/src/mainboard/google/butterfly/hda_verb.c +++ b/src/mainboard/google/butterfly/hda_verb.c @@ -17,10 +17,10 @@
const u32 cim_verb_data[] = { /* --- Codec #0 --- */ - 0x111d76e5, // Codec Vendor / Device ID: IDT 92HD99 - 0x103c18f9, // Subsystem ID - 115, // Number of 4 dword sets - AZALIA_SUBVENDOR(0x0, 0x103c18F9), + 0x111d76e5, /* Codec Vendor / Device ID: IDT 92HD99 */ + 0x103c18f9, /* Subsystem ID */ + 115, /* Number of 4 dword sets */ + AZALIA_SUBVENDOR(0x0, 0x103c18f9),
/* Ext. Microphone Connector: External,Right; MicIn,3.5mm; Black,JD; DA,Seq */ AZALIA_PIN_CFG(0x0, 0x0a, 0x04a11020), @@ -163,18 +163,16 @@ 0x00b707c0, /* Enable PortB as Output with HP amp */ 0x00d70740, /* Enable PortD as Output */ 0x0017a200, /* Disable ClkEn of PortSenseTst */ - 0x0017c621, /* Slave Port - Port A used as microphone input for - combo Jack + 0x0017c621, /* Slave Port - Port A used as microphone input for combo Jack Master Port - Port B used for Jack Presence Detect Enable Combo Jack Detection */ 0x0017a208, /* Enable ClkEn of PortSenseTst */ 0x00170500, /* Set power state to D0 */
/* --- Codec #3 --- */ - 0x80862806, // Codec Vendor / Device ID: Intel PantherPoint HDMI - 0x80860101, // Subsystem ID - // Revision ID: 0x100000 - 4, // Number of 4 dword sets + 0x80862806, /* Codec Vendor / Device ID: Intel PantherPoint HDMI */ + 0x80860101, /* Subsystem ID */ + 4, /* Number of 4 dword sets */ AZALIA_SUBVENDOR(0x3, 0x80860101), AZALIA_PIN_CFG(0x3, 0x05, 0x18560010), AZALIA_PIN_CFG(0x3, 0x06, 0x18560020), diff --git a/src/mainboard/google/drallion/variants/drallion/include/variant/hda_verb.h b/src/mainboard/google/drallion/variants/drallion/include/variant/hda_verb.h index 10fbaf1..e502760 100644 --- a/src/mainboard/google/drallion/variants/drallion/include/variant/hda_verb.h +++ b/src/mainboard/google/drallion/variants/drallion/include/variant/hda_verb.h @@ -19,14 +19,14 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0295, // Codec Vendor / Device ID: Realtek ALC3204 - 0xffffffff, // Subsystem ID - 0x0000002b, // Number of jacks (NID entries) + 0x10ec0295, /* Codec Vendor / Device ID: Realtek ALC3204 */ + 0xffffffff, /* Subsystem ID */ + 43, /* Number of jacks (NID entries) */
- /* Rest Codec First */ + /* Reset Codec First */ AZALIA_RESET(0x1), - /* NID 0x01, HDA Codec Subsystem ID Verb Table */ + + /* HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x102808b6),
/* Pin Widget Verb Table */ @@ -44,164 +44,192 @@ AZALIA_PIN_CFG(0x0, 0x21, 0x04211020),
/* D reset */ - 0x0205003C, - 0x0204F254, - 0x0205003C, - 0x0204F214, + 0x0205003c, + 0x0204f254, + 0x0205003c, + 0x0204f214, + /* JD1 - 2port JD mode */ 0x02050009, - 0x0204E003, - 0x0205000A, + 0x0204e003, + 0x0205000a, 0x02047770, + /* Set TRS type-1 */ 0x02050045, 0x02045289, 0x02050049, 0x02040049, - /* Set TRS type-2 + Set UAJ Line2 vref(ALC3254) */ - 0x0205004A, - 0x0204A830, + + /* Set TRS type-2 + Set UaJ Line2 vref(ALC3254) */ + 0x0205004a, + 0x0204a830, 0x02050063, - 0x0204CF00, - /* NID 0x20 set class-D to 2W@4ohm (+12dB gain) - * + Set sine tone gain(0x34) */ + 0x0204cf00, + + /* NID 0x20 set class-D to 2W@4ohm (+12db gain) + Set sine tone gain(0x34) */ 0x02050038, 0x02043909, - 0x05C50000, - 0x05C43482, - /* AGC-1 Disable + (Front Gain=0dB ) */ - 0x05D50006, - 0x05D44C50, - 0x05D50002, - 0x05D44004, - /* AGC-2 (Backt Boost Gain= -0.375dB ,Limiter = -3dB) */ - 0x05D50003, - 0x05D45E5E, - 0x05D50001, - 0x05D4D788, + 0x05c50000, + 0x05c43482, + + /* AGC-1 disable + (front Gain: 0db) */ + 0x05d50006, + 0x05d44c50, + 0x05d50002, + 0x05d44004, + + /* AGC-2 (back boost Gain: -0.375db, Limiter: -3db) */ + 0x05d50003, + 0x05d45e5e, + 0x05d50001, + 0x05d4d788, + /* AGC-3 + AGC Enable */ - 0x05D50009, - 0x05D451FF, - 0x05D50006, - 0x05D44E50, + 0x05d50009, + 0x05d451ff, + 0x05d50006, + 0x05d44e50, + /* HP-JD Enable +Nokia type */ - 0x0205004A, + 0x0205004a, 0x02042010, 0x02050008, - 0x02046A0C, - /* EAPD set to verb-control + I2C Un-use+ DVDD3.3V */ + 0x02046a0c, + + /* EAPD set to verb-control + I2c Un-use+ dVdd3.3V */ 0x02050010, 0x02040020, 0x02050034, - 0x0204A23D, - /* Class D silent detection Enable -84dB threshold */ + 0x0204a23d, + + /* Class D silent detection Enable -84db threshold */ 0x02050030, 0x02049000, 0x02050037, - 0x0204FE15, - /* Disable EQ + set 250Hz 3rd High Pass filter */ + 0x0204fe15, + + /* disable eQ + set 250Hz 3rd High Pass filter */ 0x05350000, - 0x0534203A, + 0x0534203a, 0x05350000, - 0x0534203A, + 0x0534203a, + /* Left Channel-1 */ 0x0535001d, 0x05340800, 0x0535001e, 0x05340800, + /* Left Channel-2 */ 0x05350003, - 0x05341EF8, + 0x05341ef8, 0x05350004, 0x05340000, + /* Left Channel-3 */ 0x05350005, - 0x053403EE, + 0x053403ee, 0x05350006, - 0x0534FA60, + 0x0534fa60, + /* Left Channel-4 */ 0x05350007, - 0x05341E10, + 0x05341e10, 0x05350008, - 0x05347B86, + 0x05347b86, + /* Left Channel-5 */ 0x05350009, - 0x053401F7, - 0x0535000A, - 0x05349FB6, + 0x053401f7, + 0x0535000a, + 0x05349fb6, + /* Left Channel-6 */ - 0x0535000B, - 0x05341C00, - 0x0535000C, + 0x0535000b, + 0x05341c00, + 0x0535000c, 0x05340000, + /* Left Channel-7 */ - 0x0535000D, + 0x0535000d, 0x05340200, - 0x0535000E, + 0x0535000e, 0x05340000, + /* Right Channel-1 */ 0x05450000, 0x05442000, 0x0545001d, 0x05440800, + /* Right Channel-2 */ 0x0545001e, 0x05440800, 0x05450003, - 0x05441EF8, + 0x05441ef8, + /* Right Channel-3 */ 0x05450004, 0x05440000, 0x05450005, - 0x054403EE, + 0x054403ee, + /* Right Channel-4 */ 0x05450006, - 0x0544FA60, + 0x0544fa60, 0x05450007, - 0x05441E10, + 0x05441e10, + /* Right Channel-5 */ 0x05450008, - 0x05447B86, + 0x05447b86, 0x05450009, - 0x054401F7, + 0x054401f7, + /* Right Channel-6 */ - 0x0545000A, - 0x05449FB6, - 0x0545000B, - 0x05441C00, + 0x0545000a, + 0x05449fb6, + 0x0545000b, + 0x05441c00, + /* Right Channel-7 */ - 0x0545000C, + 0x0545000c, 0x05440000, - 0x0545000D, + 0x0545000d, 0x05440200, + /* Right Channel-8 + EQ Update & Enable */ - 0x0545000E, + 0x0545000e, 0x05440000, 0x05350000, - 0x0534E03A, + 0x0534e03a, + /* Enable all Microphone */ - 0x0205000D, - 0x0204A023, - 0x0205000D, - 0x0204A023, + 0x0205000d, + 0x0204a023, + 0x0205000d, + 0x0204a023, + /* Enable Internal Speaker (NID14) */ - 0x0205000F, + 0x0205000f, 0x02040000, - 0x0205000F, + 0x0205000f, 0x02040000, };
const u32 pc_beep_verbs[] = { /* PCBeep pass through to NID14 for ePSA test-1 */ 0x02050036, - 0x020477D7, - 0x0143B000, + 0x020477d7, + 0x0143b000, 0x01470740, + /* PCBeep pass through to NID14 for ePSA test-2 */ - 0x01470C02, - 0x01470C02, - 0x01470C02, - 0x01470C02, + 0x01470c02, + 0x01470c02, + 0x01470c02, + 0x01470c02, };
AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/google/jecht/hda_verb.c b/src/mainboard/google/jecht/hda_verb.c index 01ba78f..3e031c0 100644 --- a/src/mainboard/google/jecht/hda_verb.c +++ b/src/mainboard/google/jecht/hda_verb.c @@ -16,15 +16,14 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0283, // Codec Vendor / Device ID: Realtek ALC283 - 0x10ec0283, // Subsystem ID - 0x0000000e, // Number of jacks (NID entries) + 0x10ec0283, /* Codec Vendor / Device ID: Realtek ALC283 */ + 0x10ec0283, /* Subsystem ID */ + 14, /* Number of jacks (NID entries) */
- 0x0017ff00, // Function Reset - 0x0017ff00, // Double Function Reset - 0x000F0000, // Pad - get vendor id - 0x000F0002, // Pad - get revision id + 0x0017ff00, /* Function Reset */ + 0x0017ff00, /* Double Function Reset */ + 0x000f0000, /* Pad - get vendor id */ + 0x000f0002, /* Pad - get revision id */
/* NID 0x01, HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x11790670), @@ -40,11 +39,13 @@ /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0x0, 0x17, 0x411111f0),
- /* Pin Complex (NID 0x18) MIC1 PORTB */ - // group 1, cap 1 - // black, jack detect - // mic in, analog - // connector, left panel + /* + * Pin Complex (NID 0x18) MIC1 PORTB + * group 1, cap 1 + * black, jack detect + * mic in, analog + * connector, left panel + */ AZALIA_PIN_CFG(0x0, 0x18, 0x03a71011),
/* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ @@ -56,21 +57,25 @@ /* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */ AZALIA_PIN_CFG(0x0, 0x1B, 0x411111f0),
- /* Pin Complex (NID 0x1D) PCBeep */ - // eapd low on ex-amp, laptop, custom enable - // mute spkr on hpout - // pcbeep en able, checksum - // no physical, internal + /* + * Pin Complex (NID 0x1D) PCBeep + * eapd low on ex-amp, laptop, custom enable + * mute spkr on hpout + * pcbeep en able, checksum + * no physical, internal + */ AZALIA_PIN_CFG(0x0, 0x1D, 0x4015812d),
/* Pin Complex (NID 0x1E) SPDIF-OUT - Disabled */ AZALIA_PIN_CFG(0x0, 0x1E, 0x411111f0),
- /* Pin Complex (NID 0x21) HPOUT PORT-I */ - // group1, - // black, jack detect - // HPOut, 1/8 stereo - // connector, left panel + /* + * Pin Complex (NID 0x21) HPOUT PORT-I + * group1, + * black, jack detect + * HPOut, 1/8 stereo + * connector, left panel + */ AZALIA_PIN_CFG(0x0, 0x21, 0x0321101f),
/* Undocumented settings from Realtek (needed for beep_gen) */ @@ -82,7 +87,7 @@
/* Tuned jack detection */ 0x02050043, - 0x0204A614, + 0x0204a614, 0x02050047, 0x02049470, }; diff --git a/src/mainboard/google/link/hda_verb.c b/src/mainboard/google/link/hda_verb.c index b824f0f..0c31b07 100644 --- a/src/mainboard/google/link/hda_verb.c +++ b/src/mainboard/google/link/hda_verb.c @@ -16,13 +16,12 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x11020011, // Codec Vendor / Device ID: Creative CA0132 - 0x144dc0c2, // Subsystem ID - 0x00000014, // Number of jacks + Number of Malcolm setup blocks. + /* --- Codec #0 --- */ + 0x11020011, /* Codec Vendor / Device ID: Creative CA0132 */ + 0x144dc0c2, /* Subsystem ID */ + 20, /* Number of jacks + Number of Malcolm setup blocks. */
/* Malcolm Setup */ - 0x01570d09, 0x01570c23, 0x01570a01, @@ -75,10 +74,10 @@
/* Pin Widget Verb Table */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x144DC0C2 */ + /* NID 0x01, HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x144dc0c2),
- /* Pin Complex (NID 0x0B) Port-G Analog Unknown Speaker at Int N/A */ + /* Pin Complex (NID 0x0B) Port-G Analog Unknown Speaker at Int N/A */ AZALIA_PIN_CFG(0x0, 0x0b, 0x901700f0),
/* Pin Complex (NID 0x0C) N/C */ @@ -105,12 +104,12 @@ /* Pin Complex (NID 0x13) What you hear */ AZALIA_PIN_CFG(0x0, 0x13, 0x90d600f0),
- /* coreboot specific header */ - 0x80862806, // Codec Vendor / Device ID: Intel CougarPoint HDMI - 0x80860101, // Subsystem ID - 0x00000004, // Number of jacks + /* --- Codec #3 --- */ + 0x80862806, /* Codec Vendor / Device ID: Intel CougarPoint HDMI */ + 0x80860101, /* Subsystem ID */ + 4, /* Number of jacks */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ + /* NID 0x01, HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x3, 0x80860101),
/* Pin Complex (NID 0x05) Digital Out at Int HDMI */ @@ -123,14 +122,14 @@ AZALIA_PIN_CFG(0x3, 0x07, 0x18560030) };
- const u32 pc_beep_verbs[] = { - 0x00170500, /* power up codec */ - 0x00270500, /* power up DAC */ - 0x00b70500, /* power up speaker */ - 0x00b70740, /* enable speaker out */ - 0x00b78d00, /* enable EAPD pin */ - 0x00b70c02, /* set EAPD pin */ - 0x0143b013, /* beep volume */ + 0x00170500, /* power up codec */ + 0x00270500, /* power up DAC */ + 0x00b70500, /* power up speaker */ + 0x00b70740, /* enable speaker out */ + 0x00b78d00, /* enable EAPD pin */ + 0x00b70c02, /* set EAPD pin */ + 0x0143b013, /* beep volume */ }; + AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/google/parrot/hda_verb.c b/src/mainboard/google/parrot/hda_verb.c index e0454c7..12d49ff 100644 --- a/src/mainboard/google/parrot/hda_verb.c +++ b/src/mainboard/google/parrot/hda_verb.c @@ -31,11 +31,10 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0269, // Codec Vendor / Device ID: Realtek ALC269 - 0x10250742, // Subsystem ID - 0x0000000E, // Number of jacks (NID entries) - + /* --- Codec #0 --- */ + 0x10ec0269, /* Codec Vendor / Device ID: Realtek ALC269 */ + 0x10250742, /* Subsystem ID */ + 14, /* Number of jacks (NID entries) */
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x10250742 */ AZALIA_SUBVENDOR(0x0, 0x10250742), @@ -45,11 +44,13 @@ /* Pin Complex (NID 0x12) DMIC */ AZALIA_PIN_CFG(0x0, 0x12, 0x411111f0),
- /* Pin Complex (NID 0x14) SPKR-OUT PORTD */ - // group 1, front left/right - // no connector, no jack detect - // speaker out, analog - // fixed function, internal + /* + * Pin Complex (NID 0x14) SPKR-OUT PORTD + * group 1, front left/right + * no connector, no jack detect + * speaker out, analog + * fixed function, internal + */ AZALIA_PIN_CFG(0x0, 0x14, 0x90170110),
/* Pin Complex (NID 0x17) */ @@ -58,38 +59,46 @@ /* Pin Complex (NID 0x18) MIC1 PORTB */ AZALIA_PIN_CFG(0x0, 0x18, 0x411111f0),
- /* Pin Complex (NID 0x19) MIC2 PORTF */ - // group 2, cap 1 - // black, jack detect - // mic in, analog - // connector, right panel + /* + * Pin Complex (NID 0x19) MIC2 PORTF + * group 2, cap 1 + * black, jack detect + * mic in, analog + * connector, right panel + */ AZALIA_PIN_CFG(0x0, 0x19, 0x04a71021),
- /* Pin Complex (NID 0x1A) LINE1 PORTC */ + /* Pin Complex (NID 0x1a) LINE1 PORTC */ AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
- /* Pin Complex (NID 0x1B) LINE2 PORTE */ - // group 2, cap 0 - // no connector, no jack detect - // mic in, analog - // fixed function, internal + /* + * Pin Complex (NID 0x1B) LINE2 PORTE + * group 2, cap 0 + * no connector, no jack detect + * mic in, analog + * fixed function, internal + */ AZALIA_PIN_CFG(0x0, 0x1b, 0x90a70120),
- /* Pin Complex (NID 0x1d) PCBeep */ - // eapd low on ex-amp, laptop, custom enable - // mute spkr on hpout - // pcbeep en able, checksum - // no physical, internal + /* + * Pin Complex (NID 0x1d) PCBeep + * eapd low on ex-amp, laptop, custom enable + * mute spkr on hpout + * pcbeep en able, checksum + * no physical, internal + */ AZALIA_PIN_CFG(0x0, 0x1d, 0x4015812d),
- /* Pin Complex (NID 0x1E) SPDIF-OUT */ + /* Pin Complex (NID 0x1e) SPDIF-OUT */ AZALIA_PIN_CFG(0x0, 0x1e, 0x411111f0),
- /* Pin Complex (NID 0x21) HPOUT PORTA? */ - // group1, - // black, jack detect - // HPOut, 1/8 stereo - // connector, right panel + /* + * Pin Complex (NID 0x21) HPOUT PORTA? + * group1, + * black, jack detect + * HPOut, 1/8 stereo + * connector, right panel + */ AZALIA_PIN_CFG(0x0, 0x21, 0x0421101f),
/* Undocumented speaker output volume settings from Compal and Realtek */ @@ -100,32 +109,24 @@ 0x02041901,
0x02050002, - 0x0204AAB8, - 0x0205000D, + 0x0204aab8, + 0x0205000d, 0x02044440,
0x02050008, 0x02040300, 0x02050017, - 0x020400AF, + 0x020400af,
- /* --- Next Codec --- */ - - /* coreboot specific header */ - 0x80862806, // Codec Vendor / Device ID: Intel PantherPoint HDMI - 0x80860101, // Subsystem ID - 0x00000004, // Number of jacks + /* --- Codec #3 --- */ + 0x80862806, /* Codec Vendor / Device ID: Intel PantherPoint HDMI */ + 0x80860101, /* Subsystem ID */ + 4, /* Number of jacks */
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ AZALIA_SUBVENDOR(0x0, 0x80860101), - - /* Pin Complex (NID 0x05) Digital Out at Int HDMI */ AZALIA_PIN_CFG(0x3, 0x05, 0x18560010), - - /* Pin Complex (NID 0x06) Digital Out at Int HDMI */ AZALIA_PIN_CFG(0x3, 0x06, 0x18560020), - - /* Pin Complex (NID 0x07) Digital Out at Int HDMI */ AZALIA_PIN_CFG(0x3, 0x07, 0x18560030) };
diff --git a/src/mainboard/google/sarien/variants/arcada/include/variant/hda_verb.h b/src/mainboard/google/sarien/variants/arcada/include/variant/hda_verb.h index 10fbaf1..e502760 100644 --- a/src/mainboard/google/sarien/variants/arcada/include/variant/hda_verb.h +++ b/src/mainboard/google/sarien/variants/arcada/include/variant/hda_verb.h @@ -19,14 +19,14 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0295, // Codec Vendor / Device ID: Realtek ALC3204 - 0xffffffff, // Subsystem ID - 0x0000002b, // Number of jacks (NID entries) + 0x10ec0295, /* Codec Vendor / Device ID: Realtek ALC3204 */ + 0xffffffff, /* Subsystem ID */ + 43, /* Number of jacks (NID entries) */
- /* Rest Codec First */ + /* Reset Codec First */ AZALIA_RESET(0x1), - /* NID 0x01, HDA Codec Subsystem ID Verb Table */ + + /* HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x102808b6),
/* Pin Widget Verb Table */ @@ -44,164 +44,192 @@ AZALIA_PIN_CFG(0x0, 0x21, 0x04211020),
/* D reset */ - 0x0205003C, - 0x0204F254, - 0x0205003C, - 0x0204F214, + 0x0205003c, + 0x0204f254, + 0x0205003c, + 0x0204f214, + /* JD1 - 2port JD mode */ 0x02050009, - 0x0204E003, - 0x0205000A, + 0x0204e003, + 0x0205000a, 0x02047770, + /* Set TRS type-1 */ 0x02050045, 0x02045289, 0x02050049, 0x02040049, - /* Set TRS type-2 + Set UAJ Line2 vref(ALC3254) */ - 0x0205004A, - 0x0204A830, + + /* Set TRS type-2 + Set UaJ Line2 vref(ALC3254) */ + 0x0205004a, + 0x0204a830, 0x02050063, - 0x0204CF00, - /* NID 0x20 set class-D to 2W@4ohm (+12dB gain) - * + Set sine tone gain(0x34) */ + 0x0204cf00, + + /* NID 0x20 set class-D to 2W@4ohm (+12db gain) + Set sine tone gain(0x34) */ 0x02050038, 0x02043909, - 0x05C50000, - 0x05C43482, - /* AGC-1 Disable + (Front Gain=0dB ) */ - 0x05D50006, - 0x05D44C50, - 0x05D50002, - 0x05D44004, - /* AGC-2 (Backt Boost Gain= -0.375dB ,Limiter = -3dB) */ - 0x05D50003, - 0x05D45E5E, - 0x05D50001, - 0x05D4D788, + 0x05c50000, + 0x05c43482, + + /* AGC-1 disable + (front Gain: 0db) */ + 0x05d50006, + 0x05d44c50, + 0x05d50002, + 0x05d44004, + + /* AGC-2 (back boost Gain: -0.375db, Limiter: -3db) */ + 0x05d50003, + 0x05d45e5e, + 0x05d50001, + 0x05d4d788, + /* AGC-3 + AGC Enable */ - 0x05D50009, - 0x05D451FF, - 0x05D50006, - 0x05D44E50, + 0x05d50009, + 0x05d451ff, + 0x05d50006, + 0x05d44e50, + /* HP-JD Enable +Nokia type */ - 0x0205004A, + 0x0205004a, 0x02042010, 0x02050008, - 0x02046A0C, - /* EAPD set to verb-control + I2C Un-use+ DVDD3.3V */ + 0x02046a0c, + + /* EAPD set to verb-control + I2c Un-use+ dVdd3.3V */ 0x02050010, 0x02040020, 0x02050034, - 0x0204A23D, - /* Class D silent detection Enable -84dB threshold */ + 0x0204a23d, + + /* Class D silent detection Enable -84db threshold */ 0x02050030, 0x02049000, 0x02050037, - 0x0204FE15, - /* Disable EQ + set 250Hz 3rd High Pass filter */ + 0x0204fe15, + + /* disable eQ + set 250Hz 3rd High Pass filter */ 0x05350000, - 0x0534203A, + 0x0534203a, 0x05350000, - 0x0534203A, + 0x0534203a, + /* Left Channel-1 */ 0x0535001d, 0x05340800, 0x0535001e, 0x05340800, + /* Left Channel-2 */ 0x05350003, - 0x05341EF8, + 0x05341ef8, 0x05350004, 0x05340000, + /* Left Channel-3 */ 0x05350005, - 0x053403EE, + 0x053403ee, 0x05350006, - 0x0534FA60, + 0x0534fa60, + /* Left Channel-4 */ 0x05350007, - 0x05341E10, + 0x05341e10, 0x05350008, - 0x05347B86, + 0x05347b86, + /* Left Channel-5 */ 0x05350009, - 0x053401F7, - 0x0535000A, - 0x05349FB6, + 0x053401f7, + 0x0535000a, + 0x05349fb6, + /* Left Channel-6 */ - 0x0535000B, - 0x05341C00, - 0x0535000C, + 0x0535000b, + 0x05341c00, + 0x0535000c, 0x05340000, + /* Left Channel-7 */ - 0x0535000D, + 0x0535000d, 0x05340200, - 0x0535000E, + 0x0535000e, 0x05340000, + /* Right Channel-1 */ 0x05450000, 0x05442000, 0x0545001d, 0x05440800, + /* Right Channel-2 */ 0x0545001e, 0x05440800, 0x05450003, - 0x05441EF8, + 0x05441ef8, + /* Right Channel-3 */ 0x05450004, 0x05440000, 0x05450005, - 0x054403EE, + 0x054403ee, + /* Right Channel-4 */ 0x05450006, - 0x0544FA60, + 0x0544fa60, 0x05450007, - 0x05441E10, + 0x05441e10, + /* Right Channel-5 */ 0x05450008, - 0x05447B86, + 0x05447b86, 0x05450009, - 0x054401F7, + 0x054401f7, + /* Right Channel-6 */ - 0x0545000A, - 0x05449FB6, - 0x0545000B, - 0x05441C00, + 0x0545000a, + 0x05449fb6, + 0x0545000b, + 0x05441c00, + /* Right Channel-7 */ - 0x0545000C, + 0x0545000c, 0x05440000, - 0x0545000D, + 0x0545000d, 0x05440200, + /* Right Channel-8 + EQ Update & Enable */ - 0x0545000E, + 0x0545000e, 0x05440000, 0x05350000, - 0x0534E03A, + 0x0534e03a, + /* Enable all Microphone */ - 0x0205000D, - 0x0204A023, - 0x0205000D, - 0x0204A023, + 0x0205000d, + 0x0204a023, + 0x0205000d, + 0x0204a023, + /* Enable Internal Speaker (NID14) */ - 0x0205000F, + 0x0205000f, 0x02040000, - 0x0205000F, + 0x0205000f, 0x02040000, };
const u32 pc_beep_verbs[] = { /* PCBeep pass through to NID14 for ePSA test-1 */ 0x02050036, - 0x020477D7, - 0x0143B000, + 0x020477d7, + 0x0143b000, 0x01470740, + /* PCBeep pass through to NID14 for ePSA test-2 */ - 0x01470C02, - 0x01470C02, - 0x01470C02, - 0x01470C02, + 0x01470c02, + 0x01470c02, + 0x01470c02, + 0x01470c02, };
AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h b/src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h index 6eb6d14..2114ed3 100644 --- a/src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h +++ b/src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h @@ -19,14 +19,14 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0236, // Codec Vendor / Device ID: Realtek ALC3204 - 0xffffffff, // Subsystem ID - 0x0000001e, // Number of jacks (NID entries) + 0x10ec0236, /* Codec Vendor / Device ID: Realtek ALC3204 */ + 0xffffffff, /* Subsystem ID */ + 30, /* Number of jacks (NID entries) */
- /* Rest Codec First */ + /* Reset Codec First */ AZALIA_RESET(0x1), - /* NID 0x01, HDA Codec Subsystem ID Verb Table */ + + /* HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x102808b8),
/* Pin Widget Verb Table */ @@ -45,106 +45,123 @@ 0x02050040, 0x02049800, 0x02050034, - 0x0204023C, + 0x0204023c, + /* ALC3204 default-2 */ - 0x0205003C, + 0x0205003c, 0x02040354, - 0x0205003C, + 0x0205003c, 0x02040314, - /* ALC3204 Speaker output power - 4 ohm 2W (+12dB gain) - * + Combo Jack TRS setting */ + + /* ALC3204 Speaker output power - 4 ohm 2W (+12dB gain) + Combo Jack TRS setting */ 0x02050038, 0x02043901, 0x02050045, 0x02045089, + /* H/W AGC setting-1 */ 0x02050016, - 0x02040C50, + 0x02040c50, 0x02050012, - 0x0204EBC2, + 0x0204ebc2, + /* H/W AGC setting-2 */ 0x02050013, 0x0204401D, 0x02050016, 0x02044E50, + /* Zero data + EAPD to verb-control */ 0x02050037, - 0x0204FE15, + 0x0204fe15, 0x02050010, 0x02040020, + /* Zero data */ 0x02050030, 0x02048000, 0x02050030, 0x02048000, + /* ALC3204 default-3 */ 0x05750003, - 0x05740DA3, + 0x05740da3, 0x02050046, 0x02040004, + /* ALC3204 default-4 */ - 0x0205001B, - 0x02040A4B, + 0x0205001b, + 0x02040a4b, 0x02050008, - 0x02046A6C, + 0x02046a6c, + /* JD1 */ 0x02050009, - 0x0204E003, - 0x0205000A, + 0x0204e003, + 0x0205000a, 0x02047770, - /* Microphone + Array MIC security Disable +ADC clock Enable */ - 0x0205000D, - 0x0204A020, + + /* Microphone + Array MIC security Disable + ADC clock Enable */ + 0x0205000d, + 0x0204a020, 0x02050005, 0x02040700, + /* Speaker Enable */ - 0x0205000C, - 0x020401EF, - 0x0205000C, - 0x020401EF, + 0x0205000c, + 0x020401ef, + 0x0205000c, + 0x020401ef, + /* EQ Bypass + EQ HPF cutoff 250Hz */ 0x05350000, - 0x0534201A, + 0x0534201a, 0x0535001d, 0x05340800, + /* EQ-2 */ 0x0535001e, 0x05340800, 0x05350003, - 0x05341EF8, + 0x05341ef8, + /* EQ-3 */ 0x05350004, 0x05340000, 0x05450000, 0x05442000, + /* EQ-4 */ 0x0545001d, 0x05440800, 0x0545001e, 0x05440800, + /* EQ-5 */ 0x05450003, - 0x05441EF8, + 0x05441ef8, 0x05450004, 0x05440000, + /* EQ Update */ 0x05350000, - 0x0534E01A, + 0x0534e01a, 0x05350000, - 0x0534E01A, + 0x0534e01a, };
const u32 pc_beep_verbs[] = { -/* PCBeep pass through to NID14 for ePSA test-1 */ + /* PCBeep pass through to NID14 for ePSA test-1 */ 0x02050036, 0x02047717, 0x02050036, 0x02047717, -/* PCBeep pass through to NID14 for ePSA test-2 */ + + /* PCBeep pass through to NID14 for ePSA test-2 */ 0x01470740, - 0x0143B000, - 0x01470C02, - 0x01470C02, + 0x0143b000, + 0x01470c02, + 0x01470c02, };
AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/google/slippy/variants/falco/hda_verb.c b/src/mainboard/google/slippy/variants/falco/hda_verb.c index 3d12d8a..f130420 100644 --- a/src/mainboard/google/slippy/variants/falco/hda_verb.c +++ b/src/mainboard/google/slippy/variants/falco/hda_verb.c @@ -16,15 +16,14 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0283, // Codec Vendor / Device ID: Realtek ALC283 - 0x10ec0283, // Subsystem ID - 0x0000000e, // Number of jacks (NID entries) + 0x10ec0283, /* Codec Vendor / Device ID: Realtek ALC283 */ + 0x10ec0283, /* Subsystem ID */ + 14, /* Number of jacks (NID entries) */
- 0x0017ff00, // Function Reset - 0x0017ff00, // Double Function Reset - 0x000F0000, // Pad - get vendor id - 0x000F0002, // Pad - get revision id + 0x0017ff00, /* Function Reset */ + 0x0017ff00, /* Double Function Reset */ + 0x000f0000, /* Pad - get vendor id */ + 0x000f0002, /* Pad - get revision id */
/* NID 0x01, HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x11790670), @@ -34,11 +33,13 @@ /* Pin Complex (NID 0x12) DMIC - interior mobile lid */ AZALIA_PIN_CFG(0x0, 0x12, 0xb7a60110),
- /* Pin Complex (NID 0x14) SPKR-OUT PORTD */ - // group 1, front left/right - // no connector, no jack detect - // speaker out, analog - // fixed function, internal + /* + * Pin Complex (NID 0x14) SPKR-OUT PORTD + * group 1, cap 0 + * no connector, no jack detect + * speaker out, analog + * fixed function, internal + */ AZALIA_PIN_CFG(0x0, 0x14, 0x90170110),
/* Pin Complex (NID 0x17) MONO Out - Disabled */ @@ -47,34 +48,40 @@ /* Pin Complex (NID 0x18) MIC1 PORTB - Disabled */ AZALIA_PIN_CFG(0x0, 0x18, 0x411111f0),
- /* Pin Complex (NID 0x19) MIC2 PORTF */ - // group 1, cap 1 - // black, jack detect - // mic in, analog - // connector, left panel + /* + * Pin Complex (NID 0x19) MIC2 PORTF + * group1, cap 1 + * black, jack detect + * mic in, analog + * connector, left panel + */ AZALIA_PIN_CFG(0x0, 0x19, 0x03a71011),
- /* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ + /* Pin Complex (NID 0x1a) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
- /* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */ + /* Pin Complex (NID 0x1b) LINE2 PORTE - Disabled */ AZALIA_PIN_CFG(0x0, 0x1b, 0x411111f0),
- /* Pin Complex (NID 0x1d) PCBeep */ - // eapd low on ex-amp, laptop, custom enable - // mute spkr on hpout - // pcbeep en able, checksum - // no physical, internal + /* + * Pin Complex (NID 0x1d) PCBeep + * eapd low on ex-amp, laptop, custom enable + * mute spkr on hpout + * pcbeep enable, checksum + * no physical, internal + */ AZALIA_PIN_CFG(0x0, 0x1d, 0x4015812d),
- /* Pin Complex (NID 0x1E) SPDIF-OUT - Disabled */ + /* Pin Complex (NID 0x1e) SPDIF-OUT - Disabled */ AZALIA_PIN_CFG(0x0, 0x1e, 0x411111f0),
- /* Pin Complex (NID 0x21) HPOUT PORT-I */ - // group1, - // black, jack detect - // HPOut, 1/8 stereo - // connector, left panel + /* + * Pin Complex (NID 0x21) HPOUT PORT-I + * group1, + * black, jack detect + * HPOut, 1/8 stereo + * connector, left panel + */ AZALIA_PIN_CFG(0x0, 0x21, 0x0321101f),
/* Undocumented settings from Realtek (needed for beep_gen) */ @@ -86,7 +93,7 @@
/* Tuned jack detection */ 0x02050043, - 0x0204A614, + 0x0204a614, 0x02050047, 0x02049470, }; diff --git a/src/mainboard/google/slippy/variants/leon/hda_verb.c b/src/mainboard/google/slippy/variants/leon/hda_verb.c index 39a5c78..00abada 100644 --- a/src/mainboard/google/slippy/variants/leon/hda_verb.c +++ b/src/mainboard/google/slippy/variants/leon/hda_verb.c @@ -16,15 +16,14 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0283, // Codec Vendor / Device ID: Realtek ALC283 - 0x10ec0283, // Subsystem ID - 0x0000000e, // Number of jacks (NID entries) + 0x10ec0283, /* Codec Vendor / Device ID: Realtek ALC283 */ + 0x10ec0283, /* Subsystem ID */ + 14, /* Number of jacks (NID entries) */
- 0x0017ff00, // Function Reset - 0x0017ff00, // Double Function Reset - 0x000F0000, // Pad - get vendor id - 0x000F0002, // Pad - get revision id + 0x0017ff00, /* Function Reset */ + 0x0017ff00, /* Double Function Reset */ + 0x000f0000, /* Pad - get vendor id */ + 0x000f0002, /* Pad - get revision id */
/* NID 0x01, HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x11790670), @@ -34,11 +33,13 @@ /* Pin Complex (NID 0x12) DMIC - Internal Mic */ AZALIA_PIN_CFG(0x0, 0x12, 0xb7a61010),
- /* Pin Complex (NID 0x14) SPKR-OUT - Internal Speakers */ - // group 1, cap 0 - // no connector, no jack detect - // speaker out, analog - // fixed function, internal + /* + * Pin Complex (NID 0x14) SPKR-OUT - Internal Speakers + * group 1, cap 0 + * no connector, no jack detect + * speaker out, analog + * fixed function, internal + */ AZALIA_PIN_CFG(0x0, 0x14, 0x90170110),
/* Pin Complex (NID 0x17) MONO Out - Disabled */ @@ -47,34 +48,40 @@ /* Pin Complex (NID 0x18) MIC1 PORTB - Disabled */ AZALIA_PIN_CFG(0x0, 0x18, 0x411111f0),
- /* Pin Complex (NID 0x19) MIC2 - 3.5mm Jack */ - // group2, cap 0 - // black, jack detect - // Mic in, 3.5mm Jack - // connector, External left panel + /* + * Pin Complex (NID 0x19) MIC2 - 3.5mm Jack + * group2, cap 0 + * black, jack detect + * Mic in, 3.5mm Jack + * connector, External left panel + */ AZALIA_PIN_CFG(0x0, 0x19, 0x03a11020),
- /* Pin Complex (NID 0x1A) LINE1 - Disabled */ + /* Pin Complex (NID 0x1a) LINE1 - Disabled */ AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
- /* Pin Complex (NID 0x1B) LINE2 - Disabled */ + /* Pin Complex (NID 0x1b) LINE2 - Disabled */ AZALIA_PIN_CFG(0x0, 0x1b, 0x411111f0),
- /* Pin Complex (NID 0x1D) PCBeep */ - // eapd low on ex-amp, laptop, custom enable - // mute spkr on hpout - // pcbeep en able, checksum - // no physical, Internal, Location N/A + /* + * Pin Complex (NID 0x1d) PCBeep + * eapd low on ex-amp, laptop, custom enable + * mute spkr on hpout + * pcbeep enable, checksum + * no physical, Internal, Location N/A + */ AZALIA_PIN_CFG(0x0, 0x1d, 0x4015812d),
- /* Pin Complex (NID 0x1E) SPDIF-OUT - Disabled*/ + /* Pin Complex (NID 0x1e) SPDIF-OUT - Disabled*/ AZALIA_PIN_CFG(0x0, 0x1e, 0x411111f0),
- /* Pin Complex (NID 0x21) HP-OUT - 3.5mm Jack*/ - // group2, cap 1 - // black, jack detect - // HPOut, 3.5mm Jack - // connector, left panel + /* + * Pin Complex (NID 0x21) HP-OUT - 3.5mm Jack + * group2, cap 1 + * black, jack detect + * HPOut, 3.5mm Jack + * connector, left panel + */ AZALIA_PIN_CFG(0x0, 0x21, 0x03211021),
/* Undocumented settings from Realtek (needed for beep_gen) */ @@ -86,7 +93,7 @@
/* Tuned jack detection */ 0x02050043, - 0x0204A614, + 0x0204a614, 0x02050047, 0x02049470, }; diff --git a/src/mainboard/google/slippy/variants/peppy/hda_verb.c b/src/mainboard/google/slippy/variants/peppy/hda_verb.c index a5ec9bb..f653d34 100644 --- a/src/mainboard/google/slippy/variants/peppy/hda_verb.c +++ b/src/mainboard/google/slippy/variants/peppy/hda_verb.c @@ -16,15 +16,14 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0283, // Codec Vendor / Device ID: Realtek ALC283 - 0x10ec0283, // Subsystem ID - 0x0000000e, // Number of jacks (NID entries) + 0x10ec0283, /* Codec Vendor / Device ID: Realtek ALC283 */ + 0x10ec0283, /* Subsystem ID */ + 14, /* Number of jacks (NID entries) */
- 0x0017ff00, // Function Reset - 0x0017ff00, // Double Function Reset - 0x000F0000, // Pad - get vendor id - 0x000F0002, // Pad - get revision id + 0x0017ff00, /* Function Reset */ + 0x0017ff00, /* Double Function Reset */ + 0x000f0000, /* Pad - get vendor id */ + 0x000f0002, /* Pad - get revision id */
/* NID 0x01, HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x11790670), @@ -34,11 +33,13 @@ /* Pin Complex (NID 0x12) DMIC - Disabled */ AZALIA_PIN_CFG(0x0, 0x12, 0x411111f0),
- /* Pin Complex (NID 0x14) SPKR-OUT - Internal Speakers */ - // group 1, cap 0 - // no connector, no jack detect - // speaker out, analog - // fixed function, internal, Location N/A + /* + * Pin Complex (NID 0x14) SPKR-OUT - Internal Speakers + * group 1, cap 0 + * no connector, no jack detect + * speaker out, analog + * fixed function, internal + */ AZALIA_PIN_CFG(0x0, 0x14, 0x90170110),
/* Pin Complex (NID 0x17) MONO Out - Disabled */ @@ -47,38 +48,46 @@ /* Pin Complex (NID 0x18) MIC1 PORTB - Disabled */ AZALIA_PIN_CFG(0x0, 0x18, 0x411111f0),
- /* Pin Complex (NID 0x19) MIC2 - 3.5mm Jack */ - // group2, cap 0 - // black, jack detect - // Mic in, 3.5mm Jack - // connector, External left panel + /* + * Pin Complex (NID 0x19) MIC2 - 3.5mm Jack + * group2, cap 0 + * black, jack detect + * Mic in, 3.5mm Jack + * connector, External left panel + */ AZALIA_PIN_CFG(0x0, 0x19, 0x03a11020),
- /* Pin Complex (NID 0x1A) LINE1 - Internal Mic */ - // group 1, cap 1 - // no connector, no jack detect - // mic in, analog connection - // Fixed function, internal, Location N/A + /* + * Pin Complex (NID 0x1a) LINE1 - Internal Mic + * group 1, cap 1 + * no connector, no jack detect + * mic in, analog connection + * Fixed function, internal, Location N/A + */ AZALIA_PIN_CFG(0x0, 0x1a, 0x90a70111),
- /* Pin Complex (NID 0x1B) LINE2 - Disabled */ + /* Pin Complex (NID 0x1b) LINE2 - Disabled */ AZALIA_PIN_CFG(0x0, 0x1b, 0x411111f0),
- /* Pin Complex (NID 0x1D) PCBeep */ - // eapd low on ex-amp, laptop, custom enable - // mute spkr on hpout - // pcbeep en able, checksum - // no physical, Internal, Location N/A + /* + * Pin Complex (NID 0x1d) PCBeep + * eapd low on ex-amp, laptop, custom enable + * mute spkr on hpout + * pcbeep enable, checksum + * no physical, Internal, Location N/A + */ AZALIA_PIN_CFG(0x0, 0x1d, 0x4015812d),
- /* Pin Complex (NID 0x1E) SPDIF-OUT - Disabled*/ + /* Pin Complex (NID 0x1e) SPDIF-OUT - Disabled*/ AZALIA_PIN_CFG(0x0, 0x1e, 0x411111f0),
- /* Pin Complex (NID 0x21) HP-OUT - 3.5mm Jack*/ - // group2, cap 1 - // black, jack detect - // HPOut, 3.5mm Jack - // connector, left panel + /* + * Pin Complex (NID 0x21) HP-OUT - 3.5mm Jack + * group2, cap 1 + * black, jack detect + * HPOut, 3.5mm Jack + * connector, left panel + */ AZALIA_PIN_CFG(0x0, 0x21, 0x03211021),
/* Undocumented settings from Realtek (needed for beep_gen) */ @@ -90,7 +99,7 @@
/* Tuned jack detection */ 0x02050043, - 0x0204A614, + 0x0204a614, 0x02050047, 0x02049470, }; diff --git a/src/mainboard/google/slippy/variants/wolf/hda_verb.c b/src/mainboard/google/slippy/variants/wolf/hda_verb.c index 56fe320..5024a1e 100644 --- a/src/mainboard/google/slippy/variants/wolf/hda_verb.c +++ b/src/mainboard/google/slippy/variants/wolf/hda_verb.c @@ -16,15 +16,14 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0283, // Codec Vendor / Device ID: Realtek ALC283 - 0x10ec0283, // Subsystem ID - 0x0000000e, // Number of jacks (NID entries) + 0x10ec0283, /* Codec Vendor / Device ID: Realtek ALC283 */ + 0x10ec0283, /* Subsystem ID */ + 14, /* Number of jacks (NID entries) */
- 0x0017ff00, // Function Reset - 0x0017ff00, // Double Function Reset - 0x000F0000, // Pad - get vendor id - 0x000F0002, // Pad - get revision id + 0x0017ff00, /* Function Reset */ + 0x0017ff00, /* Double Function Reset */ + 0x000f0000, /* Pad - get vendor id */ + 0x000f0002, /* Pad - get revision id */
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ @@ -39,11 +38,13 @@ /* Pin Complex (NID 0x12) DMIC - interior mobile lid */ AZALIA_PIN_CFG(0x0, 0x12, 0xb7a60110),
- /* Pin Complex (NID 0x14) SPKR-OUT - Internal Speakers */ - // group 1, cap 0 - // no connector, no jack detect - // speaker out, analog - // fixed function, internal, Location N/A + /* + * Pin Complex (NID 0x14) SPKR-OUT - Internal Speakers + * group 1, cap 0 + * no connector, no jack detect + * speaker out, analog + * fixed function, internal + */ AZALIA_PIN_CFG(0x0, 0x14, 0x90170110),
/* Pin Complex (NID 0x17) MONO Out - Disabled */ @@ -52,34 +53,40 @@ /* Pin Complex (NID 0x18) MIC1 PORTB - Disabled */ AZALIA_PIN_CFG(0x0, 0x18, 0x411111f0),
- /* Pin Complex (NID 0x19) MIC2 - 3.5mm Jack */ - // group2, cap 0 - // black, jack detect - // Mic in, 3.5mm Jack - // connector, External left panel + /* + * Pin Complex (NID 0x19) MIC2 - 3.5mm Jack + * group2, cap 0 + * black, jack detect + * Mic in, 3.5mm Jack + * connector, External left panel + */ AZALIA_PIN_CFG(0x0, 0x19, 0x03a11020),
- /* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ + /* Pin Complex (NID 0x1a) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
- /* Pin Complex (NID 0x1B) LINE2 - Disabled */ + /* Pin Complex (NID 0x1b) LINE2 - Disabled */ AZALIA_PIN_CFG(0x0, 0x1b, 0x411111f0),
- /* Pin Complex (NID 0x1D) PCBeep */ - // eapd low on ex-amp, laptop, custom enable - // mute spkr on hpout - // pcbeep en able, checksum - // no physical, Internal, Location N/A + /* + * Pin Complex (NID 0x1d) PCBeep + * eapd low on ex-amp, laptop, custom enable + * mute spkr on hpout + * pcbeep enable, checksum + * no physical, Internal, Location N/A + */ AZALIA_PIN_CFG(0x0, 0x1d, 0x4015812d),
- /* Pin Complex (NID 0x1E) SPDIF-OUT - Disabled*/ + /* Pin Complex (NID 0x1e) SPDIF-OUT - Disabled*/ AZALIA_PIN_CFG(0x0, 0x1e, 0x411111f0),
- /* Pin Complex (NID 0x21) HP-OUT - 3.5mm Jack*/ - // group2, cap 1 - // black, jack detect - // HPOut, 3.5mm Jack - // connector, left panel + /* + * Pin Complex (NID 0x21) HP-OUT - 3.5mm Jack + * group2, cap 1 + * black, jack detect + * HPOut, 3.5mm Jack + * connector, left panel + */ AZALIA_PIN_CFG(0x0, 0x21, 0x03211021),
/* Undocumented settings from Realtek (needed for beep_gen) */ @@ -91,7 +98,7 @@
/* Tuned jack detection */ 0x02050043, - 0x0204A614, + 0x0204a614, 0x02050047, 0x02049470, }; diff --git a/src/mainboard/google/stout/hda_verb.c b/src/mainboard/google/stout/hda_verb.c index 46ca274..30d234f 100644 --- a/src/mainboard/google/stout/hda_verb.c +++ b/src/mainboard/google/stout/hda_verb.c @@ -16,44 +16,44 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0269, // Codec Vendor / Device ID: Realtek - 0x17aa21fe, // Subsystem ID - 0x0000000c, // Number of jacks + /* --- Codec #0 --- */ + 0x10ec0269, /* Codec Vendor / Device ID: Realtek ALC269 */ + 0x17aa21fe, /* Subsystem ID */ + 12, /* Number of jacks */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x17aa21fe */ + /* NID 0x01, HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x17aa21fe),
/* Pin Widget Verb Table */
- /* Pin Complex (NID 0x12): 0x90a60930 DMIC */ + /* Pin Complex (NID 0x12): DMIC */ AZALIA_PIN_CFG(0x0, 0x12, 0x90a60930),
- /* Pin Complex (NID 0x14): 0x90170110 SPEAKER-OUT (Port-D) */ + /* Pin Complex (NID 0x14): SPEAKER-OUT (Port-D) */ AZALIA_PIN_CFG(0x0, 0x14, 0x90170110),
- /* Pin Complex (NID 0x15): 0x0321101f HP-OUT (Port-A) */ + /* Pin Complex (NID 0x15): HP-OUT (Port-A) */ AZALIA_PIN_CFG(0x0, 0x15, 0x0321101f),
- /* Pin Complex (NID 0x17): 0x411111f0 MONO-OUT (Port-H) */ + /* Pin Complex (NID 0x17): MONO-OUT (Port-H) */ AZALIA_PIN_CFG(0x0, 0x17, 0x411111f0),
- /* Pin Complex (NID 0x18): 0x03a11820 MIC1 (Port-B) */ + /* Pin Complex (NID 0x18): MIC1 (Port-B) */ AZALIA_PIN_CFG(0x0, 0x18, 0x03a11820),
- /* Pin Complex (NID 0x19): 0x411111f0 MIC2 (Port-F) */ + /* Pin Complex (NID 0x19): MIC2 (Port-F) */ AZALIA_PIN_CFG(0x0, 0x19, 0x411111f0),
- /* Pin Complex (NID 0x1a): 0x411111f0 LINE1 (Port-C) */ + /* Pin Complex (NID 0x1a): LINE1 (Port-C) */ AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
- /* Pin Complex (NID 0x1b): 0x411111f0 LINE2 (Port-E) */ + /* Pin Complex (NID 0x1b): LINE2 (Port-E) */ AZALIA_PIN_CFG(0x0, 0x1b, 0x411111f0),
- /* Pin Complex (NID 0x1d): 0x4016862d PC-BEEP */ + /* Pin Complex (NID 0x1d): PC-BEEP */ AZALIA_PIN_CFG(0x0, 0x1d, 0x4016862d),
- /* Pin Complex (NID 0x1e): 0x411111f0 S/PDIF-OUT */ + /* Pin Complex (NID 0x1e): S/PDIF-OUT */ AZALIA_PIN_CFG(0x0, 0x1e, 0x411111f0),
/* Stout MIC detect setup */ @@ -62,12 +62,12 @@ 0x02050008, 0x02040300,
- /* coreboot specific header */ - 0x80862806, // Codec Vendor / Device ID: Intel PantherPoint HDMI - 0x80860101, // Subsystem ID - 0x00000004, // Number of jacks + /* --- Codec #3 --- */ + 0x80862806, /* Codec Vendor / Device ID: Intel PantherPoint HDMI */ + 0x80860101, /* Subsystem ID */ + 4, /* Number of jacks */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ + /* NID 0x01, HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x3, 0x80860101),
/* Pin Complex (NID 0x05) Digital Out at Int HDMI */ diff --git a/src/mainboard/hp/8470p/hda_verb.c b/src/mainboard/hp/8470p/hda_verb.c index a24aeb2..78d49db 100644 --- a/src/mainboard/hp/8470p/hda_verb.c +++ b/src/mainboard/hp/8470p/hda_verb.c @@ -18,56 +18,27 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - 0x111d7605, /* Codec Vendor / Device ID: IDT */ - 0x103c17c2, /* Subsystem ID */ - - 11, /* Number of 4 dword sets */ - /* NID 0x01: Subsystem ID. */ + 0x111d7605, /* Codec Vendor / Device ID: IDT */ + 0x103c17c2, /* Subsystem ID */ + 11, /* Number of 4 dword sets */ AZALIA_SUBVENDOR(0x0, 0x103c17c2), - - /* NID 0x0a. */ AZALIA_PIN_CFG(0x0, 0x0a, 0x21011030), - - /* NID 0x0b. */ AZALIA_PIN_CFG(0x0, 0x0b, 0x0421101f), - - /* NID 0x0c. */ AZALIA_PIN_CFG(0x0, 0x0c, 0x04a11020), - - /* NID 0x0d. */ AZALIA_PIN_CFG(0x0, 0x0d, 0x90170110), - - /* NID 0x0e. */ AZALIA_PIN_CFG(0x0, 0x0e, 0x40f000f0), - - /* NID 0x0f. */ AZALIA_PIN_CFG(0x0, 0x0f, 0x2181102e), - - /* NID 0x10. */ AZALIA_PIN_CFG(0x0, 0x10, 0x40f000f0), - - /* NID 0x11. */ AZALIA_PIN_CFG(0x0, 0x11, 0xd5a30140), - - /* NID 0x1f. */ AZALIA_PIN_CFG(0x0, 0x1f, 0x40f000f0), - - /* NID 0x20. */ AZALIA_PIN_CFG(0x0, 0x20, 0x40f000f0), - 0x80862806, /* Codec Vendor / Device ID: Intel */ - 0x80860101, /* Subsystem ID */
- 4, /* Number of 4 dword sets */ - /* NID 0x01: Subsystem ID. */ + 0x80862806, /* Codec Vendor / Device ID: Intel */ + 0x80860101, /* Subsystem ID */ + 4, /* Number of 4 dword sets */ AZALIA_SUBVENDOR(0x3, 0x80860101), - - /* NID 0x05. */ AZALIA_PIN_CFG(0x3, 0x05, 0x18560010), - - /* NID 0x06. */ AZALIA_PIN_CFG(0x3, 0x06, 0x18560020), - - /* NID 0x07. */ AZALIA_PIN_CFG(0x3, 0x07, 0x18560030), };
diff --git a/src/mainboard/intel/baskingridge/hda_verb.c b/src/mainboard/intel/baskingridge/hda_verb.c index bee63f4..ea1a11c 100644 --- a/src/mainboard/intel/baskingridge/hda_verb.c +++ b/src/mainboard/intel/baskingridge/hda_verb.c @@ -16,16 +16,15 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10134210, // Codec Vendor / Device ID: Cirrus Logic CS4210 - 0x10134210, // Subsystem ID - 0x00000007, // Number of jacks + /* --- Codec #0 --- */ + 0x10134210, /* Codec Vendor / Device ID: Cirrus Logic CS4210 */ + 0x10134210, /* Subsystem ID */ + 7, /* Number of jacks */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x10134210 */ + /* HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x10134210),
/* Pin Widget Verb Table */ - /* Pin Complex (NID 0x05) 1/8 Gray HP Out at Ext Front */ AZALIA_PIN_CFG(0x0, 0x05, 0x022120f0),
@@ -44,13 +43,13 @@ /* Pin Complex (NID 0x0a) Optical Black SPDIF Out at Ext N/A */ AZALIA_PIN_CFG(0x0, 0x0a, 0x434510f0),
- /* coreboot specific header */ - 0x80862805, // Codec Vendor / Device ID: Intel CougarPoint HDMI - 0x80860101, // Subsystem ID - 0x00000004, // Number of jacks + /* --- Codec #3 --- */ + 0x80862805, /* Codec Vendor / Device ID: Intel CougarPoint HDMI */ + 0x80860101, /* Subsystem ID */ + 4, /* Number of jacks */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ - AZALIA_SUBVENDOR(0x0, 0x80860101), + /* HDA Codec Subsystem ID Verb Table */ + AZALIA_SUBVENDOR(0x3, 0x80860101),
/* Pin Complex (NID 0x05) Digital Out at Int HDMI */ AZALIA_PIN_CFG(0x3, 0x05, 0x18560010), diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/include/variant/hda_verb.h b/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/include/variant/hda_verb.h index f921f3f..bca9016 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/include/variant/hda_verb.h +++ b/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/include/variant/hda_verb.h @@ -20,20 +20,13 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - - /* - * VerbTable: CFL Display Audio Codec - * Revision ID = 0xFF - * Codec Vendor: 0x8086280B - */ - - 0x8086280B, - 0xFFFFFFFF, - 0x00000005, + 0x8086280b, /* Codec Vendor / Device ID: Intel CFL Display Audio */ + 0xffffffff, /* Subsystem ID */ + 5, /* Number of jacks */
/* * Display Audio Verb Table - * For GEN9, the Vendor Node ID is 08h + * For GEN9, the Vendor Node ID is 0x08 * Port to be exposed to the inbox driver in the vanilla mode * PORT C - BIT[7:6] = 01b */ @@ -41,147 +34,164 @@ 0x00878140, 0x00878140, 0x00878140, + /* Pin Widget 5 - PORT B - Configuration Default: 0x18560010 */ - 0x00571C10, - 0x00571D00, - 0x00571E56, - 0x00571F18, + 0x00571c10, + 0x00571d00, + 0x00571e56, + 0x00571f18, + /* Pin Widget 6 - PORT C - Configuration Default: 0x18560020 */ - 0x00671C20, - 0x00671D00, - 0x00671E56, - 0x00671F18, + 0x00671c20, + 0x00671d00, + 0x00671e56, + 0x00671f18, + /* Pin Widget 7 - PORT D - Configuration Default: 0x18560030 */ - 0x00771C30, - 0x00771D00, - 0x00771E56, - 0x00771F18, - /* Disable the third converter and third Pin (NID 08h) */ + 0x00771c30, + 0x00771d00, + 0x00771e56, + 0x00771f18, + + /* Disable the third converter and third pin (NID 0x08) */ 0x00878140, 0x00878140, 0x00878140, 0x00878140,
- /* ALC700 */ - 0x10EC0700, - 0xFFFFFFFF, - 0x00000015, + + + 0x10ec0700, /* Codec Vendor / Device ID: Realtek ALC700 */ + 0xffffffff, /* Subsystem ID */ + 21, /* Number of jacks */
/* * HDA Codec Subsystem ID Verb-table - * HDA Codec Subsystem ID : 0x10EC112C + * HDA Codec Subsystem ID : 0x10ec112c */ - 0x0017202C, + 0x0017202c, 0x00172111, - 0x001722EC, + 0x001722ec, 0x00172310,
/* * Pin Widget Verb-table * Widget node 0x01 */ - 0x0017FF00, - 0x0017FF00, - 0x0017FF00, - 0x0017FF00, + 0x0017ff00, + 0x0017ff00, + 0x0017ff00, + 0x0017ff00, + /* Pin widget 0x12 - DMIC */ - 0x01271C00, - 0x01271D00, - 0x01271E00, - 0x01271F40, + 0x01271c00, + 0x01271d00, + 0x01271e00, + 0x01271f40, + /* Pin widget 0x13 - DMIC */ - 0x01371CF0, - 0x01371D11, - 0x01371E11, - 0x01371F41, + 0x01371cf0, + 0x01371d11, + 0x01371e11, + 0x01371f41, + /* Pin widget 0x14 - FRONT (Port-D) */ - 0x01471CF0, - 0x01471D11, - 0x01471E11, - 0x01471F41, + 0x01471cf0, + 0x01471d11, + 0x01471e11, + 0x01471f41, + /* Pin widget 0x15 - I2S-OUT */ - 0x01571C10, - 0x01571D01, - 0x01571E17, - 0x01571F90, + 0x01571c10, + 0x01571d01, + 0x01571e17, + 0x01571f90, + /* Pin widget 0x16 - LINE3 (Port-B) */ - 0x01671C20, - 0x01671D10, - 0x01671E01, - 0x01671F01, + 0x01671c20, + 0x01671d10, + 0x01671e01, + 0x01671f01, + /* Pin widget 0x17 - I2S-OUT */ - 0x01771CF0, - 0x01771D11, - 0x01771E11, - 0x01771F41, + 0x01771cf0, + 0x01771d11, + 0x01771e11, + 0x01771f41, + /* Pin widget 0x18 - I2S-IN */ - 0x01871CF0, - 0x01871D11, - 0x01871E11, - 0x01871F41, - /* Pin widget 0x19 - MIC2 (Port-F) */ - 0x01971C30, - 0x01971D90, - 0x01971EA1, - 0x01971F02, - /* Pin widget 0x1A - LINE1 (Port-C) */ - 0x01A71CF0, - 0x01A71D11, - 0x01A71E11, - 0x01A71F41, - /* Pin widget 0x1B - LINE2 (Port-E) */ - 0x01B71C40, - 0x01B71D90, - 0x01B71EA1, - 0x01B71F01, - /* Pin widget 0x1D - PC-BEEP */ - 0x01D71C69, - 0x01D71D84, - 0x01D71E45, - 0x01D71F40, - /* Pin widget 0x1E - S/PDIF-OUT */ - 0x01E71CF0, - 0x01E71D11, - 0x01E71E11, - 0x01E71F41, - /* Pin widget 0x1F - S/PDIF-IN */ - 0x01F71CF0, - 0x01F71D11, - 0x01F71E11, - 0x01F71F41, + 0x01871cf0, + 0x01871d11, + 0x01871e11, + 0x01871f41, + + /* Pin widget 0x19 - MIc2 (Port-F) */ + 0x01971c30, + 0x01971d90, + 0x01971ea1, + 0x01971f02, + + /* Pin widget 0x1a - LINE1 (Port-C) */ + 0x01a71cf0, + 0x01a71d11, + 0x01a71e11, + 0x01a71f41, + + /* Pin widget 0x1b - LINe2 (Port-E) */ + 0x01b71c40, + 0x01b71d90, + 0x01b71ea1, + 0x01b71f01, + + /* Pin widget 0x1d - PC-BEEP */ + 0x01d71c69, + 0x01d71d84, + 0x01d71e45, + 0x01d71f40, + + /* Pin widget 0x1e - S/PDIF-OUT */ + 0x01e71cf0, + 0x01e71d11, + 0x01e71e11, + 0x01e71f41, + + /* Pin widget 0x1f - S/PDIF-IN */ + 0x01f71cf0, + 0x01f71d11, + 0x01f71e11, + 0x01f71f41, + /* Pin widget 0x21 - P-OUT (Port-I) */ - 0x02171C2F, - 0x02171D10, - 0x02171E21, - 0x02171F02, + 0x02171c2f, + 0x02171d10, + 0x02171e21, + 0x02171f02, + /* Pin widget 0x29 - I2S-IN */ - 0x02971CF0, - 0x02971D11, - 0x02971E11, - 0x02971F41, - /* - * Widget node 0x20 : MIC2-Vrefo-R and MIC2-vrefo-L - * to independent control - */ + 0x02971cf0, + 0x02971d11, + 0x02971e11, + 0x02971f41, + + /* Widget node 0x20 : Mic2-Vrefo-R and Mic2-Vrefo-L to independent control */ 0x02050045, 0x02045089, - 0x0205004A, - 0x0204201B, + 0x0205004a, + 0x0204201b, + /* Widget node 0x20 - 1 */ 0x05850000, 0x05843888, - 0x0205006F, - 0x02042C0B, - /* - * Widget node 0x20 - 2 : Line2-JD gating MIC2-Vrefo-R, - * P-JD gating MIC2-vrefo-L - */ - 0x0205006B, - 0x02044260, - 0x05B50010, - 0x05B45C1D, + 0x0205006f, + 0x02042c0b,
- /* Widget node 0X20 for ALC1305 */ + /* Widget node 0x20 - 2 : Line2-JD gating Mic2-Vrefo-R, P-JD gating Mic2-Vrefo-L */ + 0x0205006b, + 0x02044260, + 0x05b50010, + 0x05b45c1d, + + /* Widget node 0x20 for ALC1305 */ 0x02050024, 0x02040010, 0x02050026, @@ -189,7 +199,7 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
};
diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cfl_s/include/variant/hda_verb.h b/src/mainboard/intel/coffeelake_rvp/variants/cfl_s/include/variant/hda_verb.h index f921f3f..ec94002 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/cfl_s/include/variant/hda_verb.h +++ b/src/mainboard/intel/coffeelake_rvp/variants/cfl_s/include/variant/hda_verb.h @@ -20,20 +20,13 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - - /* - * VerbTable: CFL Display Audio Codec - * Revision ID = 0xFF - * Codec Vendor: 0x8086280B - */ - - 0x8086280B, - 0xFFFFFFFF, - 0x00000005, + 0x8086280b, /* Codec Vendor / Device ID: Intel CFL Display Audio */ + 0xffffffff, /* Subsystem ID */ + 5, /* Number of jacks */
/* * Display Audio Verb Table - * For GEN9, the Vendor Node ID is 08h + * For GEN9, the Vendor Node ID is 0x08 * Port to be exposed to the inbox driver in the vanilla mode * PORT C - BIT[7:6] = 01b */ @@ -41,147 +34,161 @@ 0x00878140, 0x00878140, 0x00878140, + /* Pin Widget 5 - PORT B - Configuration Default: 0x18560010 */ - 0x00571C10, - 0x00571D00, - 0x00571E56, - 0x00571F18, + 0x00571c10, + 0x00571d00, + 0x00571e56, + 0x00571f18, + /* Pin Widget 6 - PORT C - Configuration Default: 0x18560020 */ - 0x00671C20, - 0x00671D00, - 0x00671E56, - 0x00671F18, + 0x00671c20, + 0x00671d00, + 0x00671e56, + 0x00671f18, + /* Pin Widget 7 - PORT D - Configuration Default: 0x18560030 */ - 0x00771C30, - 0x00771D00, - 0x00771E56, - 0x00771F18, - /* Disable the third converter and third Pin (NID 08h) */ + 0x00771c30, + 0x00771d00, + 0x00771e56, + 0x00771f18, + + /* Disable the third converter and third pin (NID 0x08) */ 0x00878140, 0x00878140, 0x00878140, 0x00878140,
- /* ALC700 */ - 0x10EC0700, - 0xFFFFFFFF, - 0x00000015, + + + 0x10ec0700, /* Codec Vendor / Device ID: Realtek ALC700 */ + 0xffffffff, /* Subsystem ID */ + 21, /* Number of jacks */
/* * HDA Codec Subsystem ID Verb-table - * HDA Codec Subsystem ID : 0x10EC112C + * HDA Codec Subsystem ID : 0x10ec112c */ - 0x0017202C, + 0x0017202c, 0x00172111, - 0x001722EC, + 0x001722ec, 0x00172310,
- /* - * Pin Widget Verb-table - * Widget node 0x01 - */ - 0x0017FF00, - 0x0017FF00, - 0x0017FF00, - 0x0017FF00, + /* Pin Widget Verb-table */ + 0x0017ff00, + 0x0017ff00, + 0x0017ff00, + 0x0017ff00, + /* Pin widget 0x12 - DMIC */ - 0x01271C00, - 0x01271D00, - 0x01271E00, - 0x01271F40, + 0x01271c00, + 0x01271d00, + 0x01271e00, + 0x01271f40, + /* Pin widget 0x13 - DMIC */ - 0x01371CF0, - 0x01371D11, - 0x01371E11, - 0x01371F41, + 0x01371cf0, + 0x01371d11, + 0x01371e11, + 0x01371f41, + /* Pin widget 0x14 - FRONT (Port-D) */ - 0x01471CF0, - 0x01471D11, - 0x01471E11, - 0x01471F41, + 0x01471cf0, + 0x01471d11, + 0x01471e11, + 0x01471f41, + /* Pin widget 0x15 - I2S-OUT */ - 0x01571C10, - 0x01571D01, - 0x01571E17, - 0x01571F90, + 0x01571c10, + 0x01571d01, + 0x01571e17, + 0x01571f90, + /* Pin widget 0x16 - LINE3 (Port-B) */ - 0x01671C20, - 0x01671D10, - 0x01671E01, - 0x01671F01, + 0x01671c20, + 0x01671d10, + 0x01671e01, + 0x01671f01, + /* Pin widget 0x17 - I2S-OUT */ - 0x01771CF0, - 0x01771D11, - 0x01771E11, - 0x01771F41, + 0x01771cf0, + 0x01771d11, + 0x01771e11, + 0x01771f41, + /* Pin widget 0x18 - I2S-IN */ - 0x01871CF0, - 0x01871D11, - 0x01871E11, - 0x01871F41, - /* Pin widget 0x19 - MIC2 (Port-F) */ - 0x01971C30, - 0x01971D90, - 0x01971EA1, - 0x01971F02, - /* Pin widget 0x1A - LINE1 (Port-C) */ - 0x01A71CF0, - 0x01A71D11, - 0x01A71E11, - 0x01A71F41, - /* Pin widget 0x1B - LINE2 (Port-E) */ - 0x01B71C40, - 0x01B71D90, - 0x01B71EA1, - 0x01B71F01, - /* Pin widget 0x1D - PC-BEEP */ - 0x01D71C69, - 0x01D71D84, - 0x01D71E45, - 0x01D71F40, - /* Pin widget 0x1E - S/PDIF-OUT */ - 0x01E71CF0, - 0x01E71D11, - 0x01E71E11, - 0x01E71F41, - /* Pin widget 0x1F - S/PDIF-IN */ - 0x01F71CF0, - 0x01F71D11, - 0x01F71E11, - 0x01F71F41, + 0x01871cf0, + 0x01871d11, + 0x01871e11, + 0x01871f41, + + /* Pin widget 0x19 - Mic2 (Port-F) */ + 0x01971c30, + 0x01971d90, + 0x01971ea1, + 0x01971f02, + + /* Pin widget 0x1a - LINE1 (Port-C) */ + 0x01a71cf0, + 0x01a71d11, + 0x01a71e11, + 0x01a71f41, + + /* Pin widget 0x1b - LINe2 (Port-E) */ + 0x01b71c40, + 0x01b71d90, + 0x01b71ea1, + 0x01b71f01, + + /* Pin widget 0x1d - PC-BEEP */ + 0x01d71c69, + 0x01d71d84, + 0x01d71e45, + 0x01d71f40, + + /* Pin widget 0x1e - S/PDIF-OUT */ + 0x01e71cf0, + 0x01e71d11, + 0x01e71e11, + 0x01e71f41, + + /* Pin widget 0x1f - S/PDIF-IN */ + 0x01f71cf0, + 0x01f71d11, + 0x01f71e11, + 0x01f71f41, + /* Pin widget 0x21 - P-OUT (Port-I) */ - 0x02171C2F, - 0x02171D10, - 0x02171E21, - 0x02171F02, + 0x02171c2f, + 0x02171d10, + 0x02171e21, + 0x02171f02, + /* Pin widget 0x29 - I2S-IN */ - 0x02971CF0, - 0x02971D11, - 0x02971E11, - 0x02971F41, - /* - * Widget node 0x20 : MIC2-Vrefo-R and MIC2-vrefo-L - * to independent control - */ + 0x02971cf0, + 0x02971d11, + 0x02971e11, + 0x02971f41, + + /* Widget node 0x20 : Mic2-Vrefo-R and Mic2-Vrefo-L to independent control */ 0x02050045, 0x02045089, - 0x0205004A, - 0x0204201B, + 0x0205004a, + 0x0204201b, + /* Widget node 0x20 - 1 */ 0x05850000, 0x05843888, - 0x0205006F, - 0x02042C0B, - /* - * Widget node 0x20 - 2 : Line2-JD gating MIC2-Vrefo-R, - * P-JD gating MIC2-vrefo-L - */ - 0x0205006B, - 0x02044260, - 0x05B50010, - 0x05B45C1D, + 0x0205006f, + 0x02042c0b,
- /* Widget node 0X20 for ALC1305 */ + /* Widget node 0x20 - 2 : Line2-JD gating Mic2-Vrefo-R, P-JD gating Mic2-Vrefo-L */ + 0x0205006b, + 0x02044260, + 0x05b50010, + 0x05b45c1d, + + /* Widget node 0x20 for ALC1305 */ 0x02050024, 0x02040010, 0x02050026, @@ -189,12 +196,11 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, - + 0x0204b024, };
-const u32 pc_beep_verbs[] = { -}; +const u32 pc_beep_verbs[] = {};
AZALIA_ARRAY_SIZES; + #endif diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/include/variant/hda_verb.h b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/include/variant/hda_verb.h index 7a68625..0624c89 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/include/variant/hda_verb.h +++ b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/include/variant/hda_verb.h @@ -19,41 +19,41 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* ALC 700 */ - 0x10EC0700, - 0xFFFFFFFF, - 0x00000023, + 0x10ec0700, /* Codec Vendor / Device ID: Realtek ALC700 */ + 0xffffffff, /* Subsystem ID */ + 35, /* Number of jacks */
- AZALIA_SUBVENDOR(0, 0x10EC10F2), + AZALIA_SUBVENDOR(0, 0x10ec10f2), AZALIA_PIN_CFG(0, 0x01, 0x00000000), AZALIA_PIN_CFG(0, 0x12, 0x40000000), AZALIA_PIN_CFG(0, 0x13, 0x40000000), - AZALIA_PIN_CFG(0, 0x14, 0x411111F0), - AZALIA_PIN_CFG(0, 0x15, 0x411111F0), - AZALIA_PIN_CFG(0, 0x16, 0x411111F0), + AZALIA_PIN_CFG(0, 0x14, 0x411111f0), + AZALIA_PIN_CFG(0, 0x15, 0x411111f0), + AZALIA_PIN_CFG(0, 0x16, 0x411111f0), AZALIA_PIN_CFG(0, 0x17, 0x90170110), - AZALIA_PIN_CFG(0, 0x18, 0x411111F0), - AZALIA_PIN_CFG(0, 0x19, 0x04A11030), - AZALIA_PIN_CFG(0, 0x1A, 0x411111F0), - AZALIA_PIN_CFG(0, 0x1B, 0x411111F0), - AZALIA_PIN_CFG(0, 0x1D, 0x40622005), - AZALIA_PIN_CFG(0, 0x1E, 0x411111F0), - AZALIA_PIN_CFG(0, 0x1F, 0x411111F0), + AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x04a11030), + AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1b, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1d, 0x40622005), + AZALIA_PIN_CFG(0, 0x1e, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1f, 0x411111f0), AZALIA_PIN_CFG(0, 0x21, 0x04211020), - AZALIA_PIN_CFG(0, 0x29, 0x411111F0), + AZALIA_PIN_CFG(0, 0x29, 0x411111f0),
/* Widget node 0x20 */ 0x02050045, 0x02045289, - 0x0205004A, - 0x0204201B, + 0x0205004a, + 0x0204201b, + /* Widget node 0x20 - 1 */ 0x05850000, 0x05843888, - 0x0205006F, - 0x02042C0B, + 0x0205006f, + 0x02042c0b,
- //Widget node 0X20 for ALC1305 20160603 update + /* Widget node 0x20 for ALC1305 20160603 update */ 0x02050024, 0x02040010, 0x02050026, @@ -61,7 +61,7 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -70,16 +70,16 @@ 0x02050028, 0x02040600, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204003C, + 0x0204003c, 0x02050028, - 0x0204FFD0, + 0x0204ffd0, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -88,7 +88,7 @@ 0x02050028, 0x02040080, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -97,34 +97,34 @@ 0x02050028, 0x02040880, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204003A, + 0x0204003a, 0x02050028, - 0x02040DFE, + 0x02040dfe, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006A, + 0x0204006a, 0x02050028, - 0x0204005D, + 0x0204005d, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006C, + 0x0204006c, 0x02050028, 0x02040442, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -133,7 +133,7 @@ 0x02050028, 0x02040880, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -142,79 +142,79 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040008, 0x02050028, - 0x0204B000, + 0x0204b000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204002E, + 0x0204002e, 0x02050028, 0x02040800, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006A, + 0x0204006a, 0x02050028, - 0x020400C3, + 0x020400c3, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006C, + 0x0204006c, 0x02050028, - 0x0204D4A0, + 0x0204d4a0, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006A, + 0x0204006a, 0x02050028, - 0x020400CC, + 0x020400cc, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006C, + 0x0204006c, 0x02050028, - 0x0204400A, + 0x0204400a, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006A, + 0x0204006a, 0x02050028, - 0x020400C1, + 0x020400c1, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006C, + 0x0204006c, 0x02050028, 0x02040320, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -223,223 +223,223 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204003B, + 0x0204003b, 0x02050028, - 0x0204FFFF, + 0x0204ffff, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204003C, + 0x0204003c, 0x02050028, - 0x0204FC20, + 0x0204fc20, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204003A, + 0x0204003a, 0x02050028, - 0x02041DFE, + 0x02041dfe, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C0, + 0x020400c0, 0x02050028, - 0x020401FA, + 0x020401fa, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C1, + 0x020400c1, 0x02050028, - 0x0204DE23, + 0x0204de23, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C2, + 0x020400c2, 0x02050028, - 0x02041C00, + 0x02041c00, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C3, + 0x020400c3, 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C4, + 0x020400c4, 0x02050028, 0x02040200, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C5, + 0x020400c5, 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C6, + 0x020400c6, 0x02050028, - 0x020403F5, + 0x020403f5, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C7, + 0x020400c7, 0x02050028, - 0x0204AF1B, + 0x0204af1b, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C8, + 0x020400c8, 0x02050028, - 0x02041E0A, + 0x02041e0a, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C9, + 0x020400c9, 0x02050028, - 0x0204368E, + 0x0204368e, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400CA, + 0x020400ca, 0x02050028, - 0x020401FA, + 0x020401fa, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400CB, + 0x020400cb, 0x02050028, - 0x0204DE23, + 0x0204de23, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400CC, + 0x020400cc, 0x02050028, - 0x02041C00, + 0x02041c00, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400CD, + 0x020400cd, 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400CE, + 0x020400ce, 0x02050028, 0x02040200, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400CF, + 0x020400cf, 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400D0, + 0x020400d0, 0x02050028, - 0x020403F5, + 0x020403f5, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400D1, + 0x020400d1, 0x02050028, - 0x0204AF1B, + 0x0204af1b, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400D2, + 0x020400d2, 0x02050028, - 0x02041E0A, + 0x02041e0a, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400D3, + 0x020400d3, 0x02050028, - 0x0204368E, + 0x0204368e, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040040, 0x02050028, - 0x0204800F, + 0x0204800f, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -448,7 +448,7 @@ 0x02050028, 0x02048000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -457,7 +457,7 @@ 0x02050028, 0x02044848, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -466,7 +466,7 @@ 0x02050028, 0x02040800, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -475,7 +475,7 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -484,7 +484,7 @@ 0x02050028, 0x02044004, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -493,25 +493,25 @@ 0x02050028, 0x02040802, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040068, 0x02050028, - 0x0204890F, + 0x0204890f, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040069, 0x02050028, - 0x0204E021, + 0x0204e021, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -520,7 +520,7 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -529,7 +529,7 @@ 0x02050000, 0x02043330, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -538,7 +538,7 @@ 0x02050000, 0x02043333, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -547,7 +547,7 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -556,7 +556,7 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -565,7 +565,7 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -574,16 +574,16 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040050, 0x02050028, - 0x020402EC, + 0x020402ec, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -592,34 +592,34 @@ 0x02050028, 0x02044909, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040052, 0x02050028, - 0x020440B0, + 0x020440b0, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040046, 0x02050028, - 0x0204C22E, + 0x0204c22e, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040047, 0x02050028, - 0x02040C00, + 0x02040c00, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -628,7 +628,7 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -637,52 +637,52 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204004A, + 0x0204004a, 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204004B, + 0x0204004b, 0x02050028, - 0x02041C00, + 0x02041c00, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006A, + 0x0204006a, 0x02050028, 0x02040090, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006C, + 0x0204006c, 0x02050028, - 0x0204721F, + 0x0204721f, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204009E, + 0x0204009e, 0x02050028, 0x02040001, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -691,10 +691,11 @@ 0x02050028, 0x02040500, 0x02050029, - 0x0204B024 + 0x0204b024, };
-const u32 pc_beep_verbs[] = { -}; +const u32 pc_beep_verbs[] = {}; + AZALIA_ARRAY_SIZES; + #endif diff --git a/src/mainboard/intel/coffeelake_rvp/variants/whl_u/include/variant/hda_verb.h b/src/mainboard/intel/coffeelake_rvp/variants/whl_u/include/variant/hda_verb.h index d821a26..c9746b7 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/whl_u/include/variant/hda_verb.h +++ b/src/mainboard/intel/coffeelake_rvp/variants/whl_u/include/variant/hda_verb.h @@ -19,41 +19,41 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* ALC 700 */ - 0x10EC0700, - 0xFFFFFFFF, - 0x00000023, + 0x10ec0700, /* Codec Vendor / Device ID: Realtek ALC700 */ + 0xffffffff, /* Subsystem ID */ + 35, /* Number of jacks */
- AZALIA_SUBVENDOR(0, 0x10EC10F2), + AZALIA_SUBVENDOR(0, 0x10ec10f2), AZALIA_PIN_CFG(0, 0x01, 0x00000000), AZALIA_PIN_CFG(0, 0x12, 0x40000000), AZALIA_PIN_CFG(0, 0x13, 0x40000000), - AZALIA_PIN_CFG(0, 0x14, 0x411111F0), - AZALIA_PIN_CFG(0, 0x15, 0x411111F0), - AZALIA_PIN_CFG(0, 0x16, 0x411111F0), + AZALIA_PIN_CFG(0, 0x14, 0x411111f0), + AZALIA_PIN_CFG(0, 0x15, 0x411111f0), + AZALIA_PIN_CFG(0, 0x16, 0x411111f0), AZALIA_PIN_CFG(0, 0x17, 0x90170110), - AZALIA_PIN_CFG(0, 0x18, 0x411111F0), - AZALIA_PIN_CFG(0, 0x19, 0x04A11030), - AZALIA_PIN_CFG(0, 0x1A, 0x411111F0), - AZALIA_PIN_CFG(0, 0x1B, 0x411111F0), - AZALIA_PIN_CFG(0, 0x1D, 0x40622005), - AZALIA_PIN_CFG(0, 0x1E, 0x411111F0), - AZALIA_PIN_CFG(0, 0x1F, 0x411111F0), + AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x04a11030), + AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1b, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1d, 0x40622005), + AZALIA_PIN_CFG(0, 0x1e, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1f, 0x411111f0), AZALIA_PIN_CFG(0, 0x21, 0x04211020), - AZALIA_PIN_CFG(0, 0x29, 0x411111F0), + AZALIA_PIN_CFG(0, 0x29, 0x411111f0),
/* Widget node 0x20 */ 0x02050045, 0x02045289, - 0x0205004A, - 0x0204201B, + 0x0205004a, + 0x0204201b, + /* Widget node 0x20 - 1 */ 0x05850000, 0x05843888, - 0x0205006F, - 0x02042C0B, + 0x0205006f, + 0x02042c0b,
- //Widget node 0X20 for ALC1305 20160603 update + /* Widget node 0x20 for ALC1305 20160603 update */ 0x02050024, 0x02040010, 0x02050026, @@ -61,7 +61,7 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -70,16 +70,16 @@ 0x02050028, 0x02040600, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204003C, + 0x0204003c, 0x02050028, - 0x0204FFD0, + 0x0204ffd0, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -88,7 +88,7 @@ 0x02050028, 0x02040080, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -97,34 +97,34 @@ 0x02050028, 0x02040880, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204003A, + 0x0204003a, 0x02050028, - 0x02040DFE, + 0x02040dfe, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006A, + 0x0204006a, 0x02050028, - 0x0204005D, + 0x0204005d, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006C, + 0x0204006c, 0x02050028, 0x02040442, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -133,7 +133,7 @@ 0x02050028, 0x02040880, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -142,79 +142,79 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040008, 0x02050028, - 0x0204B000, + 0x0204b000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204002E, + 0x0204002e, 0x02050028, 0x02040800, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006A, + 0x0204006a, 0x02050028, - 0x020400C3, + 0x020400c3, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006C, + 0x0204006c, 0x02050028, - 0x0204D4A0, + 0x0204d4a0, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006A, + 0x0204006a, 0x02050028, - 0x020400CC, + 0x020400cc, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006C, + 0x0204006c, 0x02050028, - 0x0204400A, + 0x0204400a, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006A, + 0x0204006a, 0x02050028, - 0x020400C1, + 0x020400c1, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006C, + 0x0204006c, 0x02050028, 0x02040320, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -223,223 +223,223 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204003B, + 0x0204003b, 0x02050028, - 0x0204FFFF, + 0x0204ffff, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204003C, + 0x0204003c, 0x02050028, - 0x0204FC20, + 0x0204fc20, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204003A, + 0x0204003a, 0x02050028, - 0x02041DFE, + 0x02041dfe, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C0, + 0x020400c0, 0x02050028, - 0x020401FA, + 0x020401fa, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C1, + 0x020400c1, 0x02050028, - 0x0204DE23, + 0x0204de23, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C2, + 0x020400c2, 0x02050028, - 0x02041C00, + 0x02041c00, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C3, + 0x020400c3, 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C4, + 0x020400c4, 0x02050028, 0x02040200, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C5, + 0x020400c5, 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C6, + 0x020400c6, 0x02050028, - 0x020403F5, + 0x020403f5, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C7, + 0x020400c7, 0x02050028, - 0x0204AF1B, + 0x0204af1b, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C8, + 0x020400c8, 0x02050028, - 0x02041E0A, + 0x02041e0a, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C9, + 0x020400c9, 0x02050028, - 0x0204368E, + 0x0204368e, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400CA, + 0x020400ca, 0x02050028, - 0x020401FA, + 0x020401fa, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400CB, + 0x020400cb, 0x02050028, - 0x0204DE23, + 0x0204de23, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400CC, + 0x020400cc, 0x02050028, - 0x02041C00, + 0x02041c00, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400CD, + 0x020400cd, 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400CE, + 0x020400ce, 0x02050028, 0x02040200, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400CF, + 0x020400cf, 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400D0, + 0x020400d0, 0x02050028, - 0x020403F5, + 0x020403f5, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400D1, + 0x020400d1, 0x02050028, - 0x0204AF1B, + 0x0204af1b, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400D2, + 0x020400d2, 0x02050028, - 0x02041E0A, + 0x02041e0a, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400D3, + 0x020400d3, 0x02050028, - 0x0204368E, + 0x0204368e, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040040, 0x02050028, - 0x0204800F, + 0x0204800f, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -448,7 +448,7 @@ 0x02050028, 0x02048000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -457,7 +457,7 @@ 0x02050028, 0x02044848, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -466,7 +466,7 @@ 0x02050028, 0x02040800, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -475,7 +475,7 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -484,7 +484,7 @@ 0x02050028, 0x02044004, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -493,25 +493,25 @@ 0x02050028, 0x02040802, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040068, 0x02050028, - 0x0204890F, + 0x0204890f, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040069, 0x02050028, - 0x0204E021, + 0x0204e021, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -520,7 +520,7 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -529,7 +529,7 @@ 0x02050000, 0x02043330, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -538,7 +538,7 @@ 0x02050000, 0x02043333, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -547,7 +547,7 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -556,7 +556,7 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -565,7 +565,7 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -574,16 +574,16 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040050, 0x02050028, - 0x020402EC, + 0x020402ec, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -592,34 +592,34 @@ 0x02050028, 0x02044909, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040052, 0x02050028, - 0x020440B0, + 0x020440b0, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040046, 0x02050028, - 0x0204C22E, + 0x0204c22e, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040047, 0x02050028, - 0x02040C00, + 0x02040c00, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -628,7 +628,7 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -637,52 +637,52 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204004A, + 0x0204004a, 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204004B, + 0x0204004b, 0x02050028, - 0x02041C00, + 0x02041c00, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006A, + 0x0204006a, 0x02050028, 0x02040090, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006C, + 0x0204006c, 0x02050028, - 0x0204721F, + 0x0204721f, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204009E, + 0x0204009e, 0x02050028, 0x02040001, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -691,10 +691,11 @@ 0x02050028, 0x02040500, 0x02050029, - 0x0204B024 + 0x0204b024, };
-const u32 pc_beep_verbs[] = { -}; +const u32 pc_beep_verbs[] = {}; + AZALIA_ARRAY_SIZES; + #endif diff --git a/src/mainboard/intel/d510mo/hda_verb.c b/src/mainboard/intel/d510mo/hda_verb.c index a0dba38..e3b80fc 100644 --- a/src/mainboard/intel/d510mo/hda_verb.c +++ b/src/mainboard/intel/d510mo/hda_verb.c @@ -16,10 +16,9 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ 0x10ec0662, - 0x8086d618, // Subsystem ID - 0x0000000a, // Number of entries + 0x8086d618, /* Subsystem ID */ + 10, /* Number of entries */
/* Pin Widget Verb Table */ AZALIA_PIN_CFG(0, 0x14, 0x01014410), @@ -34,6 +33,6 @@ AZALIA_PIN_CFG(0, 0x1e, 0x99430130), };
-const u32 pc_beep_verbs[] = { -}; +const u32 pc_beep_verbs[] = {}; + AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/intel/dg41wv/hda_verb.c b/src/mainboard/intel/dg41wv/hda_verb.c index 23d566d..4db64c5 100644 --- a/src/mainboard/intel/dg41wv/hda_verb.c +++ b/src/mainboard/intel/dg41wv/hda_verb.c @@ -17,14 +17,11 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - /* Realtek ALC662 rev1 */ - 0x10ec0662, /* Vendor ID */ - 0x80865756, /* Subsystem ID */ - 10, /* Number of entries */ + 0x10ec0662, /* Vendor ID: Realtek ALC662 rev1 */ + 0x80865756, /* Subsystem ID */ + 10, /* Number of entries */
/* Pin Widget Verb Table */ - AZALIA_PIN_CFG(0, 0x14, 0x01014010), AZALIA_PIN_CFG(0, 0x15, 0x411111f0), AZALIA_PIN_CFG(0, 0x16, 0x411111f0), diff --git a/src/mainboard/intel/dg43gt/hda_verb.c b/src/mainboard/intel/dg43gt/hda_verb.c index e9b1fae..63e4f3e 100644 --- a/src/mainboard/intel/dg43gt/hda_verb.c +++ b/src/mainboard/intel/dg43gt/hda_verb.c @@ -17,13 +17,10 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ + /* --- Codec #0 --- */ 0x10ec0888, - 0x80860028, // Subsystem ID - 14, // Number of entries - - /* Pin Widget Verb Table */ - + 0x80860028, /* Subsystem ID */ + 14, /* Number of entries */ AZALIA_PIN_CFG(0, 0x11, 0x01452140), AZALIA_PIN_CFG(0, 0x12, 0x411111f0), AZALIA_PIN_CFG(0, 0x14, 0x01014410), @@ -39,11 +36,10 @@ AZALIA_PIN_CFG(0, 0x1e, 0x99430130), AZALIA_PIN_CFG(0, 0x1f, 0x411111f0),
- /* HDMI */ - 0x80862803, - 0x80860101, - 1, - + /* --- Codec #3 --- */ + 0x80862803, /* Vendor ID: Intel HDMI */ + 0x80860101, /* Subsystem ID */ + 1, /* Number of entries */ AZALIA_PIN_CFG(0, 0x03, 0x18560010) };
diff --git a/src/mainboard/intel/emeraldlake2/hda_verb.c b/src/mainboard/intel/emeraldlake2/hda_verb.c index bee63f4..68d74bb 100644 --- a/src/mainboard/intel/emeraldlake2/hda_verb.c +++ b/src/mainboard/intel/emeraldlake2/hda_verb.c @@ -16,16 +16,14 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10134210, // Codec Vendor / Device ID: Cirrus Logic CS4210 - 0x10134210, // Subsystem ID - 0x00000007, // Number of jacks + /* --- Codec #0 --- */ + 0x10134210, /* Codec Vendor / Device ID: Cirrus Logic CS4210 */ + 0x10134210, /* Subsystem ID */ + 7, /* Number of jacks */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x10134210 */ + /* HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x10134210),
- /* Pin Widget Verb Table */ - /* Pin Complex (NID 0x05) 1/8 Gray HP Out at Ext Front */ AZALIA_PIN_CFG(0x0, 0x05, 0x022120f0),
@@ -44,13 +42,13 @@ /* Pin Complex (NID 0x0a) Optical Black SPDIF Out at Ext N/A */ AZALIA_PIN_CFG(0x0, 0x0a, 0x434510f0),
- /* coreboot specific header */ - 0x80862805, // Codec Vendor / Device ID: Intel CougarPoint HDMI - 0x80860101, // Subsystem ID - 0x00000004, // Number of jacks + /* --- Codec #3 --- */ + 0x80862805, /* Codec Vendor / Device ID: Intel CougarPoint HDMI */ + 0x80860101, /* Subsystem ID */ + 4, /* Number of jacks */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ - AZALIA_SUBVENDOR(0x0, 0x80860101), + /* HDA Codec Subsystem ID Verb Table */ + AZALIA_SUBVENDOR(0x3, 0x80860101),
/* Pin Complex (NID 0x05) Digital Out at Int HDMI */ AZALIA_PIN_CFG(0x3, 0x05, 0x18560010), diff --git a/src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/hda_verb.h b/src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/hda_verb.h index d821a26..c9746b7 100644 --- a/src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/hda_verb.h +++ b/src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/hda_verb.h @@ -19,41 +19,41 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* ALC 700 */ - 0x10EC0700, - 0xFFFFFFFF, - 0x00000023, + 0x10ec0700, /* Codec Vendor / Device ID: Realtek ALC700 */ + 0xffffffff, /* Subsystem ID */ + 35, /* Number of jacks */
- AZALIA_SUBVENDOR(0, 0x10EC10F2), + AZALIA_SUBVENDOR(0, 0x10ec10f2), AZALIA_PIN_CFG(0, 0x01, 0x00000000), AZALIA_PIN_CFG(0, 0x12, 0x40000000), AZALIA_PIN_CFG(0, 0x13, 0x40000000), - AZALIA_PIN_CFG(0, 0x14, 0x411111F0), - AZALIA_PIN_CFG(0, 0x15, 0x411111F0), - AZALIA_PIN_CFG(0, 0x16, 0x411111F0), + AZALIA_PIN_CFG(0, 0x14, 0x411111f0), + AZALIA_PIN_CFG(0, 0x15, 0x411111f0), + AZALIA_PIN_CFG(0, 0x16, 0x411111f0), AZALIA_PIN_CFG(0, 0x17, 0x90170110), - AZALIA_PIN_CFG(0, 0x18, 0x411111F0), - AZALIA_PIN_CFG(0, 0x19, 0x04A11030), - AZALIA_PIN_CFG(0, 0x1A, 0x411111F0), - AZALIA_PIN_CFG(0, 0x1B, 0x411111F0), - AZALIA_PIN_CFG(0, 0x1D, 0x40622005), - AZALIA_PIN_CFG(0, 0x1E, 0x411111F0), - AZALIA_PIN_CFG(0, 0x1F, 0x411111F0), + AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x04a11030), + AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1b, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1d, 0x40622005), + AZALIA_PIN_CFG(0, 0x1e, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1f, 0x411111f0), AZALIA_PIN_CFG(0, 0x21, 0x04211020), - AZALIA_PIN_CFG(0, 0x29, 0x411111F0), + AZALIA_PIN_CFG(0, 0x29, 0x411111f0),
/* Widget node 0x20 */ 0x02050045, 0x02045289, - 0x0205004A, - 0x0204201B, + 0x0205004a, + 0x0204201b, + /* Widget node 0x20 - 1 */ 0x05850000, 0x05843888, - 0x0205006F, - 0x02042C0B, + 0x0205006f, + 0x02042c0b,
- //Widget node 0X20 for ALC1305 20160603 update + /* Widget node 0x20 for ALC1305 20160603 update */ 0x02050024, 0x02040010, 0x02050026, @@ -61,7 +61,7 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -70,16 +70,16 @@ 0x02050028, 0x02040600, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204003C, + 0x0204003c, 0x02050028, - 0x0204FFD0, + 0x0204ffd0, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -88,7 +88,7 @@ 0x02050028, 0x02040080, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -97,34 +97,34 @@ 0x02050028, 0x02040880, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204003A, + 0x0204003a, 0x02050028, - 0x02040DFE, + 0x02040dfe, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006A, + 0x0204006a, 0x02050028, - 0x0204005D, + 0x0204005d, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006C, + 0x0204006c, 0x02050028, 0x02040442, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -133,7 +133,7 @@ 0x02050028, 0x02040880, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -142,79 +142,79 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040008, 0x02050028, - 0x0204B000, + 0x0204b000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204002E, + 0x0204002e, 0x02050028, 0x02040800, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006A, + 0x0204006a, 0x02050028, - 0x020400C3, + 0x020400c3, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006C, + 0x0204006c, 0x02050028, - 0x0204D4A0, + 0x0204d4a0, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006A, + 0x0204006a, 0x02050028, - 0x020400CC, + 0x020400cc, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006C, + 0x0204006c, 0x02050028, - 0x0204400A, + 0x0204400a, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006A, + 0x0204006a, 0x02050028, - 0x020400C1, + 0x020400c1, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006C, + 0x0204006c, 0x02050028, 0x02040320, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -223,223 +223,223 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204003B, + 0x0204003b, 0x02050028, - 0x0204FFFF, + 0x0204ffff, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204003C, + 0x0204003c, 0x02050028, - 0x0204FC20, + 0x0204fc20, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204003A, + 0x0204003a, 0x02050028, - 0x02041DFE, + 0x02041dfe, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C0, + 0x020400c0, 0x02050028, - 0x020401FA, + 0x020401fa, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C1, + 0x020400c1, 0x02050028, - 0x0204DE23, + 0x0204de23, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C2, + 0x020400c2, 0x02050028, - 0x02041C00, + 0x02041c00, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C3, + 0x020400c3, 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C4, + 0x020400c4, 0x02050028, 0x02040200, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C5, + 0x020400c5, 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C6, + 0x020400c6, 0x02050028, - 0x020403F5, + 0x020403f5, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C7, + 0x020400c7, 0x02050028, - 0x0204AF1B, + 0x0204af1b, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C8, + 0x020400c8, 0x02050028, - 0x02041E0A, + 0x02041e0a, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400C9, + 0x020400c9, 0x02050028, - 0x0204368E, + 0x0204368e, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400CA, + 0x020400ca, 0x02050028, - 0x020401FA, + 0x020401fa, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400CB, + 0x020400cb, 0x02050028, - 0x0204DE23, + 0x0204de23, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400CC, + 0x020400cc, 0x02050028, - 0x02041C00, + 0x02041c00, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400CD, + 0x020400cd, 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400CE, + 0x020400ce, 0x02050028, 0x02040200, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400CF, + 0x020400cf, 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400D0, + 0x020400d0, 0x02050028, - 0x020403F5, + 0x020403f5, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400D1, + 0x020400d1, 0x02050028, - 0x0204AF1B, + 0x0204af1b, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400D2, + 0x020400d2, 0x02050028, - 0x02041E0A, + 0x02041e0a, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x020400D3, + 0x020400d3, 0x02050028, - 0x0204368E, + 0x0204368e, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040040, 0x02050028, - 0x0204800F, + 0x0204800f, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -448,7 +448,7 @@ 0x02050028, 0x02048000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -457,7 +457,7 @@ 0x02050028, 0x02044848, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -466,7 +466,7 @@ 0x02050028, 0x02040800, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -475,7 +475,7 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -484,7 +484,7 @@ 0x02050028, 0x02044004, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -493,25 +493,25 @@ 0x02050028, 0x02040802, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040068, 0x02050028, - 0x0204890F, + 0x0204890f, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040069, 0x02050028, - 0x0204E021, + 0x0204e021, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -520,7 +520,7 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -529,7 +529,7 @@ 0x02050000, 0x02043330, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -538,7 +538,7 @@ 0x02050000, 0x02043333, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -547,7 +547,7 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -556,7 +556,7 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -565,7 +565,7 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -574,16 +574,16 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040050, 0x02050028, - 0x020402EC, + 0x020402ec, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -592,34 +592,34 @@ 0x02050028, 0x02044909, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040052, 0x02050028, - 0x020440B0, + 0x020440b0, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040046, 0x02050028, - 0x0204C22E, + 0x0204c22e, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, 0x02040047, 0x02050028, - 0x02040C00, + 0x02040c00, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -628,7 +628,7 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -637,52 +637,52 @@ 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204004A, + 0x0204004a, 0x02050028, 0x02040000, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204004B, + 0x0204004b, 0x02050028, - 0x02041C00, + 0x02041c00, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006A, + 0x0204006a, 0x02050028, 0x02040090, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204006C, + 0x0204006c, 0x02050028, - 0x0204721F, + 0x0204721f, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, 0x02050026, - 0x0204009E, + 0x0204009e, 0x02050028, 0x02040001, 0x02050029, - 0x0204B024, + 0x0204b024,
0x02050024, 0x02040010, @@ -691,10 +691,11 @@ 0x02050028, 0x02040500, 0x02050029, - 0x0204B024 + 0x0204b024, };
-const u32 pc_beep_verbs[] = { -}; +const u32 pc_beep_verbs[] = {}; + AZALIA_ARRAY_SIZES; + #endif diff --git a/src/mainboard/intel/kblrvp/variants/rvp11/include/variant/hda_verb.h b/src/mainboard/intel/kblrvp/variants/rvp11/include/variant/hda_verb.h index 4119e69..ce684e2 100644 --- a/src/mainboard/intel/kblrvp/variants/rvp11/include/variant/hda_verb.h +++ b/src/mainboard/intel/kblrvp/variants/rvp11/include/variant/hda_verb.h @@ -19,14 +19,13 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - - 0x8086280B, - 0x00000000, - 0x00000005, + 0x8086280b, /* Codec Vendor / Device ID */ + 0x00000000, /* Subsystem ID */ + 5, /* Number of jacks */
/* * Display Audio Verb Table - * Enable the third converter and Pin first (NID 08h) + * Enable the third converter and Pin first (NID 0x08) */ 0x00878101, 0x00878101, @@ -37,55 +36,61 @@ AZALIA_PIN_CFG(0, 0x06, 0x18560020), AZALIA_PIN_CFG(0, 0x07, 0x18560030),
- /* Disable the third converter and third Pin (NID 08h) */ + /* Disable the third converter and third pin (NID 0x08) */ 0x00878100, 0x00878100, 0x00878100, 0x00878100,
- /* ALC 298 */ - 0x10EC0298, - 0x00000000, - 0x00000023,
- AZALIA_SUBVENDOR(0, 0x10EC109C), + + 0x10ec0298, /* Codec Vendor / Device ID: Realtek ALC298 */ + 0xffffffff, /* Subsystem ID */ + 35, /* Number of jacks */ + + AZALIA_SUBVENDOR(0, 0x10ec109c), AZALIA_PIN_CFG(0, 0x01, 0x00000000), - AZALIA_PIN_CFG(0, 0x12, 0x411111F0), + AZALIA_PIN_CFG(0, 0x12, 0x411111f0), AZALIA_PIN_CFG(0, 0x13, 0x40000000), - AZALIA_PIN_CFG(0, 0x14, 0x9017011F), + AZALIA_PIN_CFG(0, 0x14, 0x9017011f), AZALIA_PIN_CFG(0, 0x17, 0x90170110), - AZALIA_PIN_CFG(0, 0x18, 0x03A11040), - AZALIA_PIN_CFG(0, 0x19, 0x411111F0), - AZALIA_PIN_CFG(0, 0x1A, 0x411111F0), - AZALIA_PIN_CFG(0, 0x1D, 0x4066A22D), - AZALIA_PIN_CFG(0, 0x1E, 0x411111F0), + AZALIA_PIN_CFG(0, 0x18, 0x03a11040), + AZALIA_PIN_CFG(0, 0x19, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1d, 0x4066a22d), + AZALIA_PIN_CFG(0, 0x1e, 0x411111f0), AZALIA_PIN_CFG(0, 0x21, 0x03211020),
/* Widget node 0x20 */ - 0x0205004F, - 0x0204B009, + 0x0205004f, + 0x0204b009, 0x02050050, 0x02041000, + /* Widget node 0x20 - 1 */ 0x02050019, 0x02040017, 0x02050020, 0x02040002, + /* Widget node 0x20 - 2 */ - 0x0205008F, + 0x0205008f, 0x02041008, 0x02050036, - 0x020462C0, + 0x020462c0, + /* Widget node 0x20 - 3 */ - 0x0205002B, - 0x02040D10, - 0x0205002D, + 0x0205002b, + 0x02040d10, + 0x0205002d, 0x02044020, + /* Widget node 0x20 - 4 */ - 0x0205000E, - 0x02046F80, - 0x01771F90, - 0x01771F90, + 0x0205000e, + 0x02046f80, + 0x01771f90, + 0x01771f90, + /* Widget node 0x20 - 5 */ 0x02050079, 0x02046800, @@ -94,106 +99,107 @@
/* TI AMP settings */ 0x02050022, - 0x0204004C, + 0x0204004c, 0x02050023, 0x02040000, 0x02050025, 0x02040000, 0x02050026, - 0x0204B010, + 0x0204b010,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
0x02050022, - 0x0204004C, + 0x0204004c, 0x02050023, 0x02040002, 0x02050025, 0x02040011, 0x02050026, - 0x0204B010, + 0x0204b010,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
0x02050022, - 0x0204004C, + 0x0204004c, 0x02050023, - 0x0204000F, + 0x0204000f, 0x02050025, 0x02040010, 0x02050026, - 0x0204B010, + 0x0204b010,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
0x02050022, - 0x0204004C, + 0x0204004c, 0x02050023, 0x02040025, 0x02050025, 0x02040008, 0x02050026, - 0x0204B010, + 0x0204b010,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
0x02050022, - 0x0204004C, + 0x0204004c, 0x02050023, 0x02040002, 0x02050025, 0x02040000, 0x02050026, - 0x0204B010, + 0x0204b010,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
0x02050022, - 0x0204004C, + 0x0204004c, 0x02050023, 0x02040003, 0x02050025, 0x02040000, 0x02050026, - 0x0204B010 + 0x0204b010, };
-const u32 pc_beep_verbs[] = { -}; +const u32 pc_beep_verbs[] = {}; + AZALIA_ARRAY_SIZES; + #endif diff --git a/src/mainboard/intel/kblrvp/variants/rvp3/include/variant/hda_verb.h b/src/mainboard/intel/kblrvp/variants/rvp3/include/variant/hda_verb.h index 9d6e8b0..35b4ec8 100644 --- a/src/mainboard/intel/kblrvp/variants/rvp3/include/variant/hda_verb.h +++ b/src/mainboard/intel/kblrvp/variants/rvp3/include/variant/hda_verb.h @@ -20,14 +20,13 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - - 0x8086280B, - 0x00000000, - 0x00000005, + 0x8086280b, /* Codec Vendor / Device ID */ + 0x00000000, /* Subsystem ID */ + 5, /* Number of jacks */
/* * Display Audio Verb Table - * Enable the third converter and pin first (NID 08h) + * Enable the third converter and pin first (NID 0x08) */ 0x00878101, 0x00878101, @@ -38,163 +37,169 @@ AZALIA_PIN_CFG(0, 0x06, 0x18560020), AZALIA_PIN_CFG(0, 0x07, 0x18560030),
- /* Disable the third converter and third pin (NID 08h) */ + /* Disable the third converter and third pin (NID 0x08) */ 0x00878100, 0x00878100, 0x00878100, 0x00878100,
- /* ALC 286 */ - 0x10EC0286, - 0x00000000, - 0x00000023,
- AZALIA_SUBVENDOR(0, 0x10EC108E), + + 0x10ec0286, /* Codec Vendor / Device ID: Realtek ALC286 */ + 0x00000000, /* Subsystem ID */ + 35, /* Number of jacks */ + + AZALIA_SUBVENDOR(0, 0x10ec108e), AZALIA_PIN_CFG(0, 0x01, 0x00000000), - AZALIA_PIN_CFG(0, 0x12, 0x411111F0), + AZALIA_PIN_CFG(0, 0x12, 0x411111f0), AZALIA_PIN_CFG(0, 0x13, 0x40000000), - AZALIA_PIN_CFG(0, 0x14, 0x9017011F), + AZALIA_PIN_CFG(0, 0x14, 0x9017011f), AZALIA_PIN_CFG(0, 0x17, 0x90170110), - AZALIA_PIN_CFG(0, 0x18, 0x03A11040), - AZALIA_PIN_CFG(0, 0x19, 0x411111F0), - AZALIA_PIN_CFG(0, 0x1A, 0x411111F0), - AZALIA_PIN_CFG(0, 0x1D, 0x4066A22D), - AZALIA_PIN_CFG(0, 0x1E, 0x411111F0), + AZALIA_PIN_CFG(0, 0x18, 0x03a11040), + AZALIA_PIN_CFG(0, 0x19, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1d, 0x4066a22d), + AZALIA_PIN_CFG(0, 0x1e, 0x411111f0), AZALIA_PIN_CFG(0, 0x21, 0x03211020),
/* Widget node 0x20 */ 0x02050071, 0x02040014, 0x02050010, - 0x02040C22, + 0x02040c22, + /* Widget node 0x20 - 1 */ - 0x0205004F, + 0x0205004f, 0x02045029, - 0x0205004F, + 0x0205004f, 0x02045029, + /* Widget node 0x20 - 2 */ - 0x0205002B, - 0x02040DD0, - 0x0205002D, + 0x0205002b, + 0x02040dd0, + 0x0205002d, 0x02047020, + /* Widget node 0x20 - 3 */ - 0x0205000E, - 0x02046C80, - 0x01771F90, - 0x01771F90, + 0x0205000e, + 0x02046c80, + 0x01771f90, + 0x01771f90, + /* TI AMP settings */ 0x02050022, - 0x0204004C, + 0x0204004c, 0x02050023, 0x02040000,
0x02050025, 0x02040000, 0x02050026, - 0x0204B010, + 0x0204b010,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
0x02050022, - 0x0204004C, + 0x0204004c, 0x02050023, 0x02040002,
0x02050025, 0x02040011, 0x02050026, - 0x0204B010, + 0x0204b010,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
0x02050022, - 0x0204004C, + 0x0204004c, 0x02050023, - 0x0204000D, + 0x0204000d,
0x02050025, 0x02040010, 0x02050026, - 0x0204B010, + 0x0204b010,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
0x02050022, - 0x0204004C, + 0x0204004c, 0x02050023, 0x02040025,
0x02050025, 0x02040008, 0x02050026, - 0x0204B010, + 0x0204b010,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
0x02050022, - 0x0204004C, + 0x0204004c, 0x02050023, 0x02040002,
0x02050025, 0x02040000, 0x02050026, - 0x0204B010, + 0x0204b010,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
0x02050022, - 0x0204004C, + 0x0204004c, 0x02050023, 0x02040003,
0x02050025, 0x02040000, 0x02050026, - 0x0204B010 + 0x0204b010, };
-const u32 pc_beep_verbs[] = { -}; +const u32 pc_beep_verbs[] = {}; + AZALIA_ARRAY_SIZES; + #endif diff --git a/src/mainboard/intel/kblrvp/variants/rvp7/include/variant/hda_verb.h b/src/mainboard/intel/kblrvp/variants/rvp7/include/variant/hda_verb.h index d0f68c8..663a104 100644 --- a/src/mainboard/intel/kblrvp/variants/rvp7/include/variant/hda_verb.h +++ b/src/mainboard/intel/kblrvp/variants/rvp7/include/variant/hda_verb.h @@ -20,14 +20,13 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - - 0x8086280B, - 0x00000000, - 0x00000005, + 0x8086280b, /* Codec Vendor / Device ID */ + 0x00000000, /* Subsystem ID */ + 5, /* Number of jacks */
/* * Display Audio Verb Table - * Enable the third converter and Pin first (NID 08h) + * Enable the third converter and pin first (NID 0x08) */ 0x00878101, 0x00878101, @@ -38,163 +37,169 @@ AZALIA_PIN_CFG(0, 0x06, 0x18560020), AZALIA_PIN_CFG(0, 0x07, 0x18560030),
- /* Disable the third converter and third Pin (NID 08h) */ + /* Disable the third converter and third pin (NID 0x08) */ 0x00878100, 0x00878100, 0x00878100, 0x00878100,
- /* ALC 286 */ - 0x10EC0286, - 0x00000000, - 0x00000023,
- AZALIA_SUBVENDOR(0, 0x10EC1092), + + 0x10ec0286, /* Codec Vendor / Device ID: Realtek ALC286 */ + 0x00000000, /* Subsystem ID */ + 35, /* Number of jacks */ + + AZALIA_SUBVENDOR(0, 0x10ec1092), AZALIA_PIN_CFG(0, 0x01, 0x00000000), - AZALIA_PIN_CFG(0, 0x12, 0x411111F0), + AZALIA_PIN_CFG(0, 0x12, 0x411111f0), AZALIA_PIN_CFG(0, 0x13, 0x40000000), - AZALIA_PIN_CFG(0, 0x14, 0x9017011F), + AZALIA_PIN_CFG(0, 0x14, 0x9017011f), AZALIA_PIN_CFG(0, 0x17, 0x90170110), - AZALIA_PIN_CFG(0, 0x18, 0x03A11040), - AZALIA_PIN_CFG(0, 0x19, 0x411111F0), - AZALIA_PIN_CFG(0, 0x1A, 0x411111F0), - AZALIA_PIN_CFG(0, 0x1D, 0x4066A22D), - AZALIA_PIN_CFG(0, 0x1E, 0x411111F0), + AZALIA_PIN_CFG(0, 0x18, 0x03a11040), + AZALIA_PIN_CFG(0, 0x19, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1d, 0x4066a22d), + AZALIA_PIN_CFG(0, 0x1e, 0x411111f0), AZALIA_PIN_CFG(0, 0x21, 0x03211020),
/* Widget node 0x20 */ 0x02050071, 0x02040014, 0x02050010, - 0x02040C22, + 0x02040c22, + /* Widget node 0x20 - 1 */ - 0x0205004F, + 0x0205004f, 0x02045029, - 0x0205004F, + 0x0205004f, 0x02045029, + /* Widget node 0x20 - 2 */ - 0x0205002B, - 0x02040DD0, - 0x0205002D, + 0x0205002b, + 0x02040dd0, + 0x0205002d, 0x02047020, + /* Widget node 0x20 - 3 */ - 0x0205000E, - 0x02046C80, - 0x01771F90, - 0x01771F90, + 0x0205000e, + 0x02046c80, + 0x01771f90, + 0x01771f90, + /* TI AMP settings */ 0x02050022, - 0x0204004C, + 0x0204004c, 0x02050023, 0x02040000,
0x02050025, 0x02040000, 0x02050026, - 0x0204B010, + 0x0204b010,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
0x02050022, - 0x0204004C, + 0x0204004c, 0x02050023, 0x02040002,
0x02050025, 0x02040011, 0x02050026, - 0x0204B010, + 0x0204b010,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
0x02050022, - 0x0204004C, + 0x0204004c, 0x02050023, - 0x0204000D, + 0x0204000d,
0x02050025, 0x02040010, 0x02050026, - 0x0204B010, + 0x0204b010,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
0x02050022, - 0x0204004C, + 0x0204004c, 0x02050023, 0x02040025,
0x02050025, 0x02040008, 0x02050026, - 0x0204B010, + 0x0204b010,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
0x02050022, - 0x0204004C, + 0x0204004c, 0x02050023, 0x02040002,
0x02050025, 0x02040000, 0x02050026, - 0x0204B010, + 0x0204b010,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
- 0x000F0000, - 0x000F0000, - 0x000F0000, - 0x000F0000, + 0x000f0000, + 0x000f0000, + 0x000f0000, + 0x000f0000,
0x02050022, - 0x0204004C, + 0x0204004c, 0x02050023, 0x02040003,
0x02050025, 0x02040000, 0x02050026, - 0x0204B010 + 0x0204b010, };
-const u32 pc_beep_verbs[] = { -}; +const u32 pc_beep_verbs[] = {}; + AZALIA_ARRAY_SIZES; + #endif diff --git a/src/mainboard/intel/wtm2/hda_verb.c b/src/mainboard/intel/wtm2/hda_verb.c index f7b74a1..22dec1b 100644 --- a/src/mainboard/intel/wtm2/hda_verb.c +++ b/src/mainboard/intel/wtm2/hda_verb.c @@ -16,16 +16,15 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10134210, // Codec Vendor / Device ID: Cirrus Logic CS4210 - 0x10134210, // Subsystem ID - 0x00000007, // Number of jacks + /* --- Codec #0 --- */ + 0x10134210, /* Codec Vendor / Device ID: Cirrus Logic CS4210 */ + 0x10134210, /* Subsystem ID */ + 7, /* Number of jacks */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x10134210 */ + /* HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x10134210),
/* Pin Widget Verb Table */ - /* Pin Complex (NID 0x05) 1/8 Gray HP Out at Ext Front */ AZALIA_PIN_CFG(0x0, 0x05, 0x022120f0),
@@ -44,13 +43,13 @@ /* Pin Complex (NID 0x0a) Optical Black SPDIF Out at Ext N/A */ AZALIA_PIN_CFG(0x0, 0x0a, 0x434510f0),
- /* coreboot specific header */ - 0x80862805, // Codec Vendor / Device ID: Intel CougarPoint HDMI - 0x80860101, // Subsystem ID - 0x00000004, // Number of jacks + /* --- Codec #3 --- */ + 0x80862805, /* Codec Vendor / Device ID: Intel CougarPoint HDMI */ + 0x80860101, /* Subsystem ID */ + 4, /* Number of jacks */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ - AZALIA_SUBVENDOR(0x0, 0x80860101), + /* HDA Codec Subsystem ID Verb Table */ + AZALIA_SUBVENDOR(0x3, 0x80860101),
/* Pin Complex (NID 0x05) Digital Out at Int HDMI */ AZALIA_PIN_CFG(0x3, 0x05, 0x18560010), diff --git a/src/mainboard/kontron/ktqm77/hda_verb.c b/src/mainboard/kontron/ktqm77/hda_verb.c index fdbc977..9b1d147 100644 --- a/src/mainboard/kontron/ktqm77/hda_verb.c +++ b/src/mainboard/kontron/ktqm77/hda_verb.c @@ -17,16 +17,15 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ + /* --- Codec #0 --- */ 0x11060397, /* Codec Vendor / Device ID: Via VT1708S */ 0x11060000, /* Subsystem ID */ - 0x0000000c, /* Number of jacks */ + 12, /* Number of jacks */
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x11060000 */ AZALIA_SUBVENDOR(0x0, 0x11060000),
/* Pin Widget Verb Table */ - /* * NID 0x19 [Port A (SURR)]: * Jack Internal Speaker N/A Black @@ -93,11 +92,10 @@ */ AZALIA_PIN_CFG(0, 0x23, 0x10102114),
- - /* coreboot specific header */ + /* --- Codec #3 --- */ 0x80862806, /* Codec Vendor / Device ID: Intel PantherPoint HDMI */ 0x80860101, /* Subsystem ID */ - 0x00000004, /* Number of jacks */ + 4, /* Number of jacks */
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ AZALIA_SUBVENDOR(0x0, 0x80860101), diff --git a/src/mainboard/lenovo/t400/hda_verb.c b/src/mainboard/lenovo/t400/hda_verb.c index 9890151..4d97b5d 100644 --- a/src/mainboard/lenovo/t400/hda_verb.c +++ b/src/mainboard/lenovo/t400/hda_verb.c @@ -17,13 +17,11 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x14f15051, // Conexant CX20561 (Hermosa) - 0x17aa211c, // Subsystem ID - 0x00000008, // Number of entries + 0x14f15051, /* Conexant CX20561 (Hermosa) */ + 0x17aa211c, /* Subsystem ID */ + 8, /* Number of entries */
/* Pin Widget Verb Table */ - AZALIA_PIN_CFG(0, 0x16, 0x022140f0), AZALIA_PIN_CFG(0, 0x17, 0x61a190f0), AZALIA_PIN_CFG(0, 0x18, 0x02a190f0), diff --git a/src/mainboard/lenovo/t420/hda_verb.c b/src/mainboard/lenovo/t420/hda_verb.c index 4c68c73..53503f1 100644 --- a/src/mainboard/lenovo/t420/hda_verb.c +++ b/src/mainboard/lenovo/t420/hda_verb.c @@ -41,8 +41,7 @@ 0x00b707C0, /* Enable PortB as Output with HP amp */ 0x00d70740, /* Enable PortD as Output */ 0x0017a200, /* Disable ClkEn of PortSenseTst */ - 0x0017c621, /* Slave Port - Port A used as microphone input for - combo Jack + 0x0017c621, /* Slave Port - Port A used as microphone input for combo Jack Master Port - Port B used for Jack Presence Detect Enable Combo Jack Detection */ 0x0017a208, /* Enable ClkEn of PortSenseTst */ diff --git a/src/mainboard/lenovo/t420s/hda_verb.c b/src/mainboard/lenovo/t420s/hda_verb.c index 9d315d7..af2a7fb 100644 --- a/src/mainboard/lenovo/t420s/hda_verb.c +++ b/src/mainboard/lenovo/t420s/hda_verb.c @@ -41,8 +41,7 @@ 0x00b707C0, /* Enable PortB as Output with HP amp */ 0x00d70740, /* Enable PortD as Output */ 0x0017a200, /* Disable ClkEn of PortSenseTst */ - 0x0017c621, /* Slave Port - Port A used as microphone input for - combo Jack + 0x0017c621, /* Slave Port - Port A used as microphone input for combo Jack Master Port - Port B used for Jack Presence Detect Enable Combo Jack Detection */ 0x0017a208, /* Enable ClkEn of PortSenseTst */ diff --git a/src/mainboard/lenovo/t520/hda_verb.c b/src/mainboard/lenovo/t520/hda_verb.c index 46d7d94..a1cf688 100644 --- a/src/mainboard/lenovo/t520/hda_verb.c +++ b/src/mainboard/lenovo/t520/hda_verb.c @@ -41,8 +41,7 @@ 0x00b707c0, /* Enable PortB as Output with HP amp */ 0x00d70740, /* Enable PortD as Output */ 0x0017a200, /* Disable ClkEn of PortSenseTst */ - 0x0017c621, /* Slave Port - Port A used as microphone input for - combo Jack + 0x0017c621, /* Slave Port - Port A used as microphone input for combo Jack Master Port - Port B used for Jack Presence Detect Enable Combo Jack Detection */ 0x0017a208, /* Enable ClkEn of PortSenseTst */ diff --git a/src/mainboard/lenovo/thinkcentre_a58/hda_verb.c b/src/mainboard/lenovo/thinkcentre_a58/hda_verb.c index 94ffcfe..17b97bc 100644 --- a/src/mainboard/lenovo/thinkcentre_a58/hda_verb.c +++ b/src/mainboard/lenovo/thinkcentre_a58/hda_verb.c @@ -17,14 +17,11 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - /* Realtek ALC662 rev1 */ - 0x10ec0662, /* Vendor ID */ - 0x17aa304f, /* Subsystem ID */ - 10, /* Number of entries */ + 0x10ec0662, /* Vendor ID: Realtek ALC662 rev1 */ + 0x17aa304f, /* Subsystem ID */ + 10, /* Number of entries */
/* Pin Widget Verb Table */ - AZALIA_PIN_CFG(0, 0x14, 0x01014010), AZALIA_PIN_CFG(0, 0x15, 0x99130120), AZALIA_PIN_CFG(0, 0x16, 0x411111f0), diff --git a/src/mainboard/lenovo/x131e/hda_verb.c b/src/mainboard/lenovo/x131e/hda_verb.c index 83b5148..a1481f1 100644 --- a/src/mainboard/lenovo/x131e/hda_verb.c +++ b/src/mainboard/lenovo/x131e/hda_verb.c @@ -17,61 +17,61 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10ec0269, // Codec Vendor / Device ID: Realtek - 0x17aa21fe, // Subsystem ID - 0x0000000b, // Number of jacks + /* --- Codec #0 --- */ + 0x10ec0269, /* Codec Vendor / Device ID: Realtek */ + 0x17aa21fe, /* Subsystem ID */ + 11, /* Number of jacks */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x17aa21fe */ + /* HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x17aa21fe),
/* Pin Widget Verb Table */
- /* Pin Complex (NID 0x12): 0x90a60930 DMIC */ + /* DMIC */ AZALIA_PIN_CFG(0x0, 0x12, 0x90a60930),
- /* Pin Complex (NID 0x14): 0x90170110 SPEAKER-OUT (Port-D) */ + /* SPEAKER-OUT (Port-D) */ AZALIA_PIN_CFG(0x0, 0x14, 0x90170110),
- /* Pin Complex (NID 0x15): 0x0321101f HP-OUT (Port-A) */ + /* HP-OUT (Port-A) */ AZALIA_PIN_CFG(0x0, 0x15, 0x0321101f),
- /* Pin Complex (NID 0x17): 0x411111f0 MONO-OUT (Port-H) */ + /* MONO-OUT (Port-H) */ AZALIA_PIN_CFG(0x0, 0x17, 0x411111f0),
- /* Pin Complex (NID 0x18): 0x03a11820 MIC1 (Port-B) */ + /* MIC1 (Port-B) */ AZALIA_PIN_CFG(0x0, 0x18, 0x03a11820),
- /* Pin Complex (NID 0x19): 0x411111f0 MIC2 (Port-F) */ + /* MIC2 (Port-F) */ AZALIA_PIN_CFG(0x0, 0x19, 0x411111f0),
- /* Pin Complex (NID 0x1a): 0x411111f0 LINE1 (Port-C) */ + /* LINE1 (Port-C) */ AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
- /* Pin Complex (NID 0x1b): 0x411111f0 LINE2 (Port-E) */ + /* LINE2 (Port-E) */ AZALIA_PIN_CFG(0x0, 0x1b, 0x411111f0),
- /* Pin Complex (NID 0x1d): 0x4016862d PC-BEEP */ + /* PC-BEEP */ AZALIA_PIN_CFG(0x0, 0x1d, 0x4016862d),
- /* Pin Complex (NID 0x1e): 0x411111f0 S/PDIF-OUT */ + /* S/PDIF-OUT */ AZALIA_PIN_CFG(0x0, 0x1e, 0x411111f0),
- /* coreboot specific header */ - 0x80862806, // Codec Vendor / Device ID: Intel PantherPoint HDMI - 0x80860101, // Subsystem ID - 0x00000004, // Number of jacks + /* --- Codec #3 --- */ + 0x80862806, /* Codec Vendor / Device ID: Intel PantherPoint HDMI */ + 0x80860101, /* Subsystem ID */ + 0x00000004, /* Number of jacks */
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ AZALIA_SUBVENDOR(0x3, 0x80860101),
- /* Pin Complex (NID 0x05) Digital Out at Int HDMI */ + /* Digital Out at Int HDMI */ AZALIA_PIN_CFG(0x3, 0x05, 0x18560010),
- /* Pin Complex (NID 0x06) Not Connected */ + /* Not Connected */ AZALIA_PIN_CFG(0x3, 0x06, 0x58560020),
- /* Pin Complex (NID 0x07) Not Connected */ + /* Not Connected */ AZALIA_PIN_CFG(0x3, 0x07, 0x58560030), };
diff --git a/src/mainboard/lenovo/x200/hda_verb.c b/src/mainboard/lenovo/x200/hda_verb.c index 890b6c5..15ff4eb 100644 --- a/src/mainboard/lenovo/x200/hda_verb.c +++ b/src/mainboard/lenovo/x200/hda_verb.c @@ -17,13 +17,11 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x14f15051, // Conexant CX20561 (Hermosa) - 0x17aa20ff, // Subsystem ID - 0x00000008, // Number of entries + 0x14f15051, /* Conexant CX20561 (Hermosa) */ + 0x17aa20ff, /* Subsystem ID */ + 8, /* Number of entries */
/* Pin Widget Verb Table */ - AZALIA_PIN_CFG(0, 0x16, 0x042140f0), AZALIA_PIN_CFG(0, 0x17, 0x61a190f0), AZALIA_PIN_CFG(0, 0x18, 0x04a190f0), diff --git a/src/mainboard/lenovo/x60/hda_verb.c b/src/mainboard/lenovo/x60/hda_verb.c index 0712498..02f56c7 100644 --- a/src/mainboard/lenovo/x60/hda_verb.c +++ b/src/mainboard/lenovo/x60/hda_verb.c @@ -17,9 +17,7 @@ 0x11d41981, /* Codec Vendor / Device ID: Analog Devices AD1981 */ 0x17aa2025, /* Subsystem ID */ 11, /* Number of 4 dword sets */ - AZALIA_SUBVENDOR(0x0, 0x17aa2025), - AZALIA_PIN_CFG(0, 0x05, 0xc3014110), AZALIA_PIN_CFG(0, 0x06, 0x4221401f), AZALIA_PIN_CFG(0, 0x07, 0x591311f0), @@ -31,5 +29,7 @@ AZALIA_PIN_CFG(0, 0x18, 0x41a19023), AZALIA_PIN_CFG(0, 0x19, 0x9933e12e) }; + const u32 pc_beep_verbs[0] = {}; + AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/purism/librem_bdw/hda_verb.c b/src/mainboard/purism/librem_bdw/hda_verb.c index 958a939..ffa878f 100644 --- a/src/mainboard/purism/librem_bdw/hda_verb.c +++ b/src/mainboard/purism/librem_bdw/hda_verb.c @@ -16,13 +16,13 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ 0x10ec0269, /* Codec Vendor / Device ID: Realtek ALC269 */ 0x19910269, /* Subsystem ID */ - 0x0000000c, /* Number of jacks (NID entries) */ + 12, /* Number of jacks (NID entries) */
- 0x0017ff00, /* Function Reset */ - 0x0017ff00, /* Double Function Reset */ + /* Function Reset four times */ + 0x0017ff00, + 0x0017ff00, 0x0017ff00, 0x0017ff00,
@@ -31,7 +31,7 @@ /* Bits 19:8 - Verb ID */ /* Bits 7:0 - Payload */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x19910269 */ + /* NID 0x01, HDA Codec Subsystem ID Verb Table */ 0x00172069, 0x00172102, 0x00172291, @@ -69,25 +69,25 @@ 0x01971ea7, 0x01971f90,
- /* Pin Complex (NID 0x1A) */ + /* Pin Complex (NID 0x1a) */ 0x01a71cf0, 0x01a71d11, 0x01a71e11, 0x01a71f41,
- /* Pin Complex (NID 0x1B) */ + /* Pin Complex (NID 0x1b) */ 0x01b71cf0, 0x01b71d11, 0x01b71e11, 0x01b71f41,
- /* Pin Complex (NID 0x1D) */ + /* Pin Complex (NID 0x1d) */ 0x01d71c05, 0x01d71d9d, 0x01d71e56, 0x01d71f40,
- /* Pin Complex (NID 0x1E) */ + /* Pin Complex (NID 0x1e) */ 0x01e71cf0, 0x01e71d11, 0x01e71e11, diff --git a/src/mainboard/purism/librem_skl/hda_verb.c b/src/mainboard/purism/librem_skl/hda_verb.c index ea89f00..8f72290 100644 --- a/src/mainboard/purism/librem_skl/hda_verb.c +++ b/src/mainboard/purism/librem_skl/hda_verb.c @@ -16,13 +16,13 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ 0x10ec0269, /* Codec Vendor / Device ID: Realtek ALC269 */ 0x19910269, /* Subsystem ID */ - 0x0000000c, /* Number of jacks (NID entries) */ + 12, /* Number of jacks (NID entries) */
- 0x0017ff00, /* Function Reset */ - 0x0017ff00, /* Double Function Reset */ + /* Function Reset four times */ + 0x0017ff00, + 0x0017ff00, 0x0017ff00, 0x0017ff00,
@@ -31,40 +31,20 @@ /* Bits 19:8 - Verb ID */ /* Bits 7:0 - Payload */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x19910269 */ + /* NID 0x01, HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x19910269),
/* Pin Widget Verb Table */ - - /* Pin Complex (NID 0x12) */ AZALIA_PIN_CFG(0x0, 0x12, 0x40000000), - - /* Pin Complex (NID 0x14) */ AZALIA_PIN_CFG(0x0, 0x14, 0x90170110), - - /* Pin Complex (NID 0x15) */ AZALIA_PIN_CFG(0x0, 0x15, 0x04214020), - - /* Pin Complex (NID 0x17) */ AZALIA_PIN_CFG(0x0, 0x17, 0x411111f0), - - /* Pin Complex (NID 0x18) */ AZALIA_PIN_CFG(0x0, 0x18, 0x04a19040), - - /* Pin Complex (NID 0x19) */ AZALIA_PIN_CFG(0x0, 0x19, 0x90a70130), - - /* Pin Complex (NID 0x1A) */ - AZALIA_PIN_CFG(0x0, 0x1A, 0x411111f0), - - /* Pin Complex (NID 0x1B) */ - AZALIA_PIN_CFG(0x0, 0x1B, 0x411111f0), - - /* Pin Complex (NID 0x1D) */ - AZALIA_PIN_CFG(0x0, 0x1D, 0x40548505), - - /* Pin Complex (NID 0x1E) */ - AZALIA_PIN_CFG(0x0, 0x1E, 0x411111f0), + AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0x0, 0x1b, 0x411111f0), + AZALIA_PIN_CFG(0x0, 0x1d, 0x40548505), + AZALIA_PIN_CFG(0x0, 0x1e, 0x411111f0), };
const u32 pc_beep_verbs[] = {}; diff --git a/src/mainboard/razer/blade_stealth_kbl/hda_verb.c b/src/mainboard/razer/blade_stealth_kbl/hda_verb.c index 457d1d9..61c940a 100644 --- a/src/mainboard/razer/blade_stealth_kbl/hda_verb.c +++ b/src/mainboard/razer/blade_stealth_kbl/hda_verb.c @@ -17,11 +17,10 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - - /* Realtek, ALC298 */ - 0x10ec0298, /* Vendor ID */ - 0x1a586752, /* Subsystem ID */ - 12, /* Number of entries */ + /* --- Codec #0 --- */ + 0x10ec0298, /* Vendor ID: Realtek ALC298 */ + 0x1a586752, /* Subsystem ID */ + 12, /* Number of entries */ AZALIA_SUBVENDOR(0, 0x1a586752), AZALIA_PIN_CFG(0, 0x12, 0xb7a60140), AZALIA_PIN_CFG(0, 0x13, 0x40000000), @@ -35,10 +34,10 @@ AZALIA_PIN_CFG(0, 0x1f, 0x411111f0), AZALIA_PIN_CFG(0, 0x21, 0x03211020),
- /* Intel, KabylakeHDMI */ - 0x8086280b, /* Vendor ID */ - 0x80860101, /* Subsystem ID */ - 4, /* Number of entries */ + /* --- Codec #2 --- */ + 0x8086280b, /* Vendor ID: Intel Kaby Lake HDMI */ + 0x80860101, /* Subsystem ID */ + 4, /* Number of entries */ AZALIA_SUBVENDOR(2, 0x80860101), AZALIA_PIN_CFG(2, 0x05, 0x18560010), AZALIA_PIN_CFG(2, 0x06, 0x18560010), @@ -46,4 +45,5 @@ };
const u32 pc_beep_verbs[] = {}; + AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/roda/rk9/hda_verb.c b/src/mainboard/roda/rk9/hda_verb.c index a7d2698..9e58076 100644 --- a/src/mainboard/roda/rk9/hda_verb.c +++ b/src/mainboard/roda/rk9/hda_verb.c @@ -17,36 +17,46 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ 0x10ec0262, /* Codec Vendor / Device ID: Realtek ALC262 */ 0x43528986, /* Subsystem ID */ 0x0000000c, /* Number of entries */
/* Pin Widget Verb Table */
- /* Pin Complex (NID 0x11), S/PDIF-OUT2: not connected */ + /* S/PDIF-OUT2: not connected */ AZALIA_PIN_CFG(0, 0x11, 0x411111f0), - /* Pin Complex (NID 0x14), LINE_OUT (port D): Speakers */ + + /* LINE_OUT (port D): Speakers */ AZALIA_PIN_CFG(0, 0x14, 0x99130110), - /* Pin Complex (NID 0x15), HP_OUT (port A): Head phones */ + + /* HP_OUT (port A): Headphones */ AZALIA_PIN_CFG(0, 0x15, 0x0121411f), - /* Pin Complex (NID 0x16), MONO-OUT: not connected */ + + /* MONO-OUT: not connected */ AZALIA_PIN_CFG(0, 0x16, 0x411111f0), - /* Pin Complex (NID 0x18), MIC1 (port B): Microphone */ + + /* MIC1 (port B): Microphone */ AZALIA_PIN_CFG(0, 0x18, 0x01a19920), - /* Pin Complex (NID 0x19), MIC2 (port F): not connected */ + + /* MIC2 (port F): not connected */ AZALIA_PIN_CFG(0, 0x19, 0x411111f0), - /* Pin Complex (NID 0x1a), LINE1 (port C): Line-In */ + + /* LINE1 (port C): Line-In */ AZALIA_PIN_CFG(0, 0x1a, 0x01813121), - /* Pin Complex (NID 0x1b), LINE2 (port E): MDC */ + + /* LINE2 (port E): MDC */ AZALIA_PIN_CFG(0, 0x1b, 0x9983012f), - /* Pin Complex (NID 0x1c), CD_IN */ + + /* CD_IN */ AZALIA_PIN_CFG(0, 0x1c, 0x593301f0), - /* Pin Complex (NID 0x1d), PCBEEP */ + + /* PCBEEP */ AZALIA_PIN_CFG(0, 0x1d, 0x4014022d), - /* Pin Complex (NID 0x1e), S/PDIF-OUT: not connected */ + + /* S/PDIF-OUT: not connected */ AZALIA_PIN_CFG(0, 0x1e, 0x411111f0), - /* Pin Complex (NID 0x1f), S/PDIF-IN: not connected */ + + /* S/PDIF-IN: not connected */ AZALIA_PIN_CFG(0, 0x1f, 0x411111f0) };
diff --git a/src/mainboard/roda/rv11/variants/rv11/include/variant/hda_verb.h b/src/mainboard/roda/rv11/variants/rv11/include/variant/hda_verb.h index e80edc5..cdfa6fd 100644 --- a/src/mainboard/roda/rv11/variants/rv11/include/variant/hda_verb.h +++ b/src/mainboard/roda/rv11/variants/rv11/include/variant/hda_verb.h @@ -14,54 +14,33 @@ */
const u32 cim_verb_data[] = { - /* coreboot specific header */ 0x10ec0262, /* Codec Vendor / Device ID: Realtek ALC262 */ 0x1a864352, /* Subsystem ID */ - 0x0000000e, /* Number of jacks */ + 14, /* Number of jacks */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x10ec0262 */ + /* HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0, 0x1a864352), - AZALIA_PIN_CFG(0, 0x11, 0x40000000), - AZALIA_PIN_CFG(0, 0x12, 0x90a60140), - AZALIA_PIN_CFG(0, 0x14, 0x90170110), - AZALIA_PIN_CFG(0, 0x15, 0x01214020), - AZALIA_PIN_CFG(0, 0x16, 0x411111f0), - AZALIA_PIN_CFG(0, 0x18, 0x01a19030), - AZALIA_PIN_CFG(0, 0x19, 0x411111f0), - AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), - AZALIA_PIN_CFG(0, 0x1b, 0x411111f0), - AZALIA_PIN_CFG(0, 0x1c, 0x411111f0), - AZALIA_PIN_CFG(0, 0x1d, 0x4036a235), - AZALIA_PIN_CFG(0, 0x1e, 0x411111f0), - AZALIA_PIN_CFG(0, 0x1f, 0x411111f0),
- /* coreboot specific header */ 0x80862806, /* Codec Vendor / Device ID: Intel PantherPoint HDMI */ 0x80860101, /* Subsystem ID */ - 0x00000004, /* Number of jacks */ + 4, /* Number of jacks */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ + /* HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(3, 0x80860101), - - /* Pin Complex (NID 0x05) Digital Out at Int HDMI */ AZALIA_PIN_CFG(3, 0x05, 0x18560010), - - /* Pin Complex (NID 0x06) Digital Out at Int HDMI */ AZALIA_PIN_CFG(3, 0x06, 0x18560020), - - /* Pin Complex (NID 0x07) Digital Out at Int HDMI */ AZALIA_PIN_CFG(3, 0x07, 0x18560030), }; diff --git a/src/mainboard/roda/rv11/variants/rw11/include/variant/hda_verb.h b/src/mainboard/roda/rv11/variants/rw11/include/variant/hda_verb.h index edc5f64..8ffba41 100644 --- a/src/mainboard/roda/rv11/variants/rw11/include/variant/hda_verb.h +++ b/src/mainboard/roda/rv11/variants/rw11/include/variant/hda_verb.h @@ -14,54 +14,33 @@ */
const u32 cim_verb_data[] = { - /* coreboot specific header */ 0x10ec0262, /* Codec Vendor / Device ID: Realtek ALC262 */ 0x1a864352, /* Subsystem ID */ - 0x0000000e, /* Number of jacks */ + 14, /* Number of jacks */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x10ec0262 */ + /* HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0, 0x1a864352), - AZALIA_PIN_CFG(0, 0x11, 0x18561180), - AZALIA_PIN_CFG(0, 0x12, 0x90a60130), - AZALIA_PIN_CFG(0, 0x14, 0x90170110), - AZALIA_PIN_CFG(0, 0x15, 0x03214020), - AZALIA_PIN_CFG(0, 0x16, 0x40000000), - AZALIA_PIN_CFG(0, 0x18, 0x03a19040), - AZALIA_PIN_CFG(0, 0x19, 0x411111f0), - AZALIA_PIN_CFG(0, 0x1a, 0x03813050), - AZALIA_PIN_CFG(0, 0x1b, 0x411111f0), - AZALIA_PIN_CFG(0, 0x1c, 0x411111f0), - AZALIA_PIN_CFG(0, 0x1d, 0x40d6862d), - AZALIA_PIN_CFG(0, 0x1e, 0x411111f0), - AZALIA_PIN_CFG(0, 0x1f, 0x411111f0),
- /* coreboot specific header */ 0x80862806, /* Codec Vendor / Device ID: Intel PantherPoint HDMI */ 0x80860101, /* Subsystem ID */ - 0x00000004, /* Number of jacks */ + 4, /* Number of jacks */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ + /* HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(3, 0x80860101), - - /* Pin Complex (NID 0x05) Digital Out at Int HDMI */ AZALIA_PIN_CFG(3, 0x05, 0x18560010), - - /* Pin Complex (NID 0x06) Digital Out at Int HDMI */ AZALIA_PIN_CFG(3, 0x06, 0x18560020), - - /* Pin Complex (NID 0x07) Digital Out at Int HDMI */ AZALIA_PIN_CFG(3, 0x07, 0x18560030), }; diff --git a/src/mainboard/samsung/lumpy/hda_verb.c b/src/mainboard/samsung/lumpy/hda_verb.c index 252d872..bcf1fdd 100644 --- a/src/mainboard/samsung/lumpy/hda_verb.c +++ b/src/mainboard/samsung/lumpy/hda_verb.c @@ -16,42 +16,30 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10134210, // Codec Vendor / Device ID: Cirrus Logic CS4210 - 0x152D0924, // Subsystem ID - 0x00000007, // Number of jacks + 0x10134210, /* Codec Vendor / Device ID: Cirrus Logic CS4210 */ + 0x152d0924, /* Subsystem ID */ + 7, /* Number of jacks */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x152D0924 */ - AZALIA_SUBVENDOR(0x0, 0x152D0924), + /* HDA Codec Subsystem ID Verb Table */ + AZALIA_SUBVENDOR(0x0, 0x152d0924),
0x00170500,
/* Pin Widget Verb Table */ - - /* Pin Complex (NID 0x05) */ AZALIA_PIN_CFG(0x0, 0x05, 0x022110f0), - - /* Pin Complex (NID 0x06) */ AZALIA_PIN_CFG(0x0, 0x06, 0x901700f0), - - /* Pin Complex (NID 0x07) */ AZALIA_PIN_CFG(0x0, 0x07, 0x02a110f0), - - /* Pin Complex (NID 0x08) */ AZALIA_PIN_CFG(0x0, 0x08, 0x77a70037), - - /* Pin Complex (NID 0x09) */ AZALIA_PIN_CFG(0x0, 0x09, 0xb7a6003e), - - /* Pin Complex (NID 0x0a) */ AZALIA_PIN_CFG(0x0, 0x0a, 0x434510f0) };
const u32 pc_beep_verbs[] = { - 0x00170500, /* power up codec */ - 0x00270500, /* power up DAC */ - 0x00670500, /* power up speaker */ - 0x00670740, /* enable speaker output */ - 0x0023B04B, /* set DAC gain */ + 0x00170500, /* power up codec */ + 0x00270500, /* power up DAC */ + 0x00670500, /* power up speaker */ + 0x00670740, /* enable speaker output */ + 0x0023b04b, /* set DAC gain */ }; + AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/samsung/stumpy/hda_verb.c b/src/mainboard/samsung/stumpy/hda_verb.c index 1fa6e35..6cb23a5 100644 --- a/src/mainboard/samsung/stumpy/hda_verb.c +++ b/src/mainboard/samsung/stumpy/hda_verb.c @@ -16,16 +16,14 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10134210, // Codec Vendor / Device ID: Cirrus Logic CS4210 - 0x10134210, // Subsystem ID - 0x00000007, // Number of jacks + /* --- Codec #0 --- */ + 0x10134210, /* Codec Vendor / Device ID: Cirrus Logic CS4210 */ + 0x10134210, /* Subsystem ID */ + 7, /* Number of jacks */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x10134210 */ + /* HDA Codec Subsystem ID Verb Table */ AZALIA_SUBVENDOR(0x0, 0x10134210),
- /* Pin Widget Verb Table */ - /* Pin Complex (NID 0x05) 1/8 Gray HP Out at Ext Front */ AZALIA_PIN_CFG(0x0, 0x05, 0x022120f0),
@@ -44,13 +42,13 @@ /* Pin Complex (NID 0x0a) Optical Black SPDIF Out at Ext N/A */ AZALIA_PIN_CFG(0x0, 0x0a, 0x434510f0),
- /* coreboot specific header */ - 0x80862805, // Codec Vendor / Device ID: Intel CougarPoint HDMI - 0x80860101, // Subsystem ID - 0x00000004, // Number of jacks + /* --- Codec #3 --- */ + 0x80862805, /* Codec Vendor / Device ID: Intel CougarPoint HDMI */ + 0x80860101, /* Subsystem ID */ + 4, /* Number of jacks */
- /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ - AZALIA_SUBVENDOR(0x0, 0x80860101), + /* HDA Codec Subsystem ID Verb Table */ + AZALIA_SUBVENDOR(0x3, 0x80860101),
/* Pin Complex (NID 0x05) Digital Out at Int HDMI */ AZALIA_PIN_CFG(0x3, 0x05, 0x18560010), @@ -63,10 +61,11 @@ };
const u32 pc_beep_verbs[] = { - 0x00170500, /* power up codec */ - 0x00270500, /* power up DAC */ - 0x00670500, /* power up speaker */ - 0x00670740, /* enable speaker output */ - 0x0023B04B, /* set DAC gain */ + 0x00170500, /* power up codec */ + 0x00270500, /* power up DAC */ + 0x00670500, /* power up speaker */ + 0x00670740, /* enable speaker output */ + 0x0023b04b, /* set DAC gain */ }; + AZALIA_ARRAY_SIZES;
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: [WIP] mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
Patch Set 1:
(28 comments)
It builds? Really?
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/auron/... File src/mainboard/google/auron/variants/buddy/include/variant/hda_verb.h:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/auron/... PS1, Line 22: 14 13, you doofus
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/mccloud/hda_verb.c:
PS1: swap of NID 0x18 and 0x19
removal of guards on .c
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/monroe/hda_verb.c:
PS1: swap of NID 0x18 and 0x19
removal of guards on .c
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/panther/hda_verb.c:
PS1: removal of guards on .c
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/tricky/hda_verb.c:
PS1: swap of NID 0x18 and 0x19
removal of guards on .c
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/zako/hda_verb.c:
PS1: swap of NID 0x18 and 0x19
removal of guards on .c
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/include/variant/hda_verb.h:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 64: UaJ s/UaJ/UAJ
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 70: db s/db/dB
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 76: front s/front/Front
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 82: back s/back/Back
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 82: boost s/boost/Boost
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 100: dVdd s/dVdd/DVDD
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 100: I2c s/I2c/I2C
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 112: eQ s/eQ/EQ
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 112: disable s/disable/Disable
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/link/h... File src/mainboard/google/link/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/link/h... PS1, Line 77: NID 0x01, kill
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/link/h... PS1, Line 112: NID 0x01, kill
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/parrot... File src/mainboard/google/parrot/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/parrot... PS1, Line 127: 0x0 uncorrected bad index
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/stout/... File src/mainboard/google/stout/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/stout/... PS1, Line 24: NID 0x01, kill
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/stout/... PS1, Line 70: NID 0x01, kill
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/intel/coffeel... File src/mainboard/intel/coffeelake_rvp/variants/cfl_h/include/variant/hda_verb.h:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/intel/coffeel... PS1, Line 128: MIc2 s/MIc2/MIC2
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/intel/coffeel... PS1, Line 140: LINe2 s/LINe2/LINE2
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/intel/coffeel... PS1, Line 176: Mic2 s/Mic2/MIC2
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/intel/emerald... File src/mainboard/intel/emeraldlake2/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/intel/emerald... PS1, Line 51: 0x3 corrected bad index
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/intel/wtm2/hd... File src/mainboard/intel/wtm2/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/intel/wtm2/hd... PS1, Line 52: 0x3 corrected bad index
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/kontron/ktqm7... File src/mainboard/kontron/ktqm77/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/kontron/ktqm7... PS1, Line 101: 0x0 uncorrected bad index
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/lenovo/x131e/... File src/mainboard/lenovo/x131e/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/lenovo/x131e/... PS1, Line 65: 0x80860101 kill
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/samsung/stump... File src/mainboard/samsung/stumpy/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/samsung/stump... PS1, Line 51: 0x3 corrected bad index
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: [WIP] mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/facebook/fbg1... File src/mainboard/facebook/fbg1701/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/facebook/fbg1... PS1, Line 48: 0x411111f0 Needs rebase on CB:37836
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/intel/basking... File src/mainboard/intel/baskingridge/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/intel/basking... PS1, Line 52: 0x3 corrected bad index
Hello Alexander Couzens, Evgeny Zinoviev, Patrick Rudolph, Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37840
to look at the new patch set (#2).
Change subject: [WIP] mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
[WIP] mb/**/hda_verb.{c,h}: Clean up remaining files
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@ @ @ @ DO NOT MERGE AS-IS! @ @ @ @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
This is unreviewably large. Also, there are functional changes on a few files, which would need to be factored out.
V2: Functional changes should have been removed.
Change-Id: I9a3bffcb0fa0de35480a767a1e3aa323e0591198 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/amd/padmelon/hda_verb.c M src/mainboard/apple/macbook21/hda_verb.c M src/mainboard/asrock/g41c-gs/hda_verb.c M src/mainboard/asrock/h110m/hda_verb.c M src/mainboard/asus/p5gc-mx/hda_verb.c M src/mainboard/asus/p5qc/hda_verb.c M src/mainboard/asus/p5ql-em/hda_verb.c M src/mainboard/asus/p5qpl-am/hda_verb.c M src/mainboard/asus/p8h61-m_pro/hda_verb.c M src/mainboard/facebook/fbg1701/hda_verb.c M src/mainboard/foxconn/d41s/hda_verb.c M src/mainboard/foxconn/g41s-k/hda_verb.c M src/mainboard/getac/p470/hda_verb.c M src/mainboard/gigabyte/ga-945gcm-s2l/hda_verb.c M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75-d3v/include/variant/hda_verb.h M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3v/include/variant/hda_verb.h M src/mainboard/gigabyte/ga-g41m-es2l/hda_verb.c M src/mainboard/google/auron/variants/auron_paine/include/variant/hda_verb.h M src/mainboard/google/auron/variants/auron_yuna/include/variant/hda_verb.h M src/mainboard/google/auron/variants/buddy/include/variant/hda_verb.h M src/mainboard/google/auron/variants/gandof/include/variant/hda_verb.h M src/mainboard/google/auron/variants/lulu/include/variant/hda_verb.h M src/mainboard/google/beltino/variants/mccloud/hda_verb.c M src/mainboard/google/beltino/variants/monroe/hda_verb.c M src/mainboard/google/beltino/variants/panther/hda_verb.c M src/mainboard/google/beltino/variants/tricky/hda_verb.c M src/mainboard/google/beltino/variants/zako/hda_verb.c M src/mainboard/google/butterfly/hda_verb.c M src/mainboard/google/drallion/variants/drallion/include/variant/hda_verb.h M src/mainboard/google/jecht/hda_verb.c M src/mainboard/google/link/hda_verb.c M src/mainboard/google/parrot/hda_verb.c M src/mainboard/google/sarien/variants/arcada/include/variant/hda_verb.h M src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h M src/mainboard/google/slippy/variants/falco/hda_verb.c M src/mainboard/google/slippy/variants/leon/hda_verb.c M src/mainboard/google/slippy/variants/peppy/hda_verb.c M src/mainboard/google/slippy/variants/wolf/hda_verb.c M src/mainboard/google/stout/hda_verb.c M src/mainboard/hp/8470p/hda_verb.c M src/mainboard/intel/baskingridge/hda_verb.c M src/mainboard/intel/coffeelake_rvp/variants/cfl_h/include/variant/hda_verb.h M src/mainboard/intel/coffeelake_rvp/variants/cfl_s/include/variant/hda_verb.h M src/mainboard/intel/coffeelake_rvp/variants/cml_u/include/variant/hda_verb.h M src/mainboard/intel/coffeelake_rvp/variants/whl_u/include/variant/hda_verb.h M src/mainboard/intel/d510mo/hda_verb.c M src/mainboard/intel/dg41wv/hda_verb.c M src/mainboard/intel/dg43gt/hda_verb.c M src/mainboard/intel/emeraldlake2/hda_verb.c M src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/hda_verb.h M src/mainboard/intel/kblrvp/variants/rvp11/include/variant/hda_verb.h M src/mainboard/intel/kblrvp/variants/rvp3/include/variant/hda_verb.h M src/mainboard/intel/kblrvp/variants/rvp7/include/variant/hda_verb.h M src/mainboard/intel/wtm2/hda_verb.c M src/mainboard/kontron/ktqm77/hda_verb.c M src/mainboard/lenovo/s230u/hda_verb.c M src/mainboard/lenovo/t400/hda_verb.c M src/mainboard/lenovo/t420/hda_verb.c M src/mainboard/lenovo/t420s/hda_verb.c M src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c M src/mainboard/lenovo/t520/hda_verb.c M src/mainboard/lenovo/t530/hda_verb.c M src/mainboard/lenovo/t60/hda_verb.c M src/mainboard/lenovo/thinkcentre_a58/hda_verb.c M src/mainboard/lenovo/x131e/hda_verb.c M src/mainboard/lenovo/x200/hda_verb.c M src/mainboard/lenovo/x220/hda_verb.c M src/mainboard/lenovo/x230/hda_verb.c M src/mainboard/lenovo/x60/hda_verb.c M src/mainboard/purism/librem_bdw/hda_verb.c M src/mainboard/purism/librem_skl/hda_verb.c M src/mainboard/razer/blade_stealth_kbl/hda_verb.c M src/mainboard/roda/rk9/hda_verb.c M src/mainboard/roda/rv11/variants/rv11/include/variant/hda_verb.h M src/mainboard/roda/rv11/variants/rw11/include/variant/hda_verb.h M src/mainboard/samsung/lumpy/hda_verb.c M src/mainboard/samsung/stumpy/hda_verb.c 77 files changed, 2,356 insertions(+), 2,326 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/37840/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: [WIP] mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
Patch Set 2:
(24 comments)
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/auron/... File src/mainboard/google/auron/variants/buddy/include/variant/hda_verb.h:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/auron/... PS1, Line 22: 14
13, you doofus
Done
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/mccloud/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... PS1, Line 59: 0x1a wait wtf
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/monroe/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... PS1, Line 52: 0x1b wait wtf, but I corrected it without realizing
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/panther/hda_verb.c:
PS1:
removal of guards on . […]
missed swap of NID 0x18 and 0x19
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... PS1, Line 57: 0x1a wait wtf
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/tricky/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... PS1, Line 58: 0x1a wait wtf
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/zako/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... PS1, Line 58: 0x1a wait wtf
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/include/variant/hda_verb.h:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 64: UaJ
s/UaJ/UAJ
Done
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 70: db
s/db/dB
Done
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 76: front
s/front/Front
Done
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 82: boost
s/boost/Boost
Done
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 82: back
s/back/Back
Done
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 100: dVdd
s/dVdd/DVDD
Done
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 100: I2c
s/I2c/I2C
Done
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 112: eQ
s/eQ/EQ
Done
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 112: disable
s/disable/Disable
Done
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/link/h... File src/mainboard/google/link/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/link/h... PS1, Line 77: NID 0x01,
kill
Done
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/link/h... PS1, Line 112: NID 0x01,
kill
Done
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/stout/... File src/mainboard/google/stout/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/stout/... PS1, Line 24: NID 0x01,
kill
Done
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/stout/... PS1, Line 70: NID 0x01,
kill
Done
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/intel/coffeel... File src/mainboard/intel/coffeelake_rvp/variants/cfl_h/include/variant/hda_verb.h:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/intel/coffeel... PS1, Line 128: MIc2
s/MIc2/MIC2
Done
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/intel/coffeel... PS1, Line 140: LINe2
s/LINe2/LINE2
Done
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/intel/coffeel... PS1, Line 176: Mic2
s/Mic2/MIC2
Done
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/lenovo/x131e/... File src/mainboard/lenovo/x131e/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/lenovo/x131e/... PS1, Line 65: 0x80860101
kill
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: [WIP] mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37840/2/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/panther/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/2/src/mainboard/google/beltin... PS2, Line 45: /* Pin Complex (NID 0x18) MIC1 PORTB grrr...
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: [WIP] mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
Patch Set 3:
(10 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/mccloud/hda_verb.c:
PS1:
swap of NID 0x18 and 0x19 […]
Done with CB:37851 and CB:37852
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... PS1, Line 59: 0x1a
wait wtf
Done with CB:37851 and CB:37852
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/monroe/hda_verb.c:
PS1:
swap of NID 0x18 and 0x19 […]
Done with CB:37851 and CB:37852
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... PS1, Line 52: 0x1b
wait wtf, but I corrected it without realizing
Done with CB:37851 and CB:37852
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/panther/hda_verb.c:
PS1:
missed swap of NID 0x18 and 0x19
Done with CB:37851 and CB:37852
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... PS1, Line 57: 0x1a
wait wtf
Done with CB:37851 and CB:37852
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/tricky/hda_verb.c:
PS1:
swap of NID 0x18 and 0x19 […]
Done with CB:37851 and CB:37852
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... PS1, Line 58: 0x1a
wait wtf
Done with CB:37851 and CB:37852
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/zako/hda_verb.c:
PS1:
swap of NID 0x18 and 0x19 […]
Done with CB:37851 and CB:37852
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... PS1, Line 58: 0x1a
wait wtf
Done with CB:37851 and CB:37852
Hello Alexander Couzens, Evgeny Zinoviev, Patrick Rudolph, Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37840
to look at the new patch set (#4).
Change subject: mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
mb/**/hda_verb.{c,h}: Clean up remaining files
Change-Id: I9a3bffcb0fa0de35480a767a1e3aa323e0591198 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/amd/padmelon/hda_verb.c M src/mainboard/apple/macbook21/hda_verb.c M src/mainboard/asrock/g41c-gs/hda_verb.c M src/mainboard/asrock/h110m/hda_verb.c M src/mainboard/asus/p5gc-mx/hda_verb.c M src/mainboard/asus/p5qc/hda_verb.c M src/mainboard/asus/p5ql-em/hda_verb.c M src/mainboard/asus/p5qpl-am/hda_verb.c M src/mainboard/asus/p8h61-m_pro/hda_verb.c M src/mainboard/facebook/fbg1701/hda_verb.c M src/mainboard/foxconn/d41s/hda_verb.c M src/mainboard/foxconn/g41s-k/hda_verb.c M src/mainboard/getac/p470/hda_verb.c M src/mainboard/gigabyte/ga-945gcm-s2l/hda_verb.c M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75-d3v/include/variant/hda_verb.h M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3v/include/variant/hda_verb.h M src/mainboard/gigabyte/ga-g41m-es2l/hda_verb.c M src/mainboard/google/auron/variants/auron_paine/include/variant/hda_verb.h M src/mainboard/google/auron/variants/auron_yuna/include/variant/hda_verb.h M src/mainboard/google/auron/variants/buddy/include/variant/hda_verb.h M src/mainboard/google/auron/variants/gandof/include/variant/hda_verb.h M src/mainboard/google/auron/variants/lulu/include/variant/hda_verb.h M src/mainboard/google/beltino/variants/mccloud/hda_verb.c M src/mainboard/google/beltino/variants/monroe/hda_verb.c M src/mainboard/google/beltino/variants/panther/hda_verb.c M src/mainboard/google/beltino/variants/tricky/hda_verb.c M src/mainboard/google/beltino/variants/zako/hda_verb.c M src/mainboard/google/butterfly/hda_verb.c M src/mainboard/google/drallion/variants/drallion/include/variant/hda_verb.h M src/mainboard/google/jecht/hda_verb.c M src/mainboard/google/link/hda_verb.c M src/mainboard/google/parrot/hda_verb.c M src/mainboard/google/sarien/variants/arcada/include/variant/hda_verb.h M src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h M src/mainboard/google/slippy/variants/falco/hda_verb.c M src/mainboard/google/slippy/variants/leon/hda_verb.c M src/mainboard/google/slippy/variants/peppy/hda_verb.c M src/mainboard/google/slippy/variants/wolf/hda_verb.c M src/mainboard/google/stout/hda_verb.c M src/mainboard/hp/8470p/hda_verb.c M src/mainboard/intel/baskingridge/hda_verb.c M src/mainboard/intel/coffeelake_rvp/variants/cfl_h/include/variant/hda_verb.h M src/mainboard/intel/coffeelake_rvp/variants/cfl_s/include/variant/hda_verb.h M src/mainboard/intel/coffeelake_rvp/variants/cml_u/include/variant/hda_verb.h M src/mainboard/intel/coffeelake_rvp/variants/whl_u/include/variant/hda_verb.h M src/mainboard/intel/d510mo/hda_verb.c M src/mainboard/intel/dg41wv/hda_verb.c M src/mainboard/intel/dg43gt/hda_verb.c M src/mainboard/intel/emeraldlake2/hda_verb.c M src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/hda_verb.h M src/mainboard/intel/kblrvp/variants/rvp11/include/variant/hda_verb.h M src/mainboard/intel/kblrvp/variants/rvp3/include/variant/hda_verb.h M src/mainboard/intel/kblrvp/variants/rvp7/include/variant/hda_verb.h M src/mainboard/intel/wtm2/hda_verb.c M src/mainboard/kontron/ktqm77/hda_verb.c M src/mainboard/lenovo/s230u/hda_verb.c M src/mainboard/lenovo/t400/hda_verb.c M src/mainboard/lenovo/t420/hda_verb.c M src/mainboard/lenovo/t420s/hda_verb.c M src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c M src/mainboard/lenovo/t520/hda_verb.c M src/mainboard/lenovo/t530/hda_verb.c M src/mainboard/lenovo/t60/hda_verb.c M src/mainboard/lenovo/thinkcentre_a58/hda_verb.c M src/mainboard/lenovo/x131e/hda_verb.c M src/mainboard/lenovo/x200/hda_verb.c M src/mainboard/lenovo/x220/hda_verb.c M src/mainboard/lenovo/x230/hda_verb.c M src/mainboard/lenovo/x60/hda_verb.c M src/mainboard/purism/librem_bdw/hda_verb.c M src/mainboard/purism/librem_skl/hda_verb.c M src/mainboard/razer/blade_stealth_kbl/hda_verb.c M src/mainboard/roda/rk9/hda_verb.c M src/mainboard/roda/rv11/variants/rv11/include/variant/hda_verb.h M src/mainboard/roda/rv11/variants/rw11/include/variant/hda_verb.h M src/mainboard/samsung/lumpy/hda_verb.c M src/mainboard/samsung/stumpy/hda_verb.c 77 files changed, 2,365 insertions(+), 2,334 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/37840/4
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... File src/mainboard/google/auron/variants/buddy/include/variant/hda_verb.h:
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... PS3, Line 20: /* coreboot specific header */ why remove this comment?
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... PS3, Line 35: : 0x10ec0283 and this one? it helps a reader understand the verb contents
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... File src/mainboard/google/auron/variants/buddy/include/variant/hda_verb.h:
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... PS3, Line 20: /* coreboot specific header */
why remove this comment?
I'm not sure. I felt it did not provide much information.
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... PS3, Line 35: : 0x10ec0283
and this one? it helps a reader understand the verb contents
These 4 magic hex numbers should be equivalent to an AZALIA_SUBVENDOR macro. With the macro, this comment becomes redundant, and is the reason why I removed it on other files. If I find some time, I'll try rewriting this file using macros, which would make it more readable I hope.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... File src/mainboard/google/auron/variants/buddy/include/variant/hda_verb.h:
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... PS3, Line 20: /* coreboot specific header */
I'm not sure. I felt it did not provide much information.
Ack
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... PS3, Line 35: : 0x10ec0283
These 4 magic hex numbers should be equivalent to an AZALIA_SUBVENDOR macro. […]
yeah it would be no issue obv if using the subvendor macro
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... PS3, Line 22: 13, since this is a quad-byte word like all the rest of the verb data, seems odd to change format here, even for readability
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... PS3, Line 49: 0x01471c10, /* group 1, cap 0 */ : 0x01471d01, /* no connector, no jack detect */ : 0x01471e17, /* speaker out, analog */ : 0x01471f90, /* fixed function, internal, Location N/A */ probably easier just to convert to the azalia macros and then have a single comment block, no?
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
Patch Set 4: Code-Review+1
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
Patch Set 4: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37840/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37840/4//COMMIT_MSG@8 PS4, Line 8: What are you cleaning up?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37840/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37840/4//COMMIT_MSG@8 PS4, Line 8:
What are you cleaning up?
Good question. Primarily:
- Use lowercase for the letters of hex constants e.g.: 0xDEADBEEF --> 0xdeadbeef - Use C-style comments everywhere - Use denary (decimal) for length values
I also felt that some comments were not informative enough to keep, so I dropped them. The most painful comments are those with the same hex constant used in the code right below.
As to why I did this... I felt like it ¯_(ツ)_/¯
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... File src/mainboard/google/auron/variants/buddy/include/variant/hda_verb.h:
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... PS3, Line 22: 13,
since this is a quad-byte word like all the rest of the verb data, seems odd to change format here, […]
Nico told me to use decimal for these values instead of hex in CB:37483
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... PS3, Line 49: 0x01471c10, /* group 1, cap 0 */ : 0x01471d01, /* no connector, no jack detect */ : 0x01471e17, /* speaker out, analog */ : 0x01471f90, /* fixed function, internal, Location N/A */
probably easier just to convert to the azalia macros and then have a single comment block, no?
Indeed. Should I do it on a separate change?
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... File src/mainboard/google/auron/variants/buddy/include/variant/hda_verb.h:
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... PS3, Line 22: 13,
Nico told me to use decimal for these values instead of hex in CB:37483
Ack
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... PS3, Line 49: 0x01471c10, /* group 1, cap 0 */ : 0x01471d01, /* no connector, no jack detect */ : 0x01471e17, /* speaker out, analog */ : 0x01471f90, /* fixed function, internal, Location N/A */
Indeed. […]
I'd probably do that first, then the cleanup patch on top would be smaller
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/facebook/fbg1... File src/mainboard/facebook/fbg1701/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/facebook/fbg1... PS1, Line 48: 0x411111f0
Needs rebase on CB:37836
That change is merged now.
Hello Alexander Couzens, Evgeny Zinoviev, Patrick Rudolph, Wim Vervoorn, Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37840
to look at the new patch set (#5).
Change subject: mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
mb/**/hda_verb.{c,h}: Clean up remaining files
Change-Id: I9a3bffcb0fa0de35480a767a1e3aa323e0591198 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/amd/padmelon/hda_verb.c M src/mainboard/apple/macbook21/hda_verb.c M src/mainboard/asrock/g41c-gs/hda_verb.c M src/mainboard/asus/p5gc-mx/hda_verb.c M src/mainboard/asus/p5qc/hda_verb.c M src/mainboard/asus/p5ql-em/hda_verb.c M src/mainboard/asus/p5qpl-am/hda_verb.c M src/mainboard/asus/p8h61-m_pro/hda_verb.c M src/mainboard/facebook/fbg1701/hda_verb.c M src/mainboard/foxconn/d41s/hda_verb.c M src/mainboard/foxconn/g41s-k/hda_verb.c M src/mainboard/getac/p470/hda_verb.c M src/mainboard/gigabyte/ga-945gcm-s2l/hda_verb.c M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75-d3v/include/variant/hda_verb.h M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3v/include/variant/hda_verb.h M src/mainboard/gigabyte/ga-g41m-es2l/hda_verb.c M src/mainboard/google/auron/variants/auron_paine/include/variant/hda_verb.h M src/mainboard/google/auron/variants/auron_yuna/include/variant/hda_verb.h M src/mainboard/google/auron/variants/buddy/include/variant/hda_verb.h M src/mainboard/google/auron/variants/gandof/include/variant/hda_verb.h M src/mainboard/google/auron/variants/lulu/include/variant/hda_verb.h M src/mainboard/google/beltino/variants/mccloud/hda_verb.c M src/mainboard/google/beltino/variants/monroe/hda_verb.c M src/mainboard/google/beltino/variants/panther/hda_verb.c M src/mainboard/google/beltino/variants/tricky/hda_verb.c M src/mainboard/google/beltino/variants/zako/hda_verb.c M src/mainboard/google/butterfly/hda_verb.c M src/mainboard/google/drallion/variants/drallion/include/variant/hda_verb.h M src/mainboard/google/jecht/hda_verb.c M src/mainboard/google/link/hda_verb.c M src/mainboard/google/parrot/hda_verb.c M src/mainboard/google/sarien/variants/arcada/include/variant/hda_verb.h M src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h M src/mainboard/google/slippy/variants/falco/hda_verb.c M src/mainboard/google/slippy/variants/leon/hda_verb.c M src/mainboard/google/slippy/variants/peppy/hda_verb.c M src/mainboard/google/slippy/variants/wolf/hda_verb.c M src/mainboard/google/stout/hda_verb.c M src/mainboard/hp/8470p/hda_verb.c M src/mainboard/intel/baskingridge/hda_verb.c M src/mainboard/intel/coffeelake_rvp/variants/cfl_h/include/variant/hda_verb.h M src/mainboard/intel/coffeelake_rvp/variants/cfl_s/include/variant/hda_verb.h M src/mainboard/intel/coffeelake_rvp/variants/cml_u/include/variant/hda_verb.h M src/mainboard/intel/coffeelake_rvp/variants/whl_u/include/variant/hda_verb.h M src/mainboard/intel/d510mo/hda_verb.c M src/mainboard/intel/dg41wv/hda_verb.c M src/mainboard/intel/dg43gt/hda_verb.c M src/mainboard/intel/emeraldlake2/hda_verb.c M src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/hda_verb.h M src/mainboard/intel/kblrvp/variants/rvp11/include/variant/hda_verb.h M src/mainboard/intel/kblrvp/variants/rvp3/include/variant/hda_verb.h M src/mainboard/intel/kblrvp/variants/rvp7/include/variant/hda_verb.h M src/mainboard/intel/wtm2/hda_verb.c M src/mainboard/kontron/ktqm77/hda_verb.c M src/mainboard/lenovo/s230u/hda_verb.c M src/mainboard/lenovo/t400/hda_verb.c M src/mainboard/lenovo/t420/hda_verb.c M src/mainboard/lenovo/t420s/hda_verb.c M src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c M src/mainboard/lenovo/t520/hda_verb.c M src/mainboard/lenovo/t530/hda_verb.c M src/mainboard/lenovo/t60/hda_verb.c M src/mainboard/lenovo/thinkcentre_a58/hda_verb.c M src/mainboard/lenovo/x131e/hda_verb.c M src/mainboard/lenovo/x200/hda_verb.c M src/mainboard/lenovo/x220/hda_verb.c M src/mainboard/lenovo/x230/hda_verb.c M src/mainboard/lenovo/x60/hda_verb.c M src/mainboard/purism/librem_bdw/hda_verb.c M src/mainboard/purism/librem_skl/hda_verb.c M src/mainboard/razer/blade_stealth_kbl/hda_verb.c M src/mainboard/roda/rk9/hda_verb.c M src/mainboard/roda/rv11/variants/rv11/include/variant/hda_verb.h M src/mainboard/roda/rv11/variants/rw11/include/variant/hda_verb.h M src/mainboard/samsung/lumpy/hda_verb.c M src/mainboard/samsung/stumpy/hda_verb.c 76 files changed, 2,364 insertions(+), 2,331 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/37840/5
Hello Alexander Couzens, Evgeny Zinoviev, Patrick Rudolph, Wim Vervoorn, Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37840
to look at the new patch set (#6).
Change subject: mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
mb/**/hda_verb.{c,h}: Clean up remaining files
Change-Id: I9a3bffcb0fa0de35480a767a1e3aa323e0591198 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/amd/padmelon/hda_verb.c M src/mainboard/apple/macbook21/hda_verb.c M src/mainboard/asrock/g41c-gs/hda_verb.c M src/mainboard/asus/p5gc-mx/hda_verb.c M src/mainboard/asus/p5qc/hda_verb.c M src/mainboard/asus/p5ql-em/hda_verb.c M src/mainboard/asus/p5qpl-am/hda_verb.c M src/mainboard/asus/p8h61-m_pro/hda_verb.c M src/mainboard/facebook/fbg1701/hda_verb.c M src/mainboard/foxconn/d41s/hda_verb.c M src/mainboard/foxconn/g41s-k/hda_verb.c M src/mainboard/getac/p470/hda_verb.c M src/mainboard/gigabyte/ga-945gcm-s2l/hda_verb.c M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75-d3v/include/variant/hda_verb.h M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3v/include/variant/hda_verb.h M src/mainboard/gigabyte/ga-g41m-es2l/hda_verb.c M src/mainboard/google/auron/variants/auron_paine/include/variant/hda_verb.h M src/mainboard/google/auron/variants/auron_yuna/include/variant/hda_verb.h M src/mainboard/google/auron/variants/buddy/include/variant/hda_verb.h M src/mainboard/google/auron/variants/gandof/include/variant/hda_verb.h M src/mainboard/google/auron/variants/lulu/include/variant/hda_verb.h M src/mainboard/google/beltino/variants/mccloud/hda_verb.c M src/mainboard/google/beltino/variants/monroe/hda_verb.c M src/mainboard/google/beltino/variants/panther/hda_verb.c M src/mainboard/google/beltino/variants/tricky/hda_verb.c M src/mainboard/google/beltino/variants/zako/hda_verb.c M src/mainboard/google/butterfly/hda_verb.c M src/mainboard/google/drallion/variants/drallion/include/variant/hda_verb.h M src/mainboard/google/jecht/hda_verb.c M src/mainboard/google/link/hda_verb.c M src/mainboard/google/parrot/hda_verb.c M src/mainboard/google/sarien/variants/arcada/include/variant/hda_verb.h M src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h M src/mainboard/google/slippy/variants/falco/hda_verb.c M src/mainboard/google/slippy/variants/leon/hda_verb.c M src/mainboard/google/slippy/variants/peppy/hda_verb.c M src/mainboard/google/slippy/variants/wolf/hda_verb.c M src/mainboard/google/stout/hda_verb.c M src/mainboard/hp/8470p/hda_verb.c M src/mainboard/intel/baskingridge/hda_verb.c M src/mainboard/intel/coffeelake_rvp/variants/cfl_h/include/variant/hda_verb.h M src/mainboard/intel/coffeelake_rvp/variants/cfl_s/include/variant/hda_verb.h M src/mainboard/intel/coffeelake_rvp/variants/cml_u/include/variant/hda_verb.h M src/mainboard/intel/coffeelake_rvp/variants/whl_u/include/variant/hda_verb.h M src/mainboard/intel/d510mo/hda_verb.c M src/mainboard/intel/dg41wv/hda_verb.c M src/mainboard/intel/dg43gt/hda_verb.c M src/mainboard/intel/emeraldlake2/hda_verb.c M src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/hda_verb.h M src/mainboard/intel/kblrvp/variants/rvp11/include/variant/hda_verb.h M src/mainboard/intel/kblrvp/variants/rvp3/include/variant/hda_verb.h M src/mainboard/intel/kblrvp/variants/rvp7/include/variant/hda_verb.h M src/mainboard/intel/wtm2/hda_verb.c M src/mainboard/kontron/ktqm77/hda_verb.c M src/mainboard/lenovo/s230u/hda_verb.c M src/mainboard/lenovo/t400/hda_verb.c M src/mainboard/lenovo/t420/hda_verb.c M src/mainboard/lenovo/t420s/hda_verb.c M src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c M src/mainboard/lenovo/t520/hda_verb.c M src/mainboard/lenovo/t530/hda_verb.c M src/mainboard/lenovo/t60/hda_verb.c M src/mainboard/lenovo/thinkcentre_a58/hda_verb.c M src/mainboard/lenovo/x131e/hda_verb.c M src/mainboard/lenovo/x200/hda_verb.c M src/mainboard/lenovo/x220/hda_verb.c M src/mainboard/lenovo/x230/hda_verb.c M src/mainboard/lenovo/x60/hda_verb.c M src/mainboard/purism/librem_bdw/hda_verb.c M src/mainboard/purism/librem_skl/hda_verb.c M src/mainboard/razer/blade_stealth_kbl/hda_verb.c M src/mainboard/roda/rk9/hda_verb.c M src/mainboard/roda/rv11/variants/rv11/include/variant/hda_verb.h M src/mainboard/roda/rv11/variants/rw11/include/variant/hda_verb.h M src/mainboard/samsung/lumpy/hda_verb.c M src/mainboard/samsung/stumpy/hda_verb.c 76 files changed, 2,368 insertions(+), 2,335 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/37840/6
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
Patch Set 6:
I think it would be helpful to generalize the changes made in the commit msg. Without looking at each file, it's impossible to know what "clean up" means in the context of the commit.
It appears that this change shouldn't result in any difference to a reproducible build for any of the affected boards, which if true should be called out
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
Patch Set 6: Code-Review+1
I agree with Matt’s suggestion. It’d be great to get this into the next release.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
Patch Set 6: Code-Review+1
Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
Abandoned
-
Angel Pons (Code Review) -
Frans Hendriks (Code Review)
-
Matt DeVillier (Code Review)
-
Paul Menzel (Code Review)
-
Wim Vervoorn (Code Review)