HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33814
Change subject: arch/x86/: Fix cpu_cpuid_extended_level() returned value ......................................................................
arch/x86/: Fix cpu_cpuid_extended_level() returned value
Change-Id: Iebb6501130bc9ae333d45ae9d2e10c918245a6d1 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/x86/cpu_common.c M src/arch/x86/include/arch/cpu.h 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/33814/1
diff --git a/src/arch/x86/cpu_common.c b/src/arch/x86/cpu_common.c index 1191227..0fd0af0 100644 --- a/src/arch/x86/cpu_common.c +++ b/src/arch/x86/cpu_common.c @@ -49,7 +49,7 @@ } #endif
-int cpu_cpuid_extended_level(void) +unsigned int cpu_cpuid_extended_level(void) { return cpuid_eax(0x80000000); } diff --git a/src/arch/x86/include/arch/cpu.h b/src/arch/x86/include/arch/cpu.h index ff1a33b..75f1f43 100644 --- a/src/arch/x86/include/arch/cpu.h +++ b/src/arch/x86/include/arch/cpu.h @@ -200,7 +200,7 @@ #define CPUID_CACHE_NO_OF_SETS_MASK 0xffffffff #define CPUID_CACHE_NO_OF_SETS(res) CPUID_CACHE(NO_OF_SETS, (res).ecx)
-int cpu_cpuid_extended_level(void); +unsigned int cpu_cpuid_extended_level(void); int cpu_have_cpuid(void);
void smm_init(void);
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33814 )
Change subject: arch/x86/: Fix cpu_cpuid_extended_level() returned value ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/33814/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33814/1//COMMIT_MSG@7 PS1, Line 7: returned value "return type"
Hello Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33814
to look at the new patch set (#2).
Change subject: arch/x86/: Fix cpu_cpuid_extended_level() return type ......................................................................
arch/x86/: Fix cpu_cpuid_extended_level() return type
Change-Id: Iebb6501130bc9ae333d45ae9d2e10c918245a6d1 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/x86/cpu_common.c M src/arch/x86/include/arch/cpu.h 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/33814/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33814 )
Change subject: arch/x86/: Fix cpu_cpuid_extended_level() return type ......................................................................
Patch Set 2:
(1 comment)
Thx
https://review.coreboot.org/#/c/33814/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33814/1//COMMIT_MSG@7 PS1, Line 7: returned value
"return type"
Done
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33814 )
Change subject: arch/x86/: Fix cpu_cpuid_extended_level() return type ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33814 )
Change subject: arch/x86/: Fix cpu_cpuid_extended_level() return type ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/33814/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33814/2//COMMIT_MSG@7 PS2, Line 7: arch/x86/ Please remove the last /.
https://review.coreboot.org/#/c/33814/2//COMMIT_MSG@8 PS2, Line 8: Please elaborate.
`cpuid_eax()` returns an unsigned integer.
Martin Roth has uploaded a new patch set (#3) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/33814 )
Change subject: arch/x86: Fix cpu_cpuid_extended_level() return type ......................................................................
arch/x86: Fix cpu_cpuid_extended_level() return type
`cpuid_eax()` returns an unsigned integer.
Change-Id: Iebb6501130bc9ae333d45ae9d2e10c918245a6d1 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/x86/cpu_common.c M src/arch/x86/include/arch/cpu.h 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/33814/3
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33814 )
Change subject: arch/x86: Fix cpu_cpuid_extended_level() return type ......................................................................
arch/x86: Fix cpu_cpuid_extended_level() return type
`cpuid_eax()` returns an unsigned integer.
Change-Id: Iebb6501130bc9ae333d45ae9d2e10c918245a6d1 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33814 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subrata.banik@intel.com Reviewed-by: Nico Huber nico.h@gmx.de --- M src/arch/x86/cpu_common.c M src/arch/x86/include/arch/cpu.h 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Subrata Banik: Looks good to me, approved
diff --git a/src/arch/x86/cpu_common.c b/src/arch/x86/cpu_common.c index 1191227..0fd0af0 100644 --- a/src/arch/x86/cpu_common.c +++ b/src/arch/x86/cpu_common.c @@ -49,7 +49,7 @@ } #endif
-int cpu_cpuid_extended_level(void) +unsigned int cpu_cpuid_extended_level(void) { return cpuid_eax(0x80000000); } diff --git a/src/arch/x86/include/arch/cpu.h b/src/arch/x86/include/arch/cpu.h index ff1a33b..75f1f43 100644 --- a/src/arch/x86/include/arch/cpu.h +++ b/src/arch/x86/include/arch/cpu.h @@ -200,7 +200,7 @@ #define CPUID_CACHE_NO_OF_SETS_MASK 0xffffffff #define CPUID_CACHE_NO_OF_SETS(res) CPUID_CACHE(NO_OF_SETS, (res).ecx)
-int cpu_cpuid_extended_level(void); +unsigned int cpu_cpuid_extended_level(void); int cpu_have_cpuid(void);
void smm_init(void);
-
HAOUAS Elyes (Code Review) -
Martin Roth (Code Review)
-
Nico Huber (Code Review)
-
Paul Menzel (Code Review)
-
Subrata Banik (Code Review)