Bora Guvendik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33642
Change subject: [WIP] 3rdparty/fsp: Update submodule pointer ......................................................................
[WIP] 3rdparty/fsp: Update submodule pointer
Update fsp submodule pointer to Coffee Lake FSP 7.0.64.40
Change-Id: I864404a03be63aa60e81db21af16d69cda2d4e12 Signed-off-by: Bora Guvendik bora.guvendik@intel.com --- M 3rdparty/fsp 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/33642/1
diff --git a/3rdparty/fsp b/3rdparty/fsp index 1d2b7e1..5996417 160000 --- a/3rdparty/fsp +++ b/3rdparty/fsp @@ -1 +1 @@ -Subproject commit 1d2b7e1a94c6a7c25a6fed1ac37caebf500f5f1a +Subproject commit 59964173e18950debcc6b8856c5c928935ce0b4f
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33642
to look at the new patch set (#2).
Change subject: [WIP] 3rdparty/fsp: Update submodule pointer ......................................................................
[WIP] 3rdparty/fsp: Update submodule pointer
Update fsp submodule pointer to Coffee Lake FSP 7.0.64.40
Change-Id: I864404a03be63aa60e81db21af16d69cda2d4e12 Signed-off-by: Bora Guvendik bora.guvendik@intel.com --- M 3rdparty/fsp 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/33642/2
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33642 )
Change subject: [WIP] 3rdparty/fsp: Update submodule pointer ......................................................................
Patch Set 2: Code-Review+1
tested on out-of-tree WHL-U board
Hello Matt DeVillier, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33642
to look at the new patch set (#3).
Change subject: 3rdparty/fsp: Update submodule pointer ......................................................................
3rdparty/fsp: Update submodule pointer
Update fsp submodule pointer to Coffee Lake FSP 7.0.64.40
Change-Id: I864404a03be63aa60e81db21af16d69cda2d4e12 Signed-off-by: Bora Guvendik bora.guvendik@intel.com --- M 3rdparty/fsp 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/33642/3
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33642 )
Change subject: 3rdparty/fsp: Update submodule pointer ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/33642/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33642/3//COMMIT_MSG@9 PS3, Line 9: Update fsp submodule pointer to Coffee Lake FSP 7.0.64.40 Would you like to include a link to github commit so people can tell? Like https://github.com/IntelFsp/FSP/commit/59964173e18950debcc6b8856c5c928935ce0...
Hello Subrata Banik, Selma Bensaid, Matt DeVillier, Duncan Laurie, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33642
to look at the new patch set (#4).
Change subject: 3rdparty/fsp: Update submodule pointer ......................................................................
3rdparty/fsp: Update submodule pointer
Update fsp submodule pointer to Coffee Lake FSP 7.0.64.40
github commit: https://github.com/IntelFsp/FSP/commit/59964173e18950debcc6b8856c5c928935ce0...
Change-Id: I864404a03be63aa60e81db21af16d69cda2d4e12 Signed-off-by: Bora Guvendik bora.guvendik@intel.com --- M 3rdparty/fsp 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/33642/4
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33642 )
Change subject: 3rdparty/fsp: Update submodule pointer ......................................................................
Patch Set 4:
(1 comment)
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/33642/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33642/3//COMMIT_MSG@9 PS3, Line 9: Update fsp submodule pointer to Coffee Lake FSP 7.0.64.40
Would you like to include a link to github commit so people can tell? Like […]
Done
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33642 )
Change subject: 3rdparty/fsp: Update submodule pointer ......................................................................
Patch Set 4: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33642 )
Change subject: 3rdparty/fsp: Update submodule pointer ......................................................................
3rdparty/fsp: Update submodule pointer
Update fsp submodule pointer to Coffee Lake FSP 7.0.64.40
github commit: https://github.com/IntelFsp/FSP/commit/59964173e18950debcc6b8856c5c928935ce0...
Change-Id: I864404a03be63aa60e81db21af16d69cda2d4e12 Signed-off-by: Bora Guvendik bora.guvendik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/33642 Reviewed-by: Lijian Zhao lijian.zhao@intel.com Reviewed-by: Matt DeVillier matt.devillier@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M 3rdparty/fsp 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, but someone else must approve Lijian Zhao: Looks good to me, approved
diff --git a/3rdparty/fsp b/3rdparty/fsp index 1d2b7e1..5996417 160000 --- a/3rdparty/fsp +++ b/3rdparty/fsp @@ -1 +1 @@ -Subproject commit 1d2b7e1a94c6a7c25a6fed1ac37caebf500f5f1a +Subproject commit 59964173e18950debcc6b8856c5c928935ce0b4f
-
Bora Guvendik (Code Review) -
Lijian Zhao (Code Review)
-
Martin Roth (Code Review)
-
Matt DeVillier (Code Review)