Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik.
Qinghong Zeng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81265?usp=email )
Change subject: mb/google/nissa/var/anraggar: Update touchscreen enable pin to GPP_C0 ......................................................................
Patch Set 5:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81265/comment/afedde26_e6936fba : PS4, Line 7: Assign GPP_C0 as TouchScreen enable pin
Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/81265/comment/a18f33ae_66514d67 : PS4, Line 7: TouchScreen
touchscreen
Done
https://review.coreboot.org/c/coreboot/+/81265/comment/cc7c3136_d080ae17 : PS4, Line 9: effectively : reduce the power consumption
Please add the measurements.
Done
https://review.coreboot.org/c/coreboot/+/81265/comment/b8a5672f_1dcdfd04 : PS4, Line 10: Suspend
suspend (S0ix?)
Yes
https://review.coreboot.org/c/coreboot/+/81265/comment/f71c2cff_0d1066a1 : PS4, Line 11:
What is the source of this change? Schematics? Why was GPP_C6 used before?
Yes, the schematic has been changed. GPP_C6 was used before for code integrity. GPP_C6 has no actual VDD enable control function.