Change in ...coreboot[master]: mb/ocp/monolake: Add board.fmd

[David Hendricks (Code Review)]

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32260

Change subject: mb/ocp/monolake: Add board.fmd
......................................................................

mb/ocp/monolake: Add board.fmd

Change-Id: I6095c3b30990b530c5bc4e2c808879252680e1d7
Signed-off-by: Andrea Barberio 
Signed-off-by: David Hendricks 
---
A src/mainboard/ocp/monolake/board.fmd
1 file changed, 22 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/32260/1

diff --git a/src/mainboard/ocp/monolake/board.fmd b/src/mainboard/ocp/monolake/board.fmd
new file mode 100644
index 0000000..d0265e4
--- /dev/null
+++ b/src/mainboard/ocp/monolake/board.fmd
@@ -0,0 +1,22 @@
+FLASH@0xff000000 0x1000000 {
+	SI_ALL@0x0 0x800000 {
+		SI_DESC@0x0 0x1000
+		SI_ME@0x1000 0x7ff000
+	}
+	SI_BIOS@0x800000 0x800000 {
+		FMAP@0x0 0x1000
+		RW_MISC@0x1000 0x9000 {
+			RW_ELOG@0x0 0x4000
+			RW_VPD@0x4000 0x2000
+			RW_NVRAM@0x6000 0x2000
+		}
+		UNUSED@0xa000 0x4000 {
+			# This only exists to satisfy tools that
+			# specifically look for RO_VPD.
+			RO_VPD@0x0 0x4000
+		}
+		RW_MRC_CACHE@0xE000 0x10000
+		CONSOLE@0x1E000 0x10000
+		COREBOOT(CBFS)@0x2E000 0x7d2000
+	}
+}

[David Hendricks (Code Review)]

Hello Patrick Rudolph, insomniac, Philipp Deppenwiese, John Looney,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32260

to look at the new patch set (#2).

Change subject: mb/ocp/monolake: Add board.fmd
......................................................................

mb/ocp/monolake: Add board.fmd

Change-Id: I6095c3b30990b530c5bc4e2c808879252680e1d7
Signed-off-by: Andrea Barberio 
Signed-off-by: David Hendricks 
---
M src/mainboard/ocp/monolake/Kconfig
A src/mainboard/ocp/monolake/board.fmd
2 files changed, 27 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/32260/2

[Name of user not set (Code Review)]

Name of user not set #1002246 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32260 )

Change subject: mb/ocp/monolake: Add board.fmd
......................................................................

Patch Set 2: Code-Review+1

[David Hendricks (Code Review)]

Hello Patrick Rudolph, Name of user not set #1002246, insomniac, Philipp Deppenwiese, build bot (Jenkins), John Looney,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32260

to look at the new patch set (#3).

Change subject: mb/ocp/monolake: Add board.fmd
......................................................................

mb/ocp/monolake: Add board.fmd

Change-Id: I6095c3b30990b530c5bc4e2c808879252680e1d7
Signed-off-by: Andrea Barberio 
Signed-off-by: David Hendricks 
---
M src/mainboard/ocp/monolake/Kconfig
A src/mainboard/ocp/monolake/board.fmd
2 files changed, 27 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/32260/3

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32260 )

Change subject: mb/ocp/monolake: Add board.fmd
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/32260/3/src/mainboard/ocp/monolake/Kconfig 
File src/mainboard/ocp/monolake/Kconfig:

https://review.coreboot.org/#/c/32260/3/src/mainboard/ocp/monolake/Kconfig@4... 
PS3, Line 44: 	default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/vboot-ro.fmd" if VBOOT
there's no vboot-ro.fmd.
Did you forgot to add it?

[insomniac (Code Review)]

insomniac has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32260 )

Change subject: mb/ocp/monolake: Add board.fmd
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/32260/3/src/mainboard/ocp/monolake/Kconfig 
File src/mainboard/ocp/monolake/Kconfig:

https://review.coreboot.org/#/c/32260/3/src/mainboard/ocp/monolake/Kconfig@4... 
PS3, Line 44: 	default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/vboot-ro.fmd" if VBOOT
> there's no vboot-ro.fmd. […]

this should be removed in this changeset and addressed separately

[David Hendricks (Code Review)]

Hello Patrick Rudolph, Name of user not set #1002246, insomniac, Philipp Deppenwiese, build bot (Jenkins), John Looney,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32260

to look at the new patch set (#4).

Change subject: mb/ocp/monolake: Add board.fmd
......................................................................

mb/ocp/monolake: Add board.fmd

Change-Id: I6095c3b30990b530c5bc4e2c808879252680e1d7
Signed-off-by: Andrea Barberio 
Signed-off-by: David Hendricks 
---
M src/mainboard/ocp/monolake/Kconfig
A src/mainboard/ocp/monolake/board.fmd
2 files changed, 26 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/32260/4

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32260 )

Change subject: mb/ocp/monolake: Add board.fmd
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/32260/3/src/mainboard/ocp/monolake/Kconfig 
File src/mainboard/ocp/monolake/Kconfig:

https://review.coreboot.org/#/c/32260/3/src/mainboard/ocp/monolake/Kconfig@4... 
PS3, Line 44: 	default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/vboot-ro.fmd" if VBOOT
> this should be removed in this changeset and addressed separately

Done

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32260 )

Change subject: mb/ocp/monolake: Add board.fmd
......................................................................

Patch Set 4: Code-Review+2

[David Hendricks (Code Review)]

David Hendricks has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32260 )

Change subject: mb/ocp/monolake: Add board.fmd
......................................................................

mb/ocp/monolake: Add board.fmd

Change-Id: I6095c3b30990b530c5bc4e2c808879252680e1d7
Signed-off-by: Andrea Barberio 
Signed-off-by: David Hendricks 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32260
Tested-by: build bot (Jenkins) 
Reviewed-by: Patrick Rudolph 
---
M src/mainboard/ocp/monolake/Kconfig
A src/mainboard/ocp/monolake/board.fmd
2 files changed, 26 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Rudolph: Looks good to me, approved

diff --git a/src/mainboard/ocp/monolake/Kconfig b/src/mainboard/ocp/monolake/Kconfig
index 76ecb48..aff6619 100644
--- a/src/mainboard/ocp/monolake/Kconfig
+++ b/src/mainboard/ocp/monolake/Kconfig
@@ -39,4 +39,8 @@
    bool "Configure defaults for the Intel FSP package"
    default n

+config FMDFILE
+	string
+	default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/board.fmd"
+
 endif # BOARD_OCP_MONOLAKE
diff --git a/src/mainboard/ocp/monolake/board.fmd b/src/mainboard/ocp/monolake/board.fmd
new file mode 100644
index 0000000..d0265e4
--- /dev/null
+++ b/src/mainboard/ocp/monolake/board.fmd
@@ -0,0 +1,22 @@
+FLASH@0xff000000 0x1000000 {
+	SI_ALL@0x0 0x800000 {
+		SI_DESC@0x0 0x1000
+		SI_ME@0x1000 0x7ff000
+	}
+	SI_BIOS@0x800000 0x800000 {
+		FMAP@0x0 0x1000
+		RW_MISC@0x1000 0x9000 {
+			RW_ELOG@0x0 0x4000
+			RW_VPD@0x4000 0x2000
+			RW_NVRAM@0x6000 0x2000
+		}
+		UNUSED@0xa000 0x4000 {
+			# This only exists to satisfy tools that
+			# specifically look for RO_VPD.
+			RO_VPD@0x0 0x4000
+		}
+		RW_MRC_CACHE@0xE000 0x10000
+		CONSOLE@0x1E000 0x10000
+		COREBOOT(CBFS)@0x2E000 0x7d2000
+	}
+}