Attention is currently required from: Shelley Chen, Ravi kumar, Taniya Das, Paul Menzel, Julius Werner.
Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50580 )
Change subject: sc7280: clk: Add clock driver
......................................................................
Patch Set 26:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50580/comment/aa308956_5929fcd6
PS24, Line 7: sc7280: clk: Add clock driver in coreboot
Pleas remove *in coreboot* as it’s the coreboot project.
Ack
https://review.coreboot.org/c/coreboot/+/50580/comment/a21a41ba_577b52fb
PS24, Line 10:
Tested how?
build-tested is valid. The whole patch-train has been tested on QC hardware and does boot to linux kernel login on console.
Commit Message:
https://review.coreboot.org/c/coreboot/+/50580/comment/7d46749b_7fdbe5fc
PS25, Line 7: in coreboot
redundant
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50580
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I590a93cda0d6eccb51b54692b620d43ccacede77
Gerrit-Change-Number: 50580
Gerrit-PatchSet: 26
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Taniya Das
tdas@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Taniya Das
tdas@codeaurora.org
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 06 Apr 2021 11:56:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment